Skip to contentSkip to conversation

arm: omap: Fix switching back to nandecc sw.

U-Boot Superseded Jeroen Hofstee 4 participants 6 messages Aug 10, 2012 – Aug 24, 2012

Subsystems (2)
Memory technology devices (MTD) NAND flash
lore
Share & tools
lore

Jeroen Hofstee

author
#0 lore raw

Switching back to nandecc sw fails to write correctly. A fix for this is already mentioned in the thread below, lets fix it.

mentioned in http://lists.denx.de/pipermail/u-boot/2012-February/119002.html

Signed-off-by Jeroen Hofstee <[email protected]>
---
  drivers/mtd/nand/omap_gpmc.c |    1 +
  1 file changed, 1 insertion(+)
drivers/mtd/nand/omap_gpmc.c +1 -0
index ca868ef..71aec1a 100644
@@ -280,6 +280,7 @@ void omap_nand_switch_ecc(int32_t hardware)
          omap_hwecc_init(nand);
          printf("HW ECC selected\n");
      } else {
+        nand->ecc.size = 0;
          nand->ecc.mode = NAND_ECC_SOFT;
          /* Use mtd default settings */
          nand->ecc.layout = NULL;
Signature · 1 line
1.7.9.5
Acked-by
#1 lore raw

Hi Jeroen,

Thanks for the patch!

Quoted 4 lines · Jeroen Hofstee

Switching back to nandecc sw fails to write correctly. A fix for this is already mentioned in the thread below, lets fix it.

mentioned in http://lists.denx.de/pipermail/u-boot/2012-February/119002.html

I would expect to have an actual explanation in the commit message instead of (or along with) the link above and not just something like:
we fix nandecc sw, want to know more, go somewhere else...

Quoted 2 lines
Signed-off-by Jeroen Hofstee <[email protected]>

After the commit message is fixed,

Acked-by Igor Grinberg <[email protected]>
Quoted 16 lines
---
 drivers/mtd/nand/omap_gpmc.c |    1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/omap_gpmc.c +1 -0
index ca868ef..71aec1a 100644
@@ -280,6 +280,7 @@ void omap_nand_switch_ecc(int32_t hardware)
         omap_hwecc_init(nand);
         printf("HW ECC selected\n");
     } else {
+        nand->ecc.size = 0;
         nand->ecc.mode = NAND_ECC_SOFT;
         /* Use mtd default settings */
         nand->ecc.layout = NULL;
Signature · 2 lines
Regards,
Igor.
Acked-by
#2 lore raw
Acked-by Nikita Kiryanov <[email protected]>
Quoted 47 lines · Igor Grinberg

Hi Jeroen,

Thanks for the patch!

Quoted 4 lines · Jeroen Hofstee

Switching back to nandecc sw fails to write correctly. A fix for this is already mentioned in the thread below, lets fix it.

mentioned in

http://lists.denx.de/pipermail/u-boot/2012-February/119002.html

I would expect to have an actual explanation in the commit message instead of (or along with) the link above and not just something like:
we fix nandecc sw, want to know more, go somewhere else...

Quoted 2 lines
Signed-off-by Jeroen Hofstee <[email protected]>

After the commit message is fixed,

Acked-by Igor Grinberg <[email protected]>
Quoted 9 lines
---
 drivers/mtd/nand/omap_gpmc.c |    1 +
 1 file changed, 1 insertion(+)
drivers/mtd/nand/omap_gpmc.c +0 -0
index ca868ef..71aec1a 100644

drivers/mtd/nand/omap_gpmc.c void omap_nand_switch_ecc(int32_t hardware) · line 286

Quoted 7 lines
drivers/mtd/nand/omap_gpmc.c +1 -0
@@ -280,6 +280,7 @@ void omap_nand_switch_ecc(int32_t hardware)
         omap_hwecc_init(nand);
         printf("HW ECC selected\n");
     } else {
+        nand->ecc.size = 0;
         nand->ecc.mode = NAND_ECC_SOFT;
         /* Use mtd default settings */
         nand->ecc.layout = NULL;

--
Regards,
Igor.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

author
#3 lore raw

PATCH v2 1/1 arm: omap: Fix switching back to nandecc sw.

In reply to Jeroen Hofstee

version 2:
Updated the commit message to include the explanation from the original thread.

For cosmetic reasons, move the added line 2 lines down, so it is similiar to the hw case.

Add original author and maintainer on cc.

Jeroen Hofstee (1):
arm: omap2+: Fix switching back to nandecc sw.

  drivers/mtd/nand/omap_gpmc.c |    1 +
  1 file changed, 1 insertion(+)
Signature · 1 line
1.7.9.5
author
#4 lore raw

PATCH v2 1/1 arm: omap: Fix switching back to nandecc sw.

Orjan Friberg wrote at [1]:

"For the beagleboard, ecc.size is not explicitly set when doing 'nandecc sw'. If it's not set for the NAND_ECC_SOFT case in nand_scan_tail, it's set to 256 bytes.

When doing 'nandecc hw', ecc.size is set to 512 bytes. Hence, when changing back to 'nandecc sw' ecc.size remains at 512 bytes and suddenly the format has changed."

No patch has been submitted and the issue was still present. This patch adds the mentioned solution. Tested on a tam3517 board.

[1] http://lists.denx.de/pipermail/u-boot/2012-February/119002.html

cc Orjan Friberg <[email protected]>
Acked-by Igor Grinberg <[email protected]>
Acked-by Nikita Kiryanov <[email protected]>
Signed-off-by Jeroen Hofstee <[email protected]>
---
  drivers/mtd/nand/omap_gpmc.c |    1 +
  1 file changed, 1 insertion(+)
drivers/mtd/nand/omap_gpmc.c +1 -0
index ca868ef..f1469d1 100644
@@ -283,6 +283,7 @@ void omap_nand_switch_ecc(int32_t hardware)
          nand->ecc.mode = NAND_ECC_SOFT;
          /* Use mtd default settings */
          nand->ecc.layout = NULL;
+        nand->ecc.size = 0;
          printf("SW ECC selected\n");
      }
Signature · 1 line
1.7.9.5
#5 lore raw

PATCH v2 1/1 arm: omap: Fix switching back to nandecc sw.

In reply to Jeroen Hofstee
Quoted 11 lines · Jeroen Hofstee

version 2:
Updated the commit message to include the explanation from the original thread.

For cosmetic reasons, move the added line 2 lines down, so it is similiar to the hw case.

Add original author and maintainer on cc.

Jeroen Hofstee (1):
arm: omap2+: Fix switching back to nandecc sw.

Queued up for u-boot-ti/master, thanks!

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120824/62345557/attachment.pgp>