at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support
cover at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support
This patch series will add PMECC support for atmel nand driver in u-boot.
The driver patch is ported from kernel patch. The main different from kernel patch is the modification about registers access part. in this version it via a register structure to access.
It is tested in atmel 9x5 series board.
Josh Wu (3):
at91: atmel_nand: extract HWECC initialization code into one function:
atmel_hw_nand_init_param().
at91: atmel_nand: remove unused variables.
at91: atmel_nand: Update driver to support Programmable Multibit
ECC controller
drivers/mtd/nand/atmel_nand.c | 759 ++++++++++++++++++++++++++++++++++--- drivers/mtd/nand/atmel_nand_ecc.h | 107 ++++++ 2 files changed, 813 insertions(+), 53 deletions(-)
Signature · 1 line
1.7.9.5
PATCH 1/3 at91: atmel_nand: extract HWECC initialization code into one function: atmel_hw_nand_init_param().
Extract the hwecc initialization code into one function. It is a preparation for adding atmel PMECC support.
--- drivers/mtd/nand/atmel_nand.c | 108 ++++++++++++++++++++++------------------- 1 file changed, 57 insertions(+), 51 deletions(-)
drivers/mtd/nand/atmel_nand.c +57 -51
@@ -232,68 +232,19 @@ static int atmel_nand_correct(struct mtd_info *mtd, u_char *dat,static void atmel_nand_hwctl (struct mtd_info *mtd,int mode) { } -#endif - -static void at91_nand_hwcontrol (struct mtd_info *mtd, -int cmd,unsigned int ctrl) -{ -struct nand_chip *this = mtd->priv; - -if (ctrl &NAND_CTRL_CHANGE ) { -ulong IO_ADDR_W = (ulong ) this->IO_ADDR_W; -IO_ADDR_W &= ~(CONFIG_SYS_NAND_MASK_ALE - |CONFIG_SYS_NAND_MASK_CLE ); - -if (ctrl &NAND_CLE ) -IO_ADDR_W |=CONFIG_SYS_NAND_MASK_CLE ; -if (ctrl &NAND_ALE ) -IO_ADDR_W |=CONFIG_SYS_NAND_MASK_ALE ; - -#ifdef CONFIG_SYS_NAND_ENABLE_PIN -at91_set_gpio_value (CONFIG_SYS_NAND_ENABLE_PIN , - !(ctrl &NAND_NCE )); -#endif - this->IO_ADDR_W = (void *)IO_ADDR_W ; - } - -if (cmd !=NAND_CMD_NONE ) -writeb (cmd, this->IO_ADDR_W); -} -#ifdef CONFIG_SYS_NAND_READY_PIN -static int at91_nand_ready (struct mtd_info *mtd) +int atmel_hw_nand_init_param (struct nand_chip *nand) { -return at91_get_gpio_value (CONFIG_SYS_NAND_READY_PIN ); -} -#endif - -int board_nand_init (struct nand_chip *nand) -{ -#ifdef CONFIG_ATMEL_NAND_HWECC static int chip_nr =0 ;struct mtd_info *mtd; -#endif - - nand->ecc.mode =NAND_ECC_SOFT ; -#ifdef CONFIG_SYS_NAND_DBW_16 - nand->options =NAND_BUSWIDTH_16 ; -#endif - nand->cmd_ctrl = at91_nand_hwcontrol; -#ifdef CONFIG_SYS_NAND_READY_PIN - nand->dev_ready = at91_nand_ready; -#endif - nand->chip_delay =20 ; -#ifdef CONFIG_ATMEL_NAND_HWECC nand->ecc.mode =NAND_ECC_HW ; nand->ecc.calculate = atmel_nand_calculate; nand->ecc.correct = atmel_nand_correct; nand->ecc.hwctl = atmel_nand_hwctl; nand->ecc.read_page = atmel_nand_read_page; nand->ecc.bytes =4 ; -#endif -#ifdef CONFIG_ATMEL_NAND_HWECC mtd = &nand_info[chip_nr++]; mtd->priv = nand;
@@ -339,7 +290,62 @@ int board_nand_init(struct nand_chip *nand) break; } } -#endif return 0 ; } + +#endif + +static void at91_nand_hwcontrol (struct mtd_info *mtd, +int cmd,unsigned int ctrl) +{ +struct nand_chip *this = mtd->priv; + +if (ctrl &NAND_CTRL_CHANGE ) { +ulong IO_ADDR_W = (ulong ) this->IO_ADDR_W; +IO_ADDR_W &= ~(CONFIG_SYS_NAND_MASK_ALE + |CONFIG_SYS_NAND_MASK_CLE ); + +if (ctrl &NAND_CLE ) +IO_ADDR_W |=CONFIG_SYS_NAND_MASK_CLE ; +if (ctrl &NAND_ALE ) +IO_ADDR_W |=CONFIG_SYS_NAND_MASK_ALE ; + +#ifdef CONFIG_SYS_NAND_ENABLE_PIN +at91_set_gpio_value (CONFIG_SYS_NAND_ENABLE_PIN , + !(ctrl &NAND_NCE )); +#endif + this->IO_ADDR_W = (void *)IO_ADDR_W ; + } + +if (cmd !=NAND_CMD_NONE ) +writeb (cmd, this->IO_ADDR_W); +} + +#ifdef CONFIG_SYS_NAND_READY_PIN +static int at91_nand_ready (struct mtd_info *mtd) +{ +return at91_get_gpio_value (CONFIG_SYS_NAND_READY_PIN ); +} +#endif + +int board_nand_init (struct nand_chip *nand) +{ +int res =0 ; + + nand->ecc.mode =NAND_ECC_SOFT ; +#ifdef CONFIG_SYS_NAND_DBW_16 + nand->options =NAND_BUSWIDTH_16 ; +#endif + nand->cmd_ctrl = at91_nand_hwcontrol; +#ifdef CONFIG_SYS_NAND_READY_PIN + nand->dev_ready = at91_nand_ready; +#endif + nand->chip_delay =20 ; + +#ifdef CONFIG_ATMEL_NAND_HWECC + res =atmel_hw_nand_init_param (nand); +#endif + +return res; +}
Signature · 1 line
1.7.9.5
PATCH 2/3 at91: atmel_nand: remove unused variables.
In reply to Josh Wu--- drivers/mtd/nand/atmel_nand.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/mtd/nand/atmel_nand.c +1 -2
@@ -79,7 +79,6 @@ static struct nand_ecclayout atmel_oobinfo_small = {static int atmel_nand_calculate (struct mtd_info *mtd,const u_char *dat,unsigned char *ecc_code) { -struct nand_chip *nand_chip = mtd->priv;unsigned int ecc_value;/* get the first 2 ECC bytes */
@@ -167,7 +166,7 @@ static int atmel_nand_correct(struct mtd_info *mtd, u_char *dat, u_char *read_ecc, u_char *isnull) {struct nand_chip *nand_chip = mtd->priv; -unsigned int ecc_status, ecc_parity, ecc_mode; +unsigned int ecc_status;unsigned int ecc_word, ecc_bit;/* get the status from the Status Register */
Signature · 1 line
1.7.9.5
PATCH 3/3 at91: atmel_nand: Update driver to support Programmable Multibit ECC controller
In reply to Josh Wu The Programmable Multibit ECC (PMECC) controller is a programmable binary BCH(Bose, Chaudhuri and Hocquenghem) encoder and decoder. This controller can be used to support both SLC and MLC NAND Flash devices. It supports to generate ECC to correct 2, 4, 8, 12 or 24 bits of error per sector of data.
To use PMECC in this driver, the user needs to set the PMECC correction capability, the sector size and ROM lookup table offsets in board config file.
This driver is ported from Linux kernel atmel_nand PMECC patch. It is tested in 9x5 serial boards.
--- drivers/mtd/nand/atmel_nand.c | 650 ++++++++++++++++++++++++++++++++++++- drivers/mtd/nand/atmel_nand_ecc.h | 107 ++++++ 2 files changed, 756 insertions(+), 1 deletion(-)
drivers/mtd/nand/atmel_nand.c +649 -1
@@ -5,6 +5,9 @@* * (C) Copyright 2006 ATMEL Rousset, Lacressonniere Nicolas * +* Add Programmable Multibit ECC support for various AT91 SoC +* (C) Copyright 2012 ATMEL, Hong Xu +* * See file CREDITS for list of people who contributed to this * project. *
@@ -41,6 +44,645 @@#include "atmel_nand_ecc.h" /* Hardware ECC registers */ +#ifdef CONFIG_ATMEL_NAND_HW_PMECC + +struct atmel_nand_host { +struct pmecc_regs __iomem *pmecc; +struct pmecc_errloc_regs __iomem *pmerrloc; +void __iomem *pmecc_rom_base; + +u8 pmecc_corr_cap; +u16 pmecc_sector_size; +u32 pmecc_lookup_table_offset; + +int pmecc_bytes_per_sector; +int pmecc_sector_number; +int pmecc_degree;/* Degree of remainders */ +int pmecc_cw_len;/* Length of codeword */ + +/* lookup table for alpha_to and index_of */ +void __iomem *pmecc_alpha_to; +void __iomem *pmecc_index_of; + +/* data for pmecc computation */ +int16_t pmecc_partial_syn[2 *CONFIG_PMECC_CAP +1 ]; +int16_t pmecc_si[2 *CONFIG_PMECC_CAP +1 ]; +int16_t pmecc_smu[(CONFIG_PMECC_CAP +2 ) * (2 *CONFIG_PMECC_CAP +1 )];/* Sigma table */ +int16_t pmecc_lmu[CONFIG_PMECC_CAP +1 ];/* polynomal order */ +int pmecc_mu[CONFIG_PMECC_CAP +1 ]; +int pmecc_dmu[CONFIG_PMECC_CAP +1 ]; +int pmecc_delta[CONFIG_PMECC_CAP +1 ]; +}; + +static struct atmel_nand_host pmecc_host; +static struct nand_ecclayout atmel_pmecc_oobinfo; + +/* +* Return number of ecc bytes per sector according to sector size and +* correction capability +* +* Following table shows what at91 PMECC supported: +* Correction Capability Sector_512_bytes Sector_1024_bytes +* ===================== ================ ================= +* 2-bits 4-bytes 4-bytes +* 4-bits 7-bytes 7-bytes +* 8-bits 13-bytes 14-bytes +* 12-bits 20-bytes 21-bytes +* 24-bits 39-bytes 42-bytes +*/ +static int pmecc_get_ecc_bytes (int cap,int sector_size) +{ +int m =12 + sector_size /512 ; +return (m * cap +7 ) /8 ; +} + +static void pmecc_config_ecc_layout (struct nand_ecclayout *layout, +int oobsize,int ecc_len) +{ +int i; + + layout->eccbytes = ecc_len; + +/* ECC will occupy the last ecc_len bytes continuously */ +for (i =0 ; i < ecc_len; i++) + layout->eccpos[i] = oobsize - ecc_len + i; + + layout->oobfree[0 ].offset =2 ; + layout->oobfree[0 ].length = + oobsize - ecc_len - layout->oobfree[0 ].offset; +} + +static void __iomem *pmecc_get_alpha_to (struct atmel_nand_host *host) +{ +int table_size; + + table_size = host->pmecc_sector_size ==512 ? +PMECC_LOOKUP_TABLE_SIZE_512 :PMECC_LOOKUP_TABLE_SIZE_1024 ; + +return host->pmecc_rom_base + host->pmecc_lookup_table_offset + + table_size *sizeof (int16_t ); +} + +static void pmecc_gen_syndrome (struct mtd_info *mtd,int sector) +{ +struct nand_chip *nand_chip = mtd->priv; +struct atmel_nand_host *host = nand_chip->priv; +int i; +uint32_t value; + +/* Fill odd syndromes */ +for (i =0 ; i < host->pmecc_corr_cap; i++) { + value =readl (&host->pmecc->rem_port[sector].rem[i /2 ]); +if (i &1 ) + value >>=16 ; + value &=0xffff ; + host->pmecc_partial_syn[(2 * i) +1 ] = (int16_t )value; + } +} + +static void pmecc_substitute (struct mtd_info *mtd) +{ +struct nand_chip *nand_chip = mtd->priv; +struct atmel_nand_host *host = nand_chip->priv; +int16_t __iomem *alpha_to = host->pmecc_alpha_to; +int16_t __iomem *index_of = host->pmecc_index_of; +int16_t *partial_syn = host->pmecc_partial_syn; +const int cap = host->pmecc_corr_cap; +int16_t *si; +int i, j; + +/* si[] is a table that holds the current syndrome value, +* an element of that table belongs to the field +*/ + si = host->pmecc_si; + +memset (&si[1 ],0 ,sizeof (int16_t ) * (2 * cap -1 )); + +/* Computation 2t syndromes based on S(x) */ +/* Odd syndromes */ +for (i =1 ; i <2 * cap; i +=2 ) { +for (j =0 ; j < host->pmecc_degree; j++) { +if (partial_syn[i] & ((unsigned short )0x1 << j)) + si[i] =readw (alpha_to + i * j) ^ si[i]; + } + } +/* Even syndrome = (Odd syndrome) ** 2 */ +for (i =2 , j =1 ; j <= cap; i = ++j <<1 ) { +if (si[j] ==0 ) { + si[i] =0 ; + }else { +int16_t tmp; + + tmp =readw (index_of + si[j]); + tmp = (tmp *2 ) % host->pmecc_cw_len; + si[i] =readw (alpha_to + tmp); + } + } + +return ; +} + +static void pmecc_get_sigma (struct mtd_info *mtd) +{ +struct nand_chip *nand_chip = mtd->priv; +struct atmel_nand_host *host = nand_chip->priv; + +int16_t *lmu = host->pmecc_lmu; +int16_t *si = host->pmecc_si; +int *mu = host->pmecc_mu; +int *dmu = host->pmecc_dmu;/* Discrepancy */ +int *delta = host->pmecc_delta;/* Delta order */ +int cw_len = host->pmecc_cw_len; +const int16_t cap = host->pmecc_corr_cap; +const int num =2 * cap +1 ; +int16_t __iomem *index_of = host->pmecc_index_of; +int16_t __iomem *alpha_to = host->pmecc_alpha_to; +int i, j, k; +uint32_t dmu_0_count, tmp; +int16_t *smu = host->pmecc_smu; + +/* index of largest delta */ +int ro; +int largest; +int diff; + + dmu_0_count =0 ; + +/* First Row */ + +/* Mu */ + mu[0 ] =-1 ; + +memset (smu,0 ,sizeof (int16_t ) * num); + smu[0 ] =1 ; + +/* discrepancy set to 1 */ + dmu[0 ] =1 ; +/* polynom order set to 0 */ + lmu[0 ] =0 ; + delta[0 ] = (mu[0 ] *2 - lmu[0 ]) >>1 ; + +/* Second Row */ + +/* Mu */ + mu[1 ] =0 ; +/* Sigma(x) set to 1 */ +memset (&smu[num],0 ,sizeof (int16_t ) * num); + smu[num] =1 ; + +/* discrepancy set to S1 */ + dmu[1 ] = si[1 ]; + +/* polynom order set to 0 */ + lmu[1 ] =0 ; + + delta[1 ] = (mu[1 ] *2 - lmu[1 ]) >>1 ; + +/* Init the Sigma(x) last row */ +memset (&smu[(cap +1 ) * num],0 ,sizeof (int16_t ) * num); + +for (i =1 ; i <= cap; i++) { + mu[i +1 ] = i <<1 ; +/* Begin Computing Sigma (Mu+1) and L(mu) */ +/* check if discrepancy is set to 0 */ +if (dmu[i] ==0 ) { + dmu_0_count++; + + tmp = ((cap - (lmu[i] >>1 ) -1 ) /2 ); +if ((cap - (lmu[i] >>1 ) -1 ) &0x1 ) + tmp +=2 ; +else + tmp +=1 ; + +if (dmu_0_count == tmp) { +for (j =0 ; j <= (lmu[i] >>1 ) +1 ; j++) + smu[(cap +1 ) * num + j] = + smu[i * num + j]; + + lmu[cap +1 ] = lmu[i]; +return ; + } + +/* copy polynom */ +for (j =0 ; j <= lmu[i] >>1 ; j++) + smu[(i +1 ) * num + j] = smu[i * num + j]; + +/* copy previous polynom order to the next */ + lmu[i +1 ] = lmu[i]; + }else { + ro =0 ; + largest =-1 ; +/* find largest delta with dmu != 0 */ +for (j =0 ; j < i; j++) { +if ((dmu[j]) && (delta[j] > largest)) { + largest = delta[j]; + ro = j; + } + } + +/* compute difference */ + diff = (mu[i] - mu[ro]); + +/* Compute degree of the new smu polynomial */ +if ((lmu[i] >>1 ) > ((lmu[ro] >>1 ) + diff)) + lmu[i +1 ] = lmu[i]; +else + lmu[i +1 ] = ((lmu[ro] >>1 ) + diff) *2 ; + +/* Init smu[i+1] with 0 */ +for (k =0 ; k < num; k++) + smu[(i +1 ) * num + k] =0 ; + +/* Compute smu[i+1] */ +for (k =0 ; k <= lmu[ro] >>1 ; k++) { +int16_t a, b, c; + +if (!(smu[ro * num + k] && dmu[i])) +continue ; + a =readw (index_of + dmu[i]); + b =readw (index_of + dmu[ro]); + c =readw (index_of + smu[ro * num + k]); + tmp = a + (cw_len - b) + c; + a =readw (alpha_to + tmp % cw_len); + smu[(i +1 ) * num + (k + diff)] = a; + } + +for (k =0 ; k <= lmu[i] >>1 ; k++) + smu[(i +1 ) * num + k] ^= smu[i * num + k]; + } + +/* End Computing Sigma (Mu+1) and L(mu) */ +/* In either case compute delta */ + delta[i +1 ] = (mu[i +1 ] *2 - lmu[i +1 ]) >>1 ; + +/* Do not compute discrepancy for the last iteration */ +if (i >= cap) +continue ; + +for (k =0 ; k <= (lmu[i +1 ] >>1 ); k++) { + tmp =2 * (i -1 ); +if (k ==0 ) { + dmu[i +1 ] = si[tmp +3 ]; + }else if (smu[(i +1 ) * num + k] && si[tmp +3 - k]) { +int16_t a, b, c; + a =readw (index_of + + smu[(i +1 ) * num + k]); + b = si[2 * (i -1 ) +3 - k]; + c =readw (index_of + b); + tmp = a + c; + tmp %= cw_len; + dmu[i +1 ] =readw (alpha_to + tmp) ^ + dmu[i +1 ]; + } + } + } + +return ; +} + +static int pmecc_err_location (struct mtd_info *mtd) +{ +struct nand_chip *nand_chip = mtd->priv; +struct atmel_nand_host *host = nand_chip->priv; +const int cap = host->pmecc_corr_cap; +const int num =2 * cap +1 ; +int sector_size = host->pmecc_sector_size; +int err_nbr =0 ;/* number of error */ +int roots_nbr;/* number of roots */ +int i; +uint32_t val; +int16_t *smu = host->pmecc_smu; + +writel (PMERRLOC_DISABLE , &host->pmerrloc->eldis); + +for (i =0 ; i <= host->pmecc_lmu[cap +1 ] >>1 ; i++) { +writel (smu[(cap +1 ) * num + i], &host->pmerrloc->sigma[i]); + err_nbr++; + } + + val =PMERRLOC_ELCFG_NUM_ERRORS (err_nbr -1 ); +if (sector_size ==1024 ) + val |=PMERRLOC_ELCFG_SECTOR_1024 ; + +writel (val, &host->pmerrloc->elcfg); +writel (sector_size *8 + host->pmecc_degree * cap, + &host->pmerrloc->elen); + +while (!(readl (&host->pmerrloc->elisr) &PMERRLOC_CALC_DONE )) +udelay (10 ); + + roots_nbr = (readl (&host->pmerrloc->elisr) &PMERRLOC_ERR_NUM_MASK ) + >>8 ; +/* Number of roots == degree of smu hence <= cap */ +if (roots_nbr == host->pmecc_lmu[cap +1 ] >>1 ) +return err_nbr -1 ; + +/* Number of roots does not match the degree of smu +* unable to correct error */ +return -1 ; +} + +static void pmecc_correct_data (struct mtd_info *mtd,uint8_t *buf,uint8_t *ecc, +int sector_num,int extra_bytes,int err_nbr) +{ +struct nand_chip *nand_chip = mtd->priv; +struct atmel_nand_host *host = nand_chip->priv; +int i =0 ; +int byte_pos, bit_pos, sector_size, pos; +uint32_t tmp; +uint8_t err_byte; + + sector_size = host->pmecc_sector_size; + +while (err_nbr) { + tmp =readl (&host->pmerrloc->el[i]) -1 ; + byte_pos = tmp /8 ; + bit_pos = tmp %8 ; + +if (byte_pos >= (sector_size + extra_bytes)) +BUG ();/* should never happen */ + +if (byte_pos < sector_size) { + err_byte = *(buf + byte_pos); + *(buf + byte_pos) ^= (1 << bit_pos); + + pos = sector_num * host->pmecc_sector_size + byte_pos; +printk (KERN_INFO "Bit flip in data area, byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n" , + pos, bit_pos, err_byte, *(buf + byte_pos)); + }else { +/* Bit flip in OOB area */ + tmp = sector_num * host->pmecc_bytes_per_sector + + (byte_pos - sector_size); + err_byte = ecc[tmp]; + ecc[tmp] ^= (1 << bit_pos); + + pos = tmp + nand_chip->ecc.layout->eccpos[0 ]; +printk (KERN_INFO "Bit flip in OOB, oob_byte_pos: %d, bit_pos: %d, 0x%02x -> 0x%02x\n" , + pos, bit_pos, err_byte, ecc[tmp]); + } + + i++; + err_nbr--; + } + +return ; +} + +static int pmecc_correction (struct mtd_info *mtd,u32 pmecc_stat,uint8_t *buf, +u8 *ecc) +{ +struct nand_chip *nand_chip = mtd->priv; +struct atmel_nand_host *host = nand_chip->priv; +int i, err_nbr, eccbytes; +uint8_t *buf_pos; + + eccbytes = nand_chip->ecc.bytes; +for (i =0 ; i < eccbytes; i++) +if (ecc[i] !=0xff ) + goto normal_check; +/* Erased page, return OK */ +return 0 ; + +normal_check: +for (i =0 ; i < host->pmecc_sector_number; i++) { + err_nbr =0 ; +if (pmecc_stat &0x1 ) { + buf_pos = buf + i * host->pmecc_sector_size; + +pmecc_gen_syndrome (mtd, i); +pmecc_substitute (mtd); +pmecc_get_sigma (mtd); + + err_nbr =pmecc_err_location (mtd); +if (err_nbr ==-1 ) { +printk (KERN_ERR "PMECC: Too many errors\n" ); + mtd->ecc_stats.failed++; +return -EIO ; + }else { +pmecc_correct_data (mtd, buf_pos, ecc, i, + host->pmecc_bytes_per_sector, err_nbr); + mtd->ecc_stats.corrected += err_nbr; + } + } + pmecc_stat >>=1 ; + } + +return 0 ; +} + +static int atmel_nand_pmecc_read_page (struct mtd_info *mtd, +struct nand_chip *chip,uint8_t *buf,int page) +{ +struct atmel_nand_host *host = chip->priv; +int eccsize = chip->ecc.size; +uint8_t *oob = chip->oob_poi; +uint32_t *eccpos = chip->ecc.layout->eccpos; +uint32_t stat; + +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_RST ); +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_DISABLE ); +pmecc_writel (host->pmecc, cfg, ((pmecc_readl (host->pmecc, cfg)) + & ~PMECC_CFG_WRITE_OP ) |PMECC_CFG_AUTO_ENABLE ); + +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_ENABLE ); +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_DATA ); + + chip->read_buf (mtd, buf, eccsize); + chip->read_buf (mtd, oob, mtd->oobsize); + +while ((pmecc_readl (host->pmecc, sr) &PMECC_SR_BUSY )) +udelay (1 ); + + stat =pmecc_readl (host->pmecc, isr); +if (stat !=0 ) +if (pmecc_correction (mtd, stat, buf, &oob[eccpos[0 ]]) !=0 ) +return -EIO ; + +return 0 ; +} + +static void atmel_nand_pmecc_write_page (struct mtd_info *mtd, +struct nand_chip *chip,const uint8_t *buf) +{ +struct atmel_nand_host *host = chip->priv; +uint32_t *eccpos = chip->ecc.layout->eccpos; +int i, j; + +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_RST ); +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_DISABLE ); + +pmecc_writel (host->pmecc, cfg, (pmecc_readl (host->pmecc, cfg) | +PMECC_CFG_WRITE_OP ) & ~PMECC_CFG_AUTO_ENABLE ); + +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_ENABLE ); +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_DATA ); + + chip->write_buf (mtd, (u8 *)buf, mtd->writesize); + +while ((pmecc_readl (host->pmecc, sr) &PMECC_SR_BUSY )) +udelay (1 ); + +for (i =0 ; i < host->pmecc_sector_number; i++) { +for (j =0 ; j < host->pmecc_bytes_per_sector; j++) { +int pos; + + pos = i * host->pmecc_bytes_per_sector + j; + chip->oob_poi[eccpos[pos]] = +readb (&host->pmecc->ecc_port[i].ecc[j]); + } + } + chip->write_buf (mtd, chip->oob_poi, mtd->oobsize); +} + +static void atmel_pmecc_core_init (struct mtd_info *mtd) +{ +struct nand_chip *nand_chip = mtd->priv; +struct atmel_nand_host *host = nand_chip->priv; +uint32_t val =0 ; +struct nand_ecclayout *ecc_layout; + +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_RST ); +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_DISABLE ); + +switch (host->pmecc_corr_cap) { +case 2 : + val =PMECC_CFG_BCH_ERR2 ; +break ; +case 4 : + val =PMECC_CFG_BCH_ERR4 ; +break ; +case 8 : + val =PMECC_CFG_BCH_ERR8 ; +break ; +case 12 : + val =PMECC_CFG_BCH_ERR12 ; +break ; +case 24 : + val =PMECC_CFG_BCH_ERR24 ; +break ; + } + +if (host->pmecc_sector_size ==512 ) + val |=PMECC_CFG_SECTOR512 ; +else if (host->pmecc_sector_size ==1024 ) + val |=PMECC_CFG_SECTOR1024 ; + +switch (host->pmecc_sector_number) { +case 1 : + val |=PMECC_CFG_PAGE_1SECTOR ; +break ; +case 2 : + val |=PMECC_CFG_PAGE_2SECTORS ; +break ; +case 4 : + val |=PMECC_CFG_PAGE_4SECTORS ; +break ; +case 8 : + val |=PMECC_CFG_PAGE_8SECTORS ; +break ; + } + + val |= (PMECC_CFG_READ_OP |PMECC_CFG_SPARE_DISABLE + |PMECC_CFG_AUTO_DISABLE ); +pmecc_writel (host->pmecc, cfg, val); + + ecc_layout = nand_chip->ecc.layout; +pmecc_writel (host->pmecc, sarea, mtd->oobsize -1 ); +pmecc_writel (host->pmecc, saddr, ecc_layout->eccpos[0 ]); +pmecc_writel (host->pmecc, eaddr, + ecc_layout->eccpos[ecc_layout->eccbytes -1 ]); +/* See datasheet about PMECC Clock Control Register */ +pmecc_writel (host->pmecc, clk,PMECC_CLK_133MHZ ); +pmecc_writel (host->pmecc, idr,0xff ); +pmecc_writel (host->pmecc, ctrl,PMECC_CTRL_ENABLE ); +} + +static int atmel_pmecc_nand_init_params (struct nand_chip *nand) +{ +static int chip_nr =0 ; +struct mtd_info *mtd; +struct atmel_nand_host *host; +int cap, sector_size; + + mtd = &nand_info[chip_nr++]; + mtd->priv = nand; + host = nand->priv = &pmecc_host; + +/* Detect NAND chips */ +if (nand_scan_ident (mtd,1 ,NULL )) { +printk (KERN_WARNING "NAND Flash not found !\n" ); +return -ENXIO ; + } + + nand->ecc.mode =NAND_ECC_HW ; + nand->ecc.calculate =NULL ; + nand->ecc.correct =NULL ; + nand->ecc.hwctl =NULL ; + + cap = host->pmecc_corr_cap =CONFIG_PMECC_CAP ; + sector_size = host->pmecc_sector_size =CONFIG_PMECC_SECTOR_SIZE ; + host->pmecc_lookup_table_offset =CONFIG_PMECC_LOOKUP_TABLE_OFFSET ; + +printk (KERN_INFO "Initialize PMECC params, cap: %d, sector: %d\n" , + cap, sector_size); + + host->pmecc = (struct pmecc_regs __iomem *)ATMEL_BASE_PMECC ; + host->pmerrloc = (struct pmecc_errloc_regs __iomem *)ATMEL_BASE_PMERRLOC ; + host->pmecc_rom_base = (void __iomem *)ATMEL_BASE_ROM ; + +/* ECC is calculated for the whole page (1 step) */ + nand->ecc.size = mtd->writesize; + +/* set ECC page size and oob layout */ +switch (mtd->writesize) { +case 2048 : + host->pmecc_degree =PMECC_GF_DIMENSION_13 ; + host->pmecc_cw_len = (1 << host->pmecc_degree) -1 ; + host->pmecc_sector_number = mtd->writesize / sector_size; + host->pmecc_bytes_per_sector =pmecc_get_ecc_bytes ( + cap, sector_size); + host->pmecc_alpha_to =pmecc_get_alpha_to (host); + host->pmecc_index_of = host->pmecc_rom_base + + host->pmecc_lookup_table_offset; + + nand->ecc.steps =1 ; + nand->ecc.bytes = host->pmecc_bytes_per_sector * + host->pmecc_sector_number; +if (nand->ecc.bytes > mtd->oobsize -2 ) { +printk (KERN_ERR "No room for ECC bytes\n" ); +return -EINVAL ; + } +pmecc_config_ecc_layout (&atmel_pmecc_oobinfo, + mtd->oobsize, + nand->ecc.bytes); + nand->ecc.layout = &atmel_pmecc_oobinfo; +break ; +case 512 : +case 1024 : +case 4096 : +/* TODO */ +printk (KERN_ERR "Unsupported page size for PMECC, use Software ECC\n" ); +default : +/* page size not handled by HW ECC */ +/* switching back to soft ECC */ + nand->ecc.mode =NAND_ECC_SOFT ; + nand->ecc.read_page =NULL ; + nand->ecc.postpad =0 ; + nand->ecc.prepad =0 ; + nand->ecc.bytes =0 ; +return 0 ; + } + + nand->ecc.read_page = atmel_nand_pmecc_read_page; + nand->ecc.write_page = atmel_nand_pmecc_write_page; + +atmel_pmecc_core_init (mtd); + +return 0 ; +} + +#else +/* oob layout for large page size * bad block info is on bytes 0 and 1 * the bytes have to be consecutives to avoid
@@ -293,7 +935,9 @@ int atmel_hw_nand_init_param(struct nand_chip *nand)return 0 ; } -#endif +#endif /* CONFIG_ATMEL_NAND_HW_PMECC */ + +#endif /* CONFIG_ATMEL_NAND_HWECC */ static void at91_nand_hwcontrol (struct mtd_info *mtd,int cmd,unsigned int ctrl)
@@ -343,8 +987,12 @@ int board_nand_init(struct nand_chip *nand) nand->chip_delay =20 ;#ifdef CONFIG_ATMEL_NAND_HWECC +#ifdef CONFIG_ATMEL_NAND_HW_PMECC + res =atmel_pmecc_nand_init_params (nand); +#else res =atmel_hw_nand_init_param (nand);#endif +#endif return res; }
drivers/mtd/nand/atmel_nand_ecc.h +107 -0
111 lines not on this page · raw message
Signature · 1 line
1.7.9.5
cover at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support
In reply to Josh WuHi, Andreas
Sorry, in these patches of current version, it still has a bug, which will fail to write with PMECC, I will send out the v2 patch soon which include this bug fix.
Best Regards,
Josh Wu
Quoted 18 lines · Josh Wu
This patch series will add PMECC support for atmel nand driver in u-boot.
The driver patch is ported from kernel patch. The main different from kernel patch is the modification about registers access part. in this version it via a register structure to access.
It is tested in atmel 9x5 series board.
Josh Wu (3):
at91:atmel_nand: extract HWECC initialization code into one function:atmel_hw_nand_init_param().at91:
atmel_nand: remove unused variables.
at91:atmel_nand: Update driver to support Programmable Multibit
ECC controllerdrivers/mtd/nand/atmel_nand.c | 759 ++++++++++++++++++++++++++++++++++--- drivers/mtd/nand/atmel_nand_ecc.h | 107 ++++++ 2 files changed, 813 insertions(+), 53 deletions(-)
cover at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support
Dear Josh Wu,
Quoted 5 lines · Josh Wu
Hi, Andreas
Sorry, in these patches of current version, it still has a bug, which will fail to write with PMECC, I will send out the v2 patch soon which include this bug fix.
Oups, sorry I had this patch series not on my list. Will review this or v2 these days.
On first sight the first two in series are ok, the third one has style problems:
---8<---
abiessmann@azuregos % ./tools/checkpatch.pl U-Boot-3-3-at91-atmel_nand-Update-driver-to-support-Programmable-Multibit-ECC-controller.patch
WARNING: line over 80 characters
...
total: 1 errors, 27 warnings, 787 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
U-Boot-3-3-at91-atmel_nand-Update-driver-to-support-Programmable-Multibit-ECC-controller.patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. --->8---
I personally do not really care about the 80 char warning but please remove these for the sake of peace ;) and please have a look for the reported error.
And the last, you should add at least one user of this feature. Isn't the lately applied at91sam9x5ek (is in u-boot-atmel/master and u-boot-arm/master) a perfect user for that?
Quoted 7 lines · Josh Wu
Quoted 6 lines
This patch series will add PMECC support for atmel nand driver in u-boot.
The driver patch is ported from kernel patch. The main different from kernel patch is
the modification about registers access part. in this version it via a register structure to access.
A question regarding linux driver. You say it is derived from the kernel driver, but I can not see PMECC stuff in kernel:
---8<---
abiessmann at azuregos % git describe v3.6-rc1-355-gddf343f
abiessmann at azuregos % diff -Nrupa drivers/mtd/nand/atmel_nand.c ../u-boot/drivers/mtd/nand/atmel_nand.c | diffstat
atmel_nand.c | 1231 ++++++++++++++++++++++++++++++++++------------------------- 1 file changed, 720 insertions(+), 511 deletions(-)
abiessmann at azuregos % grep -in pmecc drivers/mtd/nand/atmel_nand* abiessmann@azuregos %
--->8---
Which driver/patch do you mean?
Quoted 1 line
Quoted 1 line
It is tested in atmel 9x5 series board.
Unfortunately I can not test this driver cause I do only have older sam926x devices around.
Best regards
Andreas Bie?mann
cover at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support
Hi, Andreas
Thank you for the quick reply.
Quoted 26 lines · Andreas Bie?mann
Dear Josh Wu,
Quoted 5 lines · Josh Wu
Hi, Andreas
Sorry, in these patches of current version, it still has a bug, which will fail to write with PMECC, I will send out the v2 patch soon which include this bug fix.
Oups, sorry I had this patch series not on my list. Will review this or v2 these days.
On first sight the first two in series are ok, the third one has style problems:---8<---
abiessmann at azuregos %./tools/checkpatch.plU-Boot-3-3-at91-atmel_nand-Update-driver-to-support-Programmable-Multibit-ECC-controller.patch
WARNING: line over 80 characters
...
total: 1 errors, 27 warnings, 787 lines checkedNOTE: Ignored message types:
COMPLEX_MACROCONSIDER_KSTRTOMINMAXMULTISTATEMENT_MACRO_USE_DO_WHILEU-Boot-3-3-at91-atmel_nand-Update-driver-to-support-Programmable-Multibit-ECC-controller.patch has style problems, please review.
Quoted 7 lines
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in
MAINTAINERS. --->8---I personally do not really care about the 80 char warning but please remove these for the sake of peace ;) and please have a look for the reported error.
sure, I will fix that. :)
Quoted 3 lines
And the last, you should add at least one user of this feature. Isn't the lately applied at91sam9x5ek (is in u-boot-atmel/master and u-boot-arm/master) a perfect user for that?
you are right, The PMECC usage is for 9x5ek board.
I planed to push the PMECC support patches in 9x5 board in two part:
one is this series, which only include nand flash driver changes. I
thought those patches should be merged by u-boot mtd maintainer.
Another part is some patches for 9x5 board file and config file
which enable PMECC in 9x5ek board. Those patches are not sent out yet.
Now I think if you can merge all above patches to u-boot mainline, then maybe I can sent those patches together. What do you think about this?
Quoted 10 lines
Quoted 8 lines · Josh Wu
Quoted 6 lines
This patch series will add PMECC support for atmel nand driver in u-boot.
The driver patch is ported from kernel patch. The main different from kernel patch is
the modification about registers access part. in this version it via a register structure to access.A question regarding linux driver. You say it is derived from the kernel driver, but I can not see PMECC stuff in kernel:
Sorry, I am not make it clear about this. Actually, The PMECC stuff is not in v3.6-rc1 now, it is queued in kernel MTD maintainer's git tree:
http://git.infradead.org/linux-mtd.git/commit/1c7b874d33b463f7150b1ab4617f000af9b327fd
Seems the maintainer missed the merge window of v3.6-rc1. I am not sure that can go into v3.6 or not. But I think it is not a bad idea to push those code into u-boot. :)
Quoted 12 lines
---8<---
abiessmann at azuregos % git describe v3.6-rc1-355-gddf343f
abiessmann at azuregos % diff -Nrupadrivers/mtd/nand/atmel_nand.c../u-boot/drivers/mtd/nand/atmel_nand.c| diffstatatmel_nand.c | 1231 ++++++++++++++++++++++++++++++++++------------------------- 1 file changed, 720 insertions(+), 511 deletions(-)abiessmann at azuregos % grep -in pmecc
drivers/mtd/nand/atmel_nand*abiessmann at azuregos %
--->8---
Quoted 5 lines
Which driver/patch do you mean?
Quoted 1 line
Quoted 1 line
It is tested in atmel 9x5 series board.
Unfortunately I can not test this driver cause I do only have older sam926x devices around.
If I send 9x5 board enable patches with nand PMECC patches together, I think maybe other people can test it in 9x5ed board.
Quoted 5 lines
Best regards
Andreas Bie?mann
Best Regards,
Josh Wu
cover at91: atmel_nand: add PMECC(Programmable Multibit ECC controller) support
Dear Josh Wu,
Quoted 9 lines · Josh Wu
Hi, Andreas
Thank you for the quick reply.
Quoted 4 lines · Andreas Bie?mann
Dear Josh Wu,
Quoted 1 line · Josh Wu
Hi, Andreas
<snip>
Quoted 8 lines
Quoted 3 lines
And the last, you should add at least one user of this feature. Isn't the lately applied at91sam9x5ek (is in u-boot-atmel/master and u-boot-arm/master) a perfect user for that?
you are right, The PMECC usage is for 9x5ek board.
I planed to push the PMECC support patches in 9x5 board in two part:
one is this series, which only include nand flash driver changes. I
thought those patches should be merged by u-boot mtd maintainer.
I don't care whether Scott Wood or I take the patch (Scott, can you please comment?). If Scott takes it I should ack or the other way round.
Quoted 2 lines
Another part is some patches for 9x5 board file and config file which
enable PMECC in 9x5ek board. Those patches are not sent out yet.
For me it is a must to have at least one user of the added feature.
Quoted 2 lines
Now I think if you can merge all above patches to u-boot mainline, then maybe I can sent those patches together. What do you think about this?
I think there should be one patch in the series enabling the usage of the feature. Who takes this patch is another question but I favor to enable the series in a single step.
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines · Josh Wu
Quoted 7 lines
This patch series will add PMECC support for atmel nand driver in u-boot.
The driver patch is ported from kernel patch. The main different from kernel patch is
the modification about registers access part. in this version it via a register structure to access.
Quoted 6 lines
Quoted 2 lines
A question regarding linux driver. You say it is derived from the kernel driver, but I can not see PMECC stuff in kernel:
Sorry, I am not make it clear about this. Actually, The PMECC stuff is not in v3.6-rc1 now, it is queued in kernel MTD maintainer's git tree:
http://git.infradead.org/linux-mtd.git/commit/1c7b874d33b463f7150b1ab4617f000af9b327fd
Ah, I see, just found your mail on the mtd list a couple of minutes ago. I asked just to have something to compare with, I do not want to dive into the specs just to get a clue whats going on.
Quoted 3 lines
Seems the maintainer missed the merge window of v3.6-rc1. I am not sure that can go into v3.6 or not. But I think it is not a bad idea to push those code into u-boot. :)
Me too.
<snip>
Quoted 6 lines
Quoted 3 lines
Quoted 1 line
Quoted 1 line
It is tested in atmel 9x5 series board.
Unfortunately I can not test this driver cause I do only have older sam926x devices around.
If I send 9x5 board enable patches with nand PMECC patches together, I think maybe other people can test it in 9x5ed board.
Would be great to get some tested by for the patches.
Best regards
Andreas Bie?mann