Skip to contentSkip to conversation

i82378: Remove bogus MMIO coalescing

PATCH RESEND Superseded Jan Kiszka 3 participants 4 messages Aug 17, 2012

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore

Jan Kiszka

author
#0 lore raw

PATCH RESEND 1/1 i82378: Remove bogus MMIO coalescing

This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark.

---
 hw/i82378.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
hw/i82378.c +0 -1
index 9b11d90..2123c14 100644
@@ -225,7 +225,6 @@ static int pci_i82378_init(PCIDevice *dev)
     pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->io);
 
     memory_region_init_io(&s->mem, &i82378_mem_ops, s, "i82378-mem", 0x01000000);
-    memory_region_set_coalescing(&s->mem);
     pci_register_bar(dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mem);
 
     /* Make I/O address read only */
Signature · 1 line
1.7.3.4
#1 lore raw
Quoted 4 lines · Jan Kiszka

This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark.

This appears to be 1.1-stable material right?

Thanks,

/mjt

author
#2 lore raw
Quoted 8 lines · Michael Tokarev
Quoted 4 lines · Jan Kiszka

This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark.

This appears to be 1.1-stable material right?

True, adding qemu-stable.

Jan

Signature · 2 lines
Siemens AG, Corporate Technology, CT RTC ITP SDP-DE
Corporate Competence Center Embedded Linux
Acked-by on v1 1/1
#3 lore raw
In reply to Jan Kiszka

Am 17.08.2012 12:56, schrieb Jan Kiszka:

Quoted 6 lines

This MMIO area is an entry gate to legacy PC ISA devices, addressed via PIO over there. Quite a few of the PIO ports have side effects on access like starting/stopping timers that must be executed properly ordered /wrt the CPU. So we have to remove the coalescing mark.

(I would expect this to go under the SoB, documenting the chronological order...)

Quoted 1 line

I had consented to this fix and expected it to go in alongside the series this came in (kvm/uq-master?).

Anthony, do you want a prep PULL for this now? Otherwise explicitly:

Regards,
Andreas

Quoted 17 lines
---
 hw/i82378.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)
hw/i82378.c +0 -1
index 9b11d90..2123c14 100644
@@ -225,7 +225,6 @@ static int pci_i82378_init(PCIDevice *dev)
     pci_register_bar(dev, 0, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->io);
 
     memory_region_init_io(&s->mem, &i82378_mem_ops, s, "i82378-mem", 0x01000000);
-    memory_region_set_coalescing(&s->mem);
     pci_register_bar(dev, 1, PCI_BASE_ADDRESS_SPACE_MEMORY, &s->mem);
 
     /* Make I/O address read only */