arm64: dts: ls1028a: fix the offset of the reset register
Subsystems (2)
PATCH 1/1 arm64: dts: ls1028a: fix the offset of the reset register
The offset of the reset request register is 0, the absolute address is 0x1e60000. Boards without PSCI support will fail to perform a reset:
[ 26.734700] reboot: Restarting system [ 27.743259] Unable to restart system [ 27.746845] Reboot failed -- System halted
--- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1 -1
@@ -102,7 +102,7 @@ reboot { compatible ="syscon-reboot"; regmap = <&rst>; - offset = <0xb0>; + offset = <0>; mask = <0x02>; };
Signature · 1 line
2.20.1
Quoted 9 lines · Michael Walle
The offset of the reset request register is 0, the absolute address is
0x1e60000. Boards without PSCI support will fail to perform a reset:[ 26.734700] reboot: Restarting system [ 27.743259] Unable to restart system [ 27.746845] Reboot failed -- System haltedFixes 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")Signed-off-by Michael Walle <[email protected]>
Out of curiosity, how did you get it fixed with your commit 3f0fb37b22b4 ("arm64: dts: ls1028a: fix reboot node") in the first place?
Shawn
Quoted 20 lines
--- arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +1
-1@@ -102,7 +102,7 @@ reboot { compatible ="syscon-reboot"; regmap = <&rst>; - offset = <0xb0>; + offset = <0>; mask = <0x02>; };Signature · 1 line
2.20.1
Quoted 5 lines · Shawn Guo
Quoted 3 lines · Michael Walle
The offset of the reset request register is 0, the absolute address is
0x1e60000. Boards without PSCI support will fail to perform a reset:
Quoted 8 lines
Quoted 6 lines
[ 26.734700] reboot: Restarting system [ 27.743259] Unable to restart system [ 27.746845] Reboot failed -- System haltedFixes 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")Signed-off-by Michael Walle <[email protected]>Out of curiosity, how did you get it fixed with your commit
3f0fb37b22b4
How did you *not*, I meant.
Shawn
Quoted 1 line
("arm64: dts: ls1028a: fix reboot node") in the first place?
Hi Shawn,
Am 2021-01-07 07:40, schrieb Shawn Guo:
Quoted 8 lines · Michael Walle
Quoted 7 lines
The offset of the reset request register is 0, the absolute address is
0x1e60000. Boards without PSCI support will fail to perform a reset:[ 26.734700] reboot: Restarting system [ 27.743259] Unable to restart system [ 27.746845] Reboot failed -- System halted
Quoted 5 lines
Quoted 2 lines
Fixes 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")Signed-off-by Michael Walle <[email protected]>Out of curiosity, how did you get it fixed with your commit
3f0fb37b22b4("arm64: dts: ls1028a: fix reboot node") in the first place?
I simply must have missed it. There is also a fallback reset method via the watchdog in the chain, which kicks in if this wasn't successful. So if you test it, it is easy to think its working although its not.
-michael
Shawn Guo
AppliedQuoted 9 lines · Michael Walle
The offset of the reset request register is 0, the absolute address is
0x1e60000. Boards without PSCI support will fail to perform a reset:[ 26.734700] reboot: Restarting system [ 27.743259] Unable to restart system [ 27.746845] Reboot failed -- System haltedFixes 8897f3255c9c ("arm64: dts: Add support for NXP LS1028A SoC")Signed-off-by Michael Walle <[email protected]>
Applied, thanks.