Skip to contentSkip to conversation

How to add new chip ids to v4l2-chip-ident.h ?

DISCUSSION Frank Schäfer 2 participants 3 messages Aug 18, 2012 – Aug 20, 2012 Media (V4L/DVB)

lore
Share & tools
lore
#0 lore raw

Hi,

I would like to know how to add new chip ids to v4l2-chip-ident.h. Ist there a kind of policy for choosing numbers ?
Which numbers would be approriate for the em25xx/em26xx/em27xx/em28xx chips ?
Unfortunately 2700 is already used by V4L2_IDENT_VP27SMPX...

Regards,
Frank Schäfer

#1 lore raw
Quoted 4 lines · On Sat August 18 2012 16:19:26 Frank Schäfer wrote:

Hi,

I would like to know how to add new chip ids to v4l2-chip-ident.h. Ist there a kind of policy for choosing numbers ?

Using numbers that match the chip number is recommended, but if that can't be done due to clashes, then pick some other, related, number (e.g. 12700 instead of 2700) or create a range of number for all possible models of that chip series.

Quoted 3 lines

Which numbers would be approriate for the em25xx/em26xx/em27xx/em28xx chips ?
Unfortunately 2700 is already used by V4L2_IDENT_VP27SMPX...

Please note that adding an identifier to v4l2-chip-ident.h is only needed if the VIDIOC_DBG_* ioctls are implemented. If those are not implemented, then there is no need for an ID either.

Regards,

Hans

#2 lore raw

Am 18.08.2012 17:06, schrieb Hans Verkuil:

Quoted 9 lines · On Sat August 18 2012 16:19:26 Frank Schäfer wrote:
Quoted 4 lines

Hi,

I would like to know how to add new chip ids to v4l2-chip-ident.h. Ist there a kind of policy for choosing numbers ?

Using numbers that match the chip number is recommended, but if that can't be done due to clashes, then pick some other, related, number (e.g. 12700 instead of 2700) or create a range of number for all possible models of that chip series.

Ok. And I guess a comment should be added that reserves a certain range of values, if similar chips exist.

Quoted 7 lines
Quoted 4 lines

Which numbers would be approriate for the em25xx/em26xx/em27xx/em28xx chips ?
Unfortunately 2700 is already used by V4L2_IDENT_VP27SMPX...

Please note that adding an identifier to v4l2-chip-ident.h is only needed if the VIDIOC_DBG_* ioctls are implemented. If those are not implemented, then there is no need for an ID either.

Sure ;-) Thanks !

Regards,
Frank Schäfer

Quoted 4 lines

Regards,

Hans