python: firefox host-python dependency needs --enable-unicodedata
PATCH 1/1 python: firefox host-python dependency needs --enable-unicodedata
Hello all
Firefox needs host-python to be built with --enable-unicodedata. This patch enables/disables that switch depending of your target python configuration (BR2_PACKAGE_PYTHON_UNICODEDATA).
As far as I can tell, this was the last dependency that needed some handling before building firefox.
If this and those two previously sended patches
http://lists.busybox.net/pipermail/buildroot/2012-August/057378.html
and
http://lists.busybox.net/pipermail/buildroot/2012-August/057380.html
are okay with you Thomas, then Im ready to send firefox patch next.
Best regards
Stefan
PATCH 1/1 python: firefox host-python dependency needs --enable-unicodedata
--- package/python/python.mk | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-)
package/python/python.mk +7 -1
@@ -22,7 +22,6 @@ HOST_PYTHON_CONF_OPT += \ --disable-curses \ --disable-codecs-cjk \ --disable-nis \ - --disable-unicodedata \ --disable-dbm \ --disable-gdbm \ --disable-bsddb \
@@ -30,6 +29,13 @@ HOST_PYTHON_CONF_OPT += \ --disable-bz2 \ --disable-ssl +ifneq ($(BR2_PACKAGE_PYTHON_UNICODEDATA),y) + HOST_PYTHON_CONF_OPT += --disable-unicodedata +else + HOST_PYTHON_CONF_OPT += --enable-unicodedata +endif + + HOST_PYTHON_MAKE_ENV = \ PYTHON_MODULES_INCLUDE=$(HOST_DIR)/usr/include \ PYTHON_MODULES_LIB="$(HOST_DIR)/lib $(HOST_DIR)/usr/lib"
Signature · 1 line
1.7.7.6
PATCH 1/1 python: firefox host-python dependency needs --enable-unicodedata
Le Wed, 15 Aug 2012 22:00:26 +0300,
Stefan Froberg <[email protected]> a ?crit :
package/python/python.mk HOST_PYTHON_CONF_OPT += \ · line 36
Quoted 5 lines
package/python/python.mk +5
-0+ifneq ($(BR2_PACKAGE_PYTHON_UNICODEDATA),y) + HOST_PYTHON_CONF_OPT += --disable-unicodedata +else + HOST_PYTHON_CONF_OPT += --enable-unicodedata +endif
No, this is not correct. The BR2_PACKAGE_* options are here to configure the *target* packages. Host packages that are only dependencies to build target packages do not have kconfig options. So in this case, the only solution is to simply use --enable-unicodedata unconditionally to the host-python build.
Can you post an updated patch with this change?
Thanks,
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com
PATCH 1/1 python: firefox host-python dependency needs --enable-unicodedata
Hello Thomas
21.8.2012 14:23, Thomas Petazzoni kirjoitti:
Quoted 13 lines
Le Wed, 15 Aug 2012 22:00:26 +0300,
Stefan Froberg <[email protected]> a ?crit :package/python/python.mk HOST_PYTHON_CONF_OPT += \ · line 36
Quoted 5 lines
package/python/python.mk +5
-0+ifneq ($(BR2_PACKAGE_PYTHON_UNICODEDATA),y) + HOST_PYTHON_CONF_OPT += --disable-unicodedata +else + HOST_PYTHON_CONF_OPT += --enable-unicodedata +endifNo, this is not correct. The BR2_PACKAGE_* options are here to configure the *target* packages. Host packages that are only dependencies to build target packages do not have kconfig options. So in this case, the only solution is to simply use --enable-unicodedata unconditionally to the host-python build.
Oh, sorry.
I was just trying to be carefull and not to mess with host-python too much.
Quoted 2 lines
Can you post an updated patch with this change?
No problem. I will cook a new lil patch and resend.
By the way Thomas, what do you think about these two little changes to SQLite and Valgrind ?
http://lists.busybox.net/pipermail/buildroot/2012-August/057377.html
http://lists.busybox.net/pipermail/buildroot/2012-August/057379.html
I also noticed that you accepted yasm and that little cairo patch for next version.
Thank you!
Stefan
Quoted 3 lines
Thanks,
Thomas