Skip to contentSkip to conversation

coreutils: fix to build with acl support

PATCH Applied [email protected] 2 participants 3 messages Aug 21, 2012

lore
Share & tools
lore

[email protected]

author
#0 lore raw

cover coreutils: fix to build with acl support

From: Jackie Huang <[email protected]>

Fix the issue that coreutils was built without acl support:

configure: WARNING: libacl development library was not found or not usable.
configure: WARNING: GNU coreutils will be built without ACL support.

which will cause ls and cp commands don't have the ACL related behaviors:
ls -l: no plus sign(+) after the permission string for files that have ACL cp -p: can not preserves the ACLs.

[YOCTO #2959]

Signed-off-by Jackie Huang <[email protected]>

---
The following changes since commit 04568d1f18250d531aad5d286157d2d559083520:

qemu: Fix broken accidental path move (2012-08-20 17:25:21 +0100)

are available in the git repository at:
git://git.pokylinux.org/poky-contrib jhuang0/bug2959_acl_0821
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/bug2959_acl_0821

Jackie Huang (1):
coreutils: fix to build with acl support

 .../coreutils-6.9/coreutils-build-with-acl.patch   |   28 ++++++++++++++++++++
 .../coreutils-8.14/coreutils-build-with-acl.patch  |   28 ++++++++++++++++++++
 meta/recipes-core/coreutils/coreutils_6.9.bb       |    1 +
 meta/recipes-core/coreutils/coreutils_8.14.bb      |    1 +
 4 files changed, 58 insertions(+), 0 deletions(-)
 create mode 100644 meta/recipes-core/coreutils/coreutils-6.9/coreutils-build-with-acl.patch
 create mode 100644 meta/recipes-core/coreutils/coreutils-8.14/coreutils-build-with-acl.patch
Signature · 1 line
1.7.4
author
#1 lore raw

PATCH 1/1 coreutils: fix to build with acl support

From: Jackie Huang <[email protected]>

Fix the issue that coreutils was built without acl support:

configure: WARNING: libacl development library was not found or not usable.
configure: WARNING: GNU coreutils will be built without ACL support.

which will cause ls and cp commands don't have the ACL related behaviors:
ls -l: no plus sign(+) after the permission string for files that have ACL cp -p: can not preserves the ACLs.

[YOCTO #2959]

Signed-off-by Jackie Huang <[email protected]>
---
 .../coreutils-6.9/coreutils-build-with-acl.patch   |   28 ++++++++++++++++++++
 .../coreutils-8.14/coreutils-build-with-acl.patch  |   28 ++++++++++++++++++++
 meta/recipes-core/coreutils/coreutils_6.9.bb       |    1 +
 meta/recipes-core/coreutils/coreutils_8.14.bb      |    1 +
 4 files changed, 58 insertions(+), 0 deletions(-)
 create mode 100644 meta/recipes-core/coreutils/coreutils-6.9/coreutils-build-with-acl.patch
 create mode 100644 meta/recipes-core/coreutils/coreutils-8.14/coreutils-build-with-acl.patch
meta/recipes-core/coreutils/coreutils-6.9/coreutils-build-with-acl.patch new file +28 -0
new file mode 100644
index 0000000..8273d78
@@ -0,0 +1,28 @@
+Upstream-Status: Inappropriate [embedded specific]
+
+Fix the following issue so that coreutils can build with ACL:
+
+configure: WARNING: libacl development library was not found or not usable.
+configure: WARNING: GNU coreutils will be built without ACL support.
+
+Signed-off-by: Jackie Huang <[email protected]>
+---
+ m4/acl.m4 |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/m4/acl.m4 b/m4/acl.m4
+index d6a448a..a9d4836 100644
+--- a/m4/acl.m4
++++ b/m4/acl.m4
+@@ -159,7 +159,7 @@ AC_DEFUN([gl_ACL_GET_FILE],
+           ]])],
+        [gl_cv_func_working_acl_get_file=yes],
+        [gl_cv_func_working_acl_get_file=no],
+-       [gl_cv_func_working_acl_get_file=cross-compiling])])
++       [gl_cv_func_working_acl_get_file=yes])])
+ 
+   AS_IF([test $gl_cv_func_working_acl_get_file = yes], [$1], [$2])
+ ])
+-- 
+1.7.7
+
meta/recipes-core/coreutils/coreutils-8.14/coreutils-build-with-acl.patch new file +28 -0
new file mode 100644
index 0000000..8273d78
@@ -0,0 +1,28 @@
+Upstream-Status: Inappropriate [embedded specific]
+
+Fix the following issue so that coreutils can build with ACL:
+
+configure: WARNING: libacl development library was not found or not usable.
+configure: WARNING: GNU coreutils will be built without ACL support.
+
+Signed-off-by: Jackie Huang <[email protected]>
+---
+ m4/acl.m4 |    2 +-
+ 1 files changed, 1 insertions(+), 1 deletions(-)
+
+diff --git a/m4/acl.m4 b/m4/acl.m4
+index d6a448a..a9d4836 100644
+--- a/m4/acl.m4
++++ b/m4/acl.m4
+@@ -159,7 +159,7 @@ AC_DEFUN([gl_ACL_GET_FILE],
+           ]])],
+        [gl_cv_func_working_acl_get_file=yes],
+        [gl_cv_func_working_acl_get_file=no],
+-       [gl_cv_func_working_acl_get_file=cross-compiling])])
++       [gl_cv_func_working_acl_get_file=yes])])
+ 
+   AS_IF([test $gl_cv_func_working_acl_get_file = yes], [$1], [$2])
+ ])
+-- 
+1.7.7
+
meta/recipes-core/coreutils/coreutils_6.9.bb +1 -0
index 5bfab16..20d8120 100644
@@ -24,6 +24,7 @@ SRC_URI_BASE = "${GNU_MIRROR}/coreutils/${BP}.tar.bz2 \
            file://coreutils-fix-install.patch \
            file://man-touch.patch \
            file://coreutils_fix_for_automake-1.12.patch \
+           file://coreutils-build-with-acl.patch \
            "
 
 SRC_URI = "${SRC_URI_BASE} file://fix_for_manpage_building.patch"
meta/recipes-core/coreutils/coreutils_8.14.bb +1 -0
index 9a714a9..178bd67 100644
@@ -16,6 +16,7 @@ inherit autotools gettext
 SRC_URI = "${GNU_MIRROR}/coreutils/${BP}.tar.xz \
            file://remove-usr-local-lib-from-m4.patch \
            file://remove-gets.patch \
+           file://coreutils-build-with-acl.patch \
           "
 SRC_URI[md5sum] = "bcb135ce553493a45aba01b39eb3920a"
 SRC_URI[sha256sum] = "0d120817c19292edb19e92ae6b8eac9020e03d51e0af9cb116cf82b65d18b02d"
Signature · 1 line
1.7.4
Applied
#2 lore raw
In reply to [email protected]
Quoted 26 lines · On 08/21/2012 12:42 AM, [email protected] wrote:

From: Jackie Huang <[email protected]>

Fix the issue that coreutils was built without acl support:

configure: WARNING: libacl development library was not found or not usable.
configure: WARNING: GNU coreutils will be built without ACL support.

which will cause ls and cp commands don't have the ACL related behaviors:
ls -l: no plus sign(+) after the permission string for files that have ACL cp -p: can not preserves the ACLs.

[YOCTO #2959]

Signed-off-by Jackie Huang <[email protected]>

---
The following changes since commit 04568d1f18250d531aad5d286157d2d559083520:

qemu: Fix broken accidental path move (2012-08-20 17:25:21 +0100)

are available in the git repository at:

   git://git.pokylinux.org/poky-contrib jhuang0/bug2959_acl_0821
   http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=jhuang0/bug2959_acl_0821

Jackie Huang (1):
coreutils: fix to build with acl support

Quoted 8 lines
  .../coreutils-6.9/coreutils-build-with-acl.patch   |   28 ++++++++++++++++++++
  .../coreutils-8.14/coreutils-build-with-acl.patch  |   28 ++++++++++++++++++++
  meta/recipes-core/coreutils/coreutils_6.9.bb       |    1 +
  meta/recipes-core/coreutils/coreutils_8.14.bb      |    1 +
  4 files changed, 58 insertions(+), 0 deletions(-)

create mode 100644 meta/recipes-core/coreutils/coreutils-6.9/coreutils-build-with-acl.patch create mode 100644 meta/recipes-core/coreutils/coreutils-8.14/coreutils-build-with-acl.patch

Merged into OE-Core

Please remember to add PR Bumps for recipe changes.

Thanks
Sau!