Skip to contentSkip to conversation

Add U_BOOT_TIMESTAMP definition

PATCH New Matt Sealey 3 participants 6 messages Aug 23, 2012 – Apr 5, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Add U_BOOT_TIMESTAMP definition

This gives us a string like "20120822150855" which encodes the build time.

This allows automated version checking and flashing of U-Boot to be performed, for example, in boot.scr files (or scripting in general).

Cc Stefano Babic <[email protected]>
Cc Marek Vasut <[email protected]>
---
 Makefile |    1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index 1df4c1d..c042206 100644
@@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
 		@mkdir -p $(dir $(TIMESTAMP_FILE))
 		@LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > [email protected]
 		@LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> [email protected]
+		@LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> [email protected]
 		@cmp -s $@ [email protected] && rm -f [email protected] || mv -f [email protected] $@
 
 easylogo env gdb:
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 Add U_BOOT_TIMESTAMP definition

Quoted 9 lines · Matt Sealey

This gives us a string like "20120822150855" which encodes the build time.

This allows automated version checking and flashing of U-Boot to be performed, for example, in boot.scr files (or scripting in general).

Cc Stefano Babic <[email protected]>
Cc Marek Vasut <[email protected]>

---

Hi Matt,

Quoted 8 lines
 Makefile |    1 +
 1 file changed, 1 insertion(+)
Makefile +0 -0
index 1df4c1d..c042206 100644

Makefile $(TIMESTAMP_FILE): · line 669

Quoted 6 lines
Makefile +1 -0
@@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
 		@mkdir -p $(dir $(TIMESTAMP_FILE))
 		@LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > [email protected]
 		@LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> [email protected]
+		@LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> [email protected]
 		@cmp -s $@ [email protected] && rm -f [email protected] || mv -f [email protected] $@
 

This is not related to iMX only. I set CC to Wolfgang.

Best regards,
Stefano Babic

Signature · 5 lines
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
#2 lore raw

PATCH 1/1 Add U_BOOT_TIMESTAMP definition

Quoted 16 lines · Stefano Babic
Quoted 9 lines · Matt Sealey

This gives us a string like "20120822150855" which encodes the build time.

This allows automated version checking and flashing of U-Boot to be performed, for example, in boot.scr files (or scripting in general).

Cc Stefano Babic <[email protected]>
Cc Marek Vasut <[email protected]>

---

Hi Matt,

Quoted 3 lines
 Makefile |    1 +
 1 file changed, 1 insertion(+)
Quoted 13 lines

Makefile $(TIMESTAMP_FILE): · line 669

Quoted 11 lines
Makefile +1 -0
index 1df4c1d..c042206 100644
@@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
              @mkdir -p $(dir $(TIMESTAMP_FILE))
              @LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > [email protected]
              @LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> [email protected]
+             @LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> [email protected]
              @cmp -s $@ [email protected] && rm -f [email protected] || mv -f [email protected] $@
 

This is not related to iMX only. I set CC to Wolfgang.

Noted, totally my fault.

Signature · 2 lines
Matt Sealey <[email protected]>
Product Development Analyst, Genesi USA, Inc.
#3 lore raw

PATCH 1/1 Add U_BOOT_TIMESTAMP definition

In reply to Matt Sealey

Dear Matt,

Quoted 4 lines · In message <[email protected]> you wrote:

This gives us a string like "20120822150855" which encodes the build time.

This allows automated version checking and flashing of U-Boot to be performed, for example, in boot.scr files (or scripting in general).

I just noticed that this was never applied. Sorry...

Makefile $(TIMESTAMP_FILE): · line 668

Quoted 13 lines
 Makefile |    1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index 1df4c1d..c042206 100644
@@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
 		@mkdir -p $(dir $(TIMESTAMP_FILE))
 		@LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > [email protected]
 		@LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> [email protected]
+		@LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> [email protected]
 		@cmp -s $@ [email protected] && rm -f [email protected] || mv -f [email protected] $@

But then - you only add a new #define to the build environment, without any users of it, i. e. dead code.

Did you intend to post any code that would use this (in this case these patches should be merged into one, or at least into a series), or can we simply drop this patch?

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Great teachers have small audiences while they are still alive.
#4 lore raw

PATCH 1/1 Add U_BOOT_TIMESTAMP definition

Hi Wolfgang,

Quoted 9 lines · Wolfgang Denk

Dear Matt,

Quoted 4 lines · In message <[email protected]> you wrote:

This gives us a string like "20120822150855" which encodes the build time.

This allows automated version checking and flashing of U-Boot to be performed, for example, in boot.scr files (or scripting in general).

I just noticed that this was never applied. Sorry...

No problem.

Quoted 17 lines

Makefile $(TIMESTAMP_FILE): · line 668

Quoted 13 lines
 Makefile |    1 +
 1 file changed, 1 insertion(+)
Makefile +1 -0
index 1df4c1d..c042206 100644
@@ -664,6 +664,7 @@ $(TIMESTAMP_FILE):
              @mkdir -p $(dir $(TIMESTAMP_FILE))
              @LC_ALL=C date +'#define U_BOOT_DATE "%b %d %C%y"' > [email protected]
              @LC_ALL=C date +'#define U_BOOT_TIME "%T"' >> [email protected]
+             @LC_ALL=C date +'#define U_BOOT_TIMESTAMP "%Y%m%d%H%M%S"' >> [email protected]
              @cmp -s $@ [email protected] && rm -f [email protected] || mv -f [email protected] $@

But then - you only add a new #define to the build environment, without any users of it, i. e. dead code.

Quoted 3 lines

Did you intend to post any code that would use this (in this case these patches should be merged into one, or at least into a series), or can we simply drop this patch?

I did intend to submit a patch; what I wanted to do was gain some comments about it before I made
our Efika MX configuration use it, and then it moved itself to development hell.

I will submit this as a series shortly (with the configuration update) if this patch has been dropped
already, alternatively I will just submit the configuration update and remark that it requires this patch.

Is that okay?

Signature · 2 lines
Matt Sealey <[email protected]>
Product Development Analyst, Genesi USA, Inc.
#5 lore raw

PATCH 1/1 Add U_BOOT_TIMESTAMP definition

Dear Matt,

Quoted 7 lines · In message <CAKGA1bnoNJMYnj1qZUjrMZLvyrr0RT-S1y7-iYy=u2HebBwawQ@mail.gmail.com>…

I will submit this as a series shortly (with the configuration update) if this patch has been dropped
already, alternatively I will just submit the configuration update and remark that it requires this patch.

Is that okay?

Both is fine wwith me.

Best regards,

Wolfgang Denk

Signature · 7 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are three ways to get something done:
        (1) Do it yourself.
        (2) Hire someone to do it for you.
        (3) Forbid your kids to do it.