Skip to contentSkip to conversation

atmel: sam9g10: correct the text base and move into config.mk

PATCH New Bo Shen 2 participants 3 messages Aug 23, 2012 – Aug 24, 2012 Arm/Microchip (AT91) SoC support

lore
Share & tools
lore

Bo Shen

author
#0 lore raw

PATCH 1/1 atmel: sam9g10: correct the text base and move into config.mk

This patch correct the text base for at91sam9g10ek board Move the text base define to config.mk

---
 board/atmel/at91sam9261ek/config.mk |    1 +
 include/configs/at91sam9261ek.h     |    1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
 create mode 100644 board/atmel/at91sam9261ek/config.mk
board/atmel/at91sam9261ek/config.mk new file +1 -0
new file mode 100644
index 0000000..e554a45
@@ -0,0 +1 @@
+CONFIG_SYS_TEXT_BASE = 0x23f00000
include/configs/at91sam9261ek.h +0 -1
index 014437b..718ac60 100644
@@ -52,7 +52,6 @@
 #define CONFIG_DISPLAY_CPUINFO
 
 #define CONFIG_ATMEL_LEGACY
-#define CONFIG_SYS_TEXT_BASE		0x21f00000
 
 /*
  * Hardware drivers
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 atmel: sam9g10: correct the text base and move into config.mk

Dear Bo Shen,

Quoted 16 lines · Bo Shen

This patch correct the text base for at91sam9g10ek board Move the text base define to config.mk

---
 board/atmel/at91sam9261ek/config.mk |    1 +
 include/configs/at91sam9261ek.h     |    1 -
 2 files changed, 1 insertion(+), 1 deletion(-)
 create mode 100644 board/atmel/at91sam9261ek/config.mk
board/atmel/at91sam9261ek/config.mk new file +0 -0
new file mode 100644
index 0000000..e554a45

board/atmel/at91sam9261ek/config.mk line 1

Quoted 1 line
board/atmel/at91sam9261ek/config.mk new file +1 -0
@@ -0,0 +1 @@
+CONFIG_SYS_TEXT_BASE = 0x23f00000

NAK, these configuration should go into the board config header or maybe the boards.cfg.
For this board please read commit f7aea46d6ad9c257d2fbea7238cc8796aaa733f1

Another point is, the 23f00000 is (possibly) not far enough from position the start.S code will relocate the u-boot (depends on size of gd_t, bd_t, malloc arena, some special env, a.s.o). That was changed in f7aea46 by intention. Please fix at91bootstrap instead (or start integrating at91 for common SPL framework in u-boot; still on my plan for this year but I couldn't manage to start until yet).

Quoted 13 lines
include/configs/at91sam9261ek.h +0 -1
index 014437b..718ac60 100644
@@ -52,7 +52,6 @@
 #define CONFIG_DISPLAY_CPUINFO
 
 #define CONFIG_ATMEL_LEGACY
-#define CONFIG_SYS_TEXT_BASE		0x21f00000
 
 /*
  * Hardware drivers
author
#2 lore raw

PATCH 1/1 atmel: sam9g10: correct the text base and move into config.mk

Hi Andreas,

Quoted 13 lines · Andreas Bie?mann

Dear Bo Shen,

Quoted 10 lines · Bo Shen

This patch correct the text base for at91sam9g10ek board Move the text base define to config.mk

---
  board/atmel/at91sam9261ek/config.mk |    1 +
  include/configs/at91sam9261ek.h     |    1 -
  2 files changed, 1 insertion(+), 1 deletion(-)

create mode 100644 board/atmel/at91sam9261ek/config.mk

Quoted 12 lines

board/atmel/at91sam9261ek/config.mk line 1

Quoted 7 lines
board/atmel/at91sam9261ek/config.mk new file +1 -0
new file mode 100644
index 0000000..e554a45
@@ -0,0 +1 @@
+CONFIG_SYS_TEXT_BASE = 0x23f00000

NAK, these configuration should go into the board config header or maybe the boards.cfg.
For this board please read commit f7aea46d6ad9c257d2fbea7238cc8796aaa733f1

Thanks for your information.
I will keep it and fix the bootstrap.

BRs,
Bo Shen

Quoted 21 lines

Another point is, the 23f00000 is (possibly) not far enough from position the start.S code will relocate the u-boot (depends on size of gd_t, bd_t, malloc arena, some special env, a.s.o). That was changed in f7aea46 by intention. Please fix at91bootstrap instead (or start integrating at91 for common SPL framework in u-boot; still on my plan for this year but I couldn't manage to start until yet).

Quoted 13 lines
include/configs/at91sam9261ek.h +0 -1
index 014437b..718ac60 100644
@@ -52,7 +52,6 @@
  #define CONFIG_DISPLAY_CPUINFO
 
  #define CONFIG_ATMEL_LEGACY
-#define CONFIG_SYS_TEXT_BASE		0x21f00000
 
  /*
   * Hardware drivers