Skip to contentSkip to conversation

ARM: LPC32XX SLC ECC Handling

DISCUSSION Sebastian Huber 4 participants 6 messages Aug 8, 2012 – Sep 15, 2012 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

Hi,

the LPC32XX SLC controller has a ECC feature that covers only the main data area, but not the OOB data. Is it the responsibility of the user to protect its OOB data via an ECC? The LPC32XX MLC controller on the other hand covers the complete OOB data with its ECC. How can a user determine if it has to protect its OOB data?

Signature · 9 lines
Sebastian Huber, embedded brains GmbH

Address : Obere Lagerstr. 30, D-82178 Puchheim, Germany
Phone   : +49 89 18 90 80 79-6
Fax     : +49 89 18 90 80 79-9
E-Mail  : [email protected]
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
#1 lore raw
Quoted 7 lines · Sebastian Huber

Hi,

the LPC32XX SLC controller has a ECC feature that covers only the main data area, but not the OOB data. Is it the responsibility of the user to protect its OOB data via an ECC? The LPC32XX MLC controller on the other hand covers the complete OOB data with its ECC. How can a user determine if it has to protect its OOB data?

I guess it is good idea to CC the author of the drivers.

Signature · 2 lines
Best Regards,
Artem Bityutskiy
#2 lore raw

Hi!

Quoted 8 lines · Artem Bityutskiy
Quoted 6 lines

the LPC32XX SLC controller has a ECC feature that covers only the main data area, but not the OOB data. Is it the responsibility of the user to protect its OOB data via an ECC? The LPC32XX MLC controller on the other hand covers the complete OOB data with its ECC. How can a user determine if it has to protect its OOB data?

I guess it is good idea to CC the author of the drivers.

Thanks for CC'ing, would have missed it.

Yes, it's exactly as Sebastian described - only the MLC controller covers OOB in ECC.

At this point, I need to give back the question to the MTD
maintainers: Is there an API how we can help users at this point? I would be happy to implement it.

Thanks,

Roland

#3 lore raw
Quoted 12 lines · Roland Stigge

Hi!

Quoted 8 lines · Artem Bityutskiy
Quoted 6 lines

the LPC32XX SLC controller has a ECC feature that covers only the main data area, but not the OOB data. Is it the responsibility of the user to protect its OOB data via an ECC? The LPC32XX MLC controller on the other hand covers the complete OOB data with its ECC. How can a user determine if it has to protect its OOB data?

I guess it is good idea to CC the author of the drivers.

Quoted 8 lines

Thanks for CC'ing, would have missed it.

Yes, it's exactly as Sebastian described - only the MLC controller covers OOB in ECC.

At this point, I need to give back the question to the MTD
maintainers: Is there an API how we can help users at this point? I would be happy to implement it.

Well, I guess from the user's POW the driver either protects OOB data with ECC or not. There is no interface for detecting this in MTD, but I do not see why someone could not create it.

Am I right that we are talking about the situation when OOB and data areas are covered by different ECCs, or this is about user writing data +oob at one go, and everything is covered by the same ECC?

Signature · 2 lines
Best Regards,
Artem Bityutskiy
#4 lore raw
Quoted 18 lines · Artem Bityutskiy
Quoted 9 lines
Quoted 8 lines
Quoted 6 lines

the LPC32XX SLC controller has a ECC feature that covers only the main data area, but not the OOB data. Is it the responsibility of the user to protect its OOB data via an ECC? The LPC32XX MLC controller on the other hand covers the complete OOB data with its ECC. How can a user determine if it has to protect its OOB data?

I guess it is good idea to CC the author of the drivers.

Quoted 8 lines

Thanks for CC'ing, would have missed it.

Yes, it's exactly as Sebastian described - only the MLC controller covers OOB in ECC.

At this point, I need to give back the question to the MTD
maintainers: Is there an API how we can help users at this point? I would be happy to implement it.

Quoted 8 lines

Well, I guess from the user's POW the driver either protects OOB data with ECC or not. There is no interface for detecting this in MTD, but I do not see why someone could not create it.

Am I right that we are talking about the situation when OOB and data areas are covered by different ECCs, or this is about user writing data +oob at one go, and everything is covered by the same ECC?

In the above case of LPC32xx/MLC NAND (not sure if this is common with other controllers), the controller covers 512 (sub)pages plus some OOB bytes with a single ECC operation, storing it behind those covered OOB.

Roland

#5 lore raw

Hi,

Quoted 7 lines · Roland Stigge
Quoted 6 lines · Artem Bityutskiy
Quoted 6 lines
Quoted 6 lines
Quoted 6 lines

the LPC32XX SLC controller has a ECC feature that covers only the main data area, but not the OOB data. Is it the responsibility of the user to protect its OOB data via an ECC? The LPC32XX MLC controller on the other hand covers the complete OOB data with its ECC. How can a user determine if it has to protect its OOB data?

I haven't dealt with this question, since I basically don't support user data in OOB on my system. I'm basically using only UBI. But see my other comments below.

Quoted 15 lines
Quoted 15 lines
Quoted 10 lines
Quoted 1 line

I guess it is good idea to CC the author of the drivers.

Thanks for CC'ing, would have missed it.

Yes, it's exactly as Sebastian described - only the MLC controller covers OOB in ECC.

At this point, I need to give back the question to the MTD
maintainers: Is there an API how we can help users at this point? I would be happy to implement it.

Well, I guess from the user's POW the driver either protects OOB data with ECC or not. There is no interface for detecting this in MTD, but I do not see why someone could not create it.

Quoted 7 lines
Quoted 4 lines

Am I right that we are talking about the situation when OOB and data areas are covered by different ECCs, or this is about user writing data +oob at one go, and everything is covered by the same ECC?

In the above case of LPC32xx/MLC NAND (not sure if this is common with other controllers),

By my experience in interacting with the community, few controllers have support for protecting OOB with ECC, and even fewer drivers actual implement it. I think my (out-of-tree) driver was the only one that could ever reported bitflips for OOB transactions. And for instance, I added the read_oob/read_oob_raw and write_oob/write_oob_raw clarification in nand_ecc_ctrl, but there are no in-tree users that differentiate the two...

Quoted 2 lines

the controller covers 512 (sub)pages plus some OOB
bytes with a single ECC operation, storing it behind those covered OOB.

My controller is basically the same.

Brian