Skip to contentSkip to conversation

NAND Flash SMC timings update (nwe_pulse) for calao board based on AT91SAM9G20 SoC

PATCH In review gregory hermant 2 participants 4 messages Aug 28, 2012 – Aug 31, 2012 Arm (32-bit)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NAND Flash SMC timings update (nwe_pulse) for calao board based on AT91SAM9G20 SoC

---
 arch/arm/boards/tny-a926x/init.c |    2 +-
 arch/arm/boards/usb-a926x/init.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boards/tny-a926x/init.c +1 -1
index d58132a..5538a44 100644
@@ -89,7 +89,7 @@ static struct sam9_smc_config tny_a9g20_nand_smc_config = {
 	.ncs_read_pulse		= 4,
 	.nrd_pulse		= 4,
 	.ncs_write_pulse	= 4,
-	.nwe_pulse		= 2,
+	.nwe_pulse		= 4,
 
 	.read_cycle		= 7,
 	.write_cycle		= 7,
arch/arm/boards/usb-a926x/init.c +1 -1
index 7e63876..00a215d 100644
@@ -90,7 +90,7 @@ static struct sam9_smc_config usb_a9g20_nand_smc_config = {
 	.ncs_read_pulse		= 4,
 	.nrd_pulse		= 4,
 	.ncs_write_pulse	= 4,
-	.nwe_pulse		= 2,
+	.nwe_pulse		= 4,
 
 	.read_cycle		= 7,
 	.write_cycle		= 7,
Signature · 8 lines
1.5.6.3



_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#1 lore raw
Quoted 1 line · gregory hermant

The commmit log is a bit sparse. It would be interesting if this is an enhancement, fixes a problem, is needed on newer board revisions...

Sascha

Quoted 41 lines
---
 arch/arm/boards/tny-a926x/init.c |    2 +-
 arch/arm/boards/usb-a926x/init.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boards/tny-a926x/init.c +1 -1
index d58132a..5538a44 100644
@@ -89,7 +89,7 @@ static struct sam9_smc_config tny_a9g20_nand_smc_config = {
 	.ncs_read_pulse		= 4,
 	.nrd_pulse		= 4,
 	.ncs_write_pulse	= 4,
-	.nwe_pulse		= 2,
+	.nwe_pulse		= 4,
 
 	.read_cycle		= 7,
 	.write_cycle		= 7,
arch/arm/boards/usb-a926x/init.c +1 -1
index 7e63876..00a215d 100644
@@ -90,7 +90,7 @@ static struct sam9_smc_config usb_a9g20_nand_smc_config = {
 	.ncs_read_pulse		= 4,
 	.nrd_pulse		= 4,
 	.ncs_write_pulse	= 4,
-	.nwe_pulse		= 2,
+	.nwe_pulse		= 4,
 
 	.read_cycle		= 7,
 	.write_cycle		= 7,
Signature · 8 lines
1.5.6.3



_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
#2 lore raw

Hello sascha,
It's just a typo.
gregory

Quoted 44 lines · Sascha Hauer
Quoted 1 line · gregory hermant

The commmit log is a bit sparse. It would be interesting if this is an enhancement, fixes a problem, is needed on newer board revisions...

Sascha

Quoted 36 lines
---
 arch/arm/boards/tny-a926x/init.c |    2 +-
 arch/arm/boards/usb-a926x/init.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boards/tny-a926x/init.c +1 -1
index d58132a..5538a44 100644
@@ -89,7 +89,7 @@ static struct sam9_smc_config tny_a9g20_nand_smc_config = {
 	.ncs_read_pulse		= 4,
 	.nrd_pulse		= 4,
 	.ncs_write_pulse	= 4,
-	.nwe_pulse		= 2,
+	.nwe_pulse		= 4,
 
 	.read_cycle		= 7,
 	.write_cycle		= 7,
arch/arm/boards/usb-a926x/init.c +1 -1
index 7e63876..00a215d 100644
@@ -90,7 +90,7 @@ static struct sam9_smc_config usb_a9g20_nand_smc_config = {
 	.ncs_read_pulse		= 4,
 	.nrd_pulse		= 4,
 	.ncs_write_pulse	= 4,
-	.nwe_pulse		= 2,
+	.nwe_pulse		= 4,
 
 	.read_cycle		= 7,
 	.write_cycle		= 7,
Signature · 1 line
1.5.6.3
Quoted 6 lines
Quoted 5 lines

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox

#3 lore raw
Quoted 3 lines · gregory hermant

Hello sascha,
It's just a typo.
gregory

Applied now, thanks

Sascha

Quoted 53 lines
Quoted 50 lines · Sascha Hauer
Quoted 1 line · gregory hermant

The commmit log is a bit sparse. It would be interesting if this is an enhancement, fixes a problem, is needed on newer board revisions...

Sascha

Quoted 41 lines
---
 arch/arm/boards/tny-a926x/init.c |    2 +-
 arch/arm/boards/usb-a926x/init.c |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
arch/arm/boards/tny-a926x/init.c +1 -1
index d58132a..5538a44 100644
@@ -89,7 +89,7 @@ static struct sam9_smc_config tny_a9g20_nand_smc_config = {
 	.ncs_read_pulse		= 4,
 	.nrd_pulse		= 4,
 	.ncs_write_pulse	= 4,
-	.nwe_pulse		= 2,
+	.nwe_pulse		= 4,
 
 	.read_cycle		= 7,
 	.write_cycle		= 7,
arch/arm/boards/usb-a926x/init.c +1 -1
index 7e63876..00a215d 100644
@@ -90,7 +90,7 @@ static struct sam9_smc_config usb_a9g20_nand_smc_config = {
 	.ncs_read_pulse		= 4,
 	.nrd_pulse		= 4,
 	.ncs_write_pulse	= 4,
-	.nwe_pulse		= 2,
+	.nwe_pulse		= 4,
 
 	.read_cycle		= 7,
 	.write_cycle		= 7,
Signature · 8 lines
1.5.6.3



_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox
Signature · 9 lines
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

_______________________________________________
barebox mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/barebox