patman doesn't send patches

U-Boot Stefan Roese 3 participants 3 messages Aug 29, 2012 – Aug 30, 2012 2 messages not in the archive

Share & tools

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): CAPnjgZ1G5UfMHGEr-JBFaqVg1=+D05Cm2_mPBcJNNYHDMfPk5Q@mail.gmail.com

Stefan Roese

author

2012-08-29 05:51 UTC #2 lore raw

Hi Simon,

(added list this time)

Quoted 10 lines · Simon Glass

Best to send to list and cc me.
If you see this:
Quoted 1 line
git send-email
git: 'send-email' is not a git command. See 'git --help'.
try:
sudo apt-get install git-email

I don't see any errors. And git send-email is working just fine for me. I'm using it regularly.

Any other idea what might go wrong? Again, the generated patches in the root directory look fine. But nothing is sent.

Thanks,
Stefan

Quoted 44 lines

Regards,
Simon
Quoted 39 lines · Stefan Roese
Hi Simon,
finally I started using patman for the first time. The main problem I'm facing right now is, that the patches are not sent at all to the destination (Series-to: ...). I see no message/error/etc at the prompt, that patman even tried to send the patches. Should there be anything like this?
Here the output of my current command:
[stefan at ubuntu-2012 u-boot-tom-rini (a3m071-spl-v4b)]$ ./tools/patman/patman -c12
Cleaned 12 patches
0 errors, 1 warnings for 0001-SPL-Fix-build-problems-on-ARM-with-new-SPL-framework.patch:
warning: arch/arm/lib/spl.c,36: externs should be avoided in .c files 0 errors, 1 warnings for 0004-SPL-Add-NOR-flash-booting-support.patch:
Internal error: some problems lost
warning: common/spl/spl_nor.c,26: externs should be avoided in .c files
0 errors, 2 warnings for 0008-mpc5200-Add-SPL-support.patch:
Internal error: some problems lost
warning: arch/powerpc/cpu/mpc5xxx/spl_boot.c,23: externs should be avoided in .c files
warning: arch/powerpc/cpu/mpc5xxx/spl_boot.c,28: externs should be avoided in .c files
0 errors, 2 warnings for 0009-mpc5200-Add-a3m071-board-support.patch:
Internal error: some problems lost
warning: include/configs/a3m071.h,334: line over 80 characters
warning: include/configs/a3m071.h,341: line over 80 characters checkpatch.pl found 0 error(s), 6 warning(s)
Or does patman not even try to send, once checkpatch warning/errors are detected?
Any hints really appreciated.
Thanks,
Stefan

Ilya Yanok

2012-08-30 04:23 UTC #3 lore raw

Hi Stefan,

Quoted 2 lines · Stefan Roese <sr <at> denx.de> writes:

Quoted 2 lines
Quoted 2 lines
Or does patman not even try to send, once checkpatch warning/errors are detected?

That's it. Normally you don't want to send patches that are not chackpatch-clean. If you are sure that problems are irrelevant use -i switch to ignore them.

Regards, Ilya.

Simon Glass

2012-08-30 19:40 UTC #4 lore raw

Quoted 11 lines · Ilya Yanok

Hi Stefan,
Quoted 2 lines · Stefan Roese <sr <at> denx.de> writes:
Quoted 2 lines
Quoted 2 lines
Or does patman not even try to send, once checkpatch warning/errors are detected?
That's it. Normally you don't want to send patches that are not chackpatch-clean. If you are sure that problems are irrelevant use -i switch to ignore them.
Regards, Ilya.

Thanks Ilya - yes that's the idea. - Simon

Quoted 6 lines

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot