Skip to contentSkip to conversation

: cpucontrol module updates (allow CPU microcode update utility as standalone application)

PATCH New Guido Trentalancia 2 participants 3 messages Aug 24, 2012 – Aug 29, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 : cpucontrol module updates (allow CPU microcode update utility as standalone application)

cpucontrol module modification to also allow execution as a standalone application rather than just as an init script or from run_init (mutually exclusive tunable policy won't work easily due to the presence of typeattributes within the init interfaces).

---
  policy/modules/contrib/cpucontrol.te |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff -pru refpolicy-08082012-a/policy/modules/contrib/cpucontrol.te refpolicy-08082012-b/policy/modules/contrib/cpucontrol.te
--- refpolicy-08082012-a/policy/modules/contrib/cpucontrol.te 2012-08-09
02:50:45.253581021 +0200
+++ refpolicy-08082012-b/policy/modules/contrib/cpucontrol.te 2012-08-09
02:49:56.525140236 +0200
@@ -15,7 +15,7 @@ gen_tunable(cpucontrol_can_upload_cpu_mi

type cpucontrol_t;
type cpucontrol_exec_t;
-init_system_domain(cpucontrol_t, cpucontrol_exec_t) +init_daemon_domain(cpucontrol_t, cpucontrol_exec_t)

type cpucontrol_initrc_exec_t;
init_script_file(cpucontrol_initrc_exec_t)

#1 lore raw

PATCH 2/2 : cpucontrol module updates (allow CPU microcode update utility as standalone application)

Quoted 18 lines · Guido Trentalancia

cpucontrol module modification to also allow execution as a standalone application rather than just as an init script or from run_init (mutually exclusive tunable policy won't work easily due to the presence of typeattributes within the init interfaces).

---
  policy/modules/contrib/cpucontrol.te |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff -pru refpolicy-08082012-a/policy/modules/contrib/cpucontrol.te refpolicy-08082012-b/policy/modules/contrib/cpucontrol.te
--- refpolicy-08082012-a/policy/modules/contrib/cpucontrol.te 2012-08-09
02:50:45.253581021 +0200
+++ refpolicy-08082012-b/policy/modules/contrib/cpucontrol.te 2012-08-09
02:49:56.525140236 +0200

Review gen_tunable(cpucontrol_can_upload_cpu_mi · line 18

Quoted 5 lines
(quoted diff) +1 -1
@@ -15,7 +15,7 @@ gen_tunable(cpucontrol_can_upload_cpu_mi
 
  type cpucontrol_t;
  type cpucontrol_exec_t;
-init_system_domain(cpucontrol_t, cpucontrol_exec_t)
+init_daemon_domain(cpucontrol_t, cpucontrol_exec_t)

I don't understand why this is necessary. From your description, init_system_domain() is appropriate, since its for short running programs started by initrc_t.

Signature · 3 lines
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com
#2 lore raw

PATCH 2/2 : cpucontrol module updates (allow CPU microcode update utility as standalone application)

Quoted 20 lines · Christopher J. PeBenito
Quoted 19 lines · Guido Trentalancia

cpucontrol module modification to also allow execution as a standalone application rather than just as an init script or from run_init (mutually exclusive tunable policy won't work easily due to the presence of typeattributes within the init interfaces).

---
   policy/modules/contrib/cpucontrol.te |    2 +-
   1 file changed, 1 insertion(+), 1 deletion(-)

diff -pru refpolicy-08082012-a/policy/modules/contrib/cpucontrol.te refpolicy-08082012-b/policy/modules/contrib/cpucontrol.te
--- refpolicy-08082012-a/policy/modules/contrib/cpucontrol.te 2012-08-09
02:50:45.253581021 +0200
+++ refpolicy-08082012-b/policy/modules/contrib/cpucontrol.te 2012-08-09
02:49:56.525140236 +0200

(quoted diff) +0 -0
@@ -15,7 +15,7 @@ gen_tunable(cpucontrol_can_upload_cpu_mi
 
Quoted 6 lines

Review gen_tunable(cpucontrol_can_upload_cpu_mi · line 18

Quoted 4 lines
(quoted diff) +1 -1
   type cpucontrol_t;
   type cpucontrol_exec_t;
-init_system_domain(cpucontrol_t, cpucontrol_exec_t)
+init_daemon_domain(cpucontrol_t, cpucontrol_exec_t)

I don't understand why this is necessary. From your description, init_system_domain() is appropriate, since its for short running programs started by initrc_t.

You are actually right. This is not necessary.

It is not supposed to be executed as a standalone application. If it needs to be executed anytime after system-startup, it shall still be executed through run_init.

Thanks for pointing it out.

Best regards,

Guido