Skip to contentSkip to conversation

ARM: tegra_defconfig: enable APB DMA support

PATCH New Uwe Kleine-König 3 participants 4 messages Aug 29, 2012

Subsystems (2)
Arm (32-bit) Tegra architecture support
lore
Share & tools
lore

Uwe Kleine-König

author
#0 lore raw

PATCH 1/1 ARM: tegra_defconfig: enable APB DMA support

Additionally DMADEVICES needs to be enabled as TEGRA20_APB_DMA depends on that.

Signed-off-by Uwe Kleine-K?nig <[email protected]>
---
 arch/arm/configs/tegra_defconfig |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/tegra_defconfig +2 -0
index db22453..0d6bb73 100644
@@ -145,6 +145,8 @@ CONFIG_MMC_SDHCI_TEGRA=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_EM3027=y
 CONFIG_RTC_DRV_TEGRA=y
+CONFIG_DMADEVICES=y
+CONFIG_TEGRA20_APB_DMA=y
 CONFIG_STAGING=y
 CONFIG_SENSORS_ISL29018=y
 CONFIG_SENSORS_ISL29028=y
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 ARM: tegra_defconfig: enable APB DMA support

Quoted 13 lines · Uwe Kleine-K?nig

Additionally DMADEVICES needs to be enabled as TEGRA20_APB_DMA depends on that.

Signed-off-by Uwe Kleine-K?nig<[email protected]>
---
  arch/arm/configs/tegra_defconfig |    2 ++
  1 file changed, 2 insertions(+)
arch/arm/configs/tegra_defconfig +0 -0
index db22453..0d6bb73 100644

arch/arm/configs/tegra_defconfig CONFIG_MMC_SDHCI_TEGRA=y · line 152

Quoted 8 lines
arch/arm/configs/tegra_defconfig +2 -0
@@ -145,6 +145,8 @@ CONFIG_MMC_SDHCI_TEGRA=y
  CONFIG_RTC_CLASS=y
  CONFIG_RTC_DRV_EM3027=y
  CONFIG_RTC_DRV_TEGRA=y
+CONFIG_DMADEVICES=y
+CONFIG_TEGRA20_APB_DMA=y
  CONFIG_STAGING=y
  CONFIG_SENSORS_ISL29018=y
  CONFIG_SENSORS_ISL29028=y

Hi Uwe,
Tegra team is working on to enable the new dma drivr which is dmaengine based. We have dma legacy driver as of now in mach-tegra. Some of the tests are failing with new dmadriver and so we are not able to enable it. The patch series which is posted against this is:

[PATCH 0/5] ARM: tegra: move all APB DMA client to dmaengine based driver

Thanks,
Laxman

author
#2 lore raw

PATCH 1/1 ARM: tegra_defconfig: enable APB DMA support

Quoted 20 lines · Laxman Dewangan
Quoted 19 lines · Uwe Kleine-K?nig

Additionally DMADEVICES needs to be enabled as TEGRA20_APB_DMA depends on that.

Signed-off-by Uwe Kleine-K?nig<[email protected]>
---
 arch/arm/configs/tegra_defconfig |    2 ++
 1 file changed, 2 insertions(+)
arch/arm/configs/tegra_defconfig +2 -0
index db22453..0d6bb73 100644
@@ -145,6 +145,8 @@ CONFIG_MMC_SDHCI_TEGRA=y
 CONFIG_RTC_CLASS=y
 CONFIG_RTC_DRV_EM3027=y
 CONFIG_RTC_DRV_TEGRA=y
+CONFIG_DMADEVICES=y
+CONFIG_TEGRA20_APB_DMA=y
 CONFIG_STAGING=y
Quoted 8 lines

arch/arm/configs/tegra_defconfig CONFIG_MMC_SDHCI_TEGRA=y · line 152

Quoted 2 lines
arch/arm/configs/tegra_defconfig +0 -0
 CONFIG_SENSORS_ISL29018=y
 CONFIG_SENSORS_ISL29028=y

Hi Uwe,
Tegra team is working on to enable the new dma drivr which is dmaengine based. We have dma legacy driver as of now in mach-tegra. Some of the tests are failing with new dmadriver and so we are not able to enable it.

So it depends on what you wanna do with the defconfig. There are two purposes for them:

a) compile coverage
b) starting point for machine support

So it all depends on what you consider to be more important.

Best regards
Uwe

Signature · 2 lines
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
#3 lore raw

PATCH 1/1 ARM: tegra_defconfig: enable APB DMA support

Quoted 29 lines · Uwe Kleine-K?nig
Quoted 20 lines · Laxman Dewangan
Quoted 19 lines · Uwe Kleine-K?nig

Additionally DMADEVICES needs to be enabled as TEGRA20_APB_DMA depends on that.

Signed-off-by Uwe Kleine-K?nig<[email protected]>
---
  arch/arm/configs/tegra_defconfig |    2 ++
  1 file changed, 2 insertions(+)
arch/arm/configs/tegra_defconfig +2 -0
index db22453..0d6bb73 100644
@@ -145,6 +145,8 @@ CONFIG_MMC_SDHCI_TEGRA=y
  CONFIG_RTC_CLASS=y
  CONFIG_RTC_DRV_EM3027=y
  CONFIG_RTC_DRV_TEGRA=y
+CONFIG_DMADEVICES=y
+CONFIG_TEGRA20_APB_DMA=y
  CONFIG_STAGING=y
Quoted 8 lines

arch/arm/configs/tegra_defconfig CONFIG_MMC_SDHCI_TEGRA=y · line 152

Quoted 2 lines
arch/arm/configs/tegra_defconfig +0 -0
  CONFIG_SENSORS_ISL29018=y
  CONFIG_SENSORS_ISL29028=y

Hi Uwe,
Tegra team is working on to enable the new dma drivr which is dmaengine based. We have dma legacy driver as of now in mach-tegra. Some of the tests are failing with new dmadriver and so we are not able to enable it.

Quoted 7 lines

So it depends on what you wanna do with the defconfig. There are two purposes for them:

a) compile coverage
b) starting point for machine support

So it all depends on what you consider to be more important.

I'd prefer tegra_defconfig to produce a useful working system. I believe that enabling both DMA drivers at the same time will cause conflicts. Hopefully the switch to the new DMA driver is coming very soon, and this patch (or equivalent) will be part of that.