Skip to contentSkip to conversation

hpfs: drop lock/unlock super

PATCH In review Marco Stornelli 2 participants 2 messages Aug 30, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 5/8 hpfs: drop lock/unlock super

Removed lock/unlock super.

---
 fs/hpfs/super.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
fs/hpfs/super.c +0 -3
index 706a12c..8af2cdc 100644
@@ -389,7 +389,6 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)
 	*flags |= MS_NOATIME;
 	
 	hpfs_lock(s);
-	lock_super(s);
 	uid = sbi->sb_uid; gid = sbi->sb_gid;
 	umask = 0777 & ~sbi->sb_mode;
 	lowercase = sbi->sb_lowercase;
@@ -422,12 +421,10 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)
 
 	replace_mount_options(s, new_opts);
 
-	unlock_super(s);
 	hpfs_unlock(s);
 	return 0;
 
 out_err:
-	unlock_super(s);
 	hpfs_unlock(s);
 	kfree(new_opts);
 	return -EINVAL;
Signature · 1 line
1.7.3.4
maintainer
#1 lore raw

It looks ok.

Mikulas

Quoted 35 lines · Marco Stornelli

Removed lock/unlock super.

---
 fs/hpfs/super.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)
fs/hpfs/super.c +0 -3
index 706a12c..8af2cdc 100644
@@ -389,7 +389,6 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)
 	*flags |= MS_NOATIME;
 
 	hpfs_lock(s);
-	lock_super(s);
 	uid = sbi->sb_uid; gid = sbi->sb_gid;
 	umask = 0777 & ~sbi->sb_mode;
 	lowercase = sbi->sb_lowercase;
@@ -422,12 +421,10 @@ static int hpfs_remount_fs(struct super_block *s, int *flags, char *data)
 
 	replace_mount_options(s, new_opts);
 
-	unlock_super(s);
 	hpfs_unlock(s);
 	return 0;
 
 out_err:
-	unlock_super(s);
 	hpfs_unlock(s);
 	kfree(new_opts);
 	return -EINVAL;
Signature · 1 line
1.7.3.4