Skip to contentSkip to conversation

drivers/devfreq/devfreq.c:75:5: sparse: symbol 'devfreq_get_freq_leve

PATCH In review Fengguang Wu 2 participants 2 messages Aug 31, 2012

Subsystems (2)
Kernel janitors Device frequency (devfreq)
lore
Share & tools
lore

Fengguang Wu

author
#0 lore raw

PATCH 3/5 drivers/devfreq/devfreq.c:75:5: sparse: symbol 'devfreq_get_freq_leve

Hi Jonghwa,

FYI, there are new sparse warnings show up in

tree:   git://git.infradead.org/users/kmpark/linux-samsung devfreq-for-next
head:   90609cd121f47446e6a04862214423dbc75bd493
commit: 4b77f78761889635ba1abd2f4ec1e7f45012e48c [3/5] devfreq: Add sysfs node for representing frequency transition information.

All sparse warnings:

+ drivers/devfreq/devfreq.c:75:5: sparse: symbol 'devfreq_get_freq_level' was not declared. Should it be static?
+ drivers/devfreq/devfreq.c:86:5: sparse: symbol 'devfreq_update_status' was not declared. Should it be static?

vim +75 drivers/devfreq/devfreq.c

    72		return ERR_PTR(-ENODEV);
    73	}
    74
Quoted 1 line

75 int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq)

    76	{
    77		int lev;
    78

Please consider folding the attached diff :-)

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

drivers/devfreq/devfreq.c +2 -2
index 00e326c..e00a386 100644
@@ -72,7 +72,7 @@ static struct devfreq *find_device_devfreq(struct device *dev)
 	return ERR_PTR(-ENODEV);
 }
 
-int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq)
+static int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq)
 {
 	int lev;
 

@@ -83,7 +83,7 @@ int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq)
 	return -EINVAL;
 }
 
-int devfreq_update_status(struct devfreq *devfreq, unsigned long freq)
+static int devfreq_update_status(struct devfreq *devfreq, unsigned long freq)
 {
 	int lev, prev_lev;
 	unsigned long cur_time;
#1 lore raw

Re: [samsung:devfreq-for-next 3/5] drivers/devfreq/devfreq.c:75:5: sparse: symbol 'devfreq_get_freq_

Quoted 17 lines · Fengguang Wu

Hi Jonghwa,

FYI, there are new sparse warnings show up in

tree:   git://git.infradead.org/users/kmpark/linux-samsung devfreq-for-next
head:   90609cd121f47446e6a04862214423dbc75bd493
commit: 4b77f78761889635ba1abd2f4ec1e7f45012e48c [3/5] devfreq: Add sysfs node for representing frequency transition information.

All sparse warnings:

+ drivers/devfreq/devfreq.c:75:5: sparse: symbol 'devfreq_get_freq_level' was not declared. Should it be static?
+ drivers/devfreq/devfreq.c:86:5: sparse: symbol 'devfreq_update_status' was not declared. Should it be static?

vim +75 drivers/devfreq/devfreq.c

    72		return ERR_PTR(-ENODEV);
    73	}
    74
Quoted 7 lines
Quoted 1 line

75 int devfreq_get_freq_level(struct devfreq *devfreq, unsigned long freq)

    76	{
    77		int lev;
    78

Please consider folding the attached diff :-)

Okay, I'll updated it.

Quoted 3 lines

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation