Skip to contentSkip to conversation

ALSA: snd-usb: Regression fixes for 3.5

PATCH ☈king 2 participants 4 messages Aug 31, 2012 – Sep 1, 2012 1 message not in the archive

lore
Share & tools
lore

☈king

author
#0 lore raw

I am having the following symptoms, before and after application of this thread's patches:

Given:
- An onboard card
- A Logitech h390 USB headset
- alsa-info of: http://www.alsa-project.org/db/?f=942b5e96b53a667270f895ec5061ca14af0339ee

When:
- I do: aplay $(locate .wav | grep Front)
it outputs:
alsa ALSA lib pcm_direct.c:980:(snd1_pcm_direct_initialize_slave)
unable to install hw params
ALSA lib pcm_dmix.c:1030:(snd_pcm_dmix_open) unable to initialize slave
aplay: main:682: audio open error: Broken pipe
- I do a Skype "Make a test sound"
/var/log/messages streams dozens of these:
kernel: cannot submit urb 0, error -28: not enough bandwidth

Note that this is a new laptop and headset, so I haven't compared how either works on other setups, such as with other kernels or alsa versions.

Any hints? Any further info needed?

Thanks!
—☈

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#1 lore raw
Quoted 19 lines · ☈king

I am having the following symptoms, before and after application of this thread's patches:

Given:
- An onboard card
- A Logitech h390 USB headset
- alsa-info of: http://www.alsa-project.org/db/?f=942b5e96b53a667270f895ec5061ca14af0339ee

When:
- I do: aplay $(locate .wav | grep Front)
it outputs:
alsa ALSA lib pcm_direct.c:980:(snd1_pcm_direct_initialize_slave)
unable to install hw params
ALSA lib pcm_dmix.c:1030:(snd_pcm_dmix_open) unable to initialize slave
aplay: main:682: audio open error: Broken pipe
- I do a Skype "Make a test sound"
/var/log/messages streams dozens of these:
kernel: cannot submit urb 0, error -28: not enough bandwidth

Quoted 4 lines

Note that this is a new laptop and headset, so I haven't compared how either works on other setups, such as with other kernels or alsa versions.

Any hints? Any further info needed?

What kernel do you work on? Did you try the other patch that I sent some days ago and that already went mainline?

https://git.kernel.org/?p=linux/kernel/git/tiwai/sound.git;a=commit;h=015618b902ae8e28705b7af9b4668615fea48ddd

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw

(please don't drop mailing lists from Cc:)

Quoted 32 lines · ☈king
Quoted 3 lines · Daniel Mack

What kernel do you work on? Did you try the other patch that I sent some days ago and that already went mainline?
https://git.kernel.org/?p=linux/kernel/git/tiwai/sound.git;a=commit;h=015618b902ae8e28705b7af9b4668615fea48ddd

Hrm.

I am using Gentoo's kernel from gentoo-sources. When I wrote the other mail I was on 3.5.1, but now I'm using 3.5.3, and when I apply that patch, I get:

1 out of 5 hunks FAILED -- saving rejects to file sound/usb/pcm.c.rej % cat sound/usb/pcm.c.rej

usb/pcm.c +1 -4
@@ -544,13 +544,10 @@
     subs->last_frame_number = 0;
     runtime->delay = 0;
-    /* clear the pending deactivation on the target EPs */
-    deactivate_endpoints(subs);
-
     /* for playback, submit the URBs now; otherwise, the first hwptr_done
      * updates for all URBs would happen at the same time when starting */
     if (subs->direction == SNDRV_PCM_STREAM_PLAYBACK)
-        return start_endpoints(subs);
+        return start_endpoints(subs, 1);
     return 0;
 }
 
 

It already doesn't have that deactivate_endpoints() line.

Quoted 1 line

So, I manually adding the 1 arg to start_endpoints() for "can_sleep".

The important thing is not to call deactivate_endpoints() from the prepare callback.

Quoted 1 line

Rebooting to this kernel gives the exact same results, though.

Please try a kernel built from Takashi's branch:

https://git.kernel.org/?p=linux/kernel/git/tiwai/sound.git

That alone should fix your problem. The three patches of this series fix some occasional stream dropouts.

Thanks for testing,
Daniel
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

#4 lore raw
In reply to ☈king
Quoted 19 lines · ☈king

I am having the following symptoms, before and after application of this thread's patches:

Given:
- An onboard card
- A Logitech h390 USB headset
- alsa-info of: http://www.alsa-project.org/db/?f=942b5e96b53a667270f895ec5061ca14af0339ee

When:
- I do: aplay $(locate .wav | grep Front)
it outputs:
alsa ALSA lib pcm_direct.c:980:(snd1_pcm_direct_initialize_slave)
unable to install hw params
ALSA lib pcm_dmix.c:1030:(snd_pcm_dmix_open) unable to initialize slave
aplay: main:682: audio open error: Broken pipe
- I do a Skype "Make a test sound"
/var/log/messages streams dozens of these:
kernel: cannot submit urb 0, error -28: not enough bandwidth

Quoted 4 lines

Note that this is a new laptop and headset, so I haven't compared how either works on other setups, such as with other kernels or alsa versions.

Any hints? Any further info needed?

What kernel do you work on? Did you try the other patch that I sent some days ago and that already went mainline?

https://git.kernel.org/?p=linux/kernel/git/tiwai/sound.git;a=commit;h=015618b902ae8e28705b7af9b4668615fea48ddd

_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel