MX28: mx28evk: Align SSP clock speed

PATCH New Otavio Salvador 4 participants 7 messages Aug 28, 2012 – Sep 4, 2012

lore

Share & tools

lore

Otavio Salvador

author

2012-08-28 09:56 UTC #0 lore raw

PATCH v2 1/2 MX28: mx28evk: Align SSP clock speed

Align the SSP clock speed with oscilator to achieve higher transfer stability.

Signed-off-by Otavio Salvador <[email protected]>

---
Changes in v2:
- reword commit log to match the change description done on m28evk.

 board/freescale/mx28evk/mx28evk.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

board/freescale/mx28evk/mx28evk.c +2 -2

index 867d3c8..d782aea 100644
@@ -49,8 +49,8 @@ int board_early_init_f(void)
 
 	/* SSP0 clock at 96MHz */
 	mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
-	/* SSP2 clock at 96MHz */
-	mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
+	/* SSP2 clock at 160MHz */
+	mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
 
 #ifdef	CONFIG_CMD_USB
 	mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);

Signature · 1 line

1.7.10.4

Otavio Salvador

author

2012-08-28 09:56 UTC #1 lore raw

PATCH v2 2/2 MX28: mx28evk: Enable SPI DMA

Signed-off-by Otavio Salvador <[email protected]>

---
Changes in v2:
- new patch

 include/configs/mx28evk.h |    1 +
 1 file changed, 1 insertion(+)

include/configs/mx28evk.h +1 -0

index 8d83495..a5a98fb 100644
@@ -200,6 +200,7 @@
 #ifdef CONFIG_CMD_SPI
 #define CONFIG_HARD_SPI
 #define CONFIG_MXS_SPI
+#define CONFIG_MXS_SPI_DMA_ENABLE
 #define CONFIG_SPI_HALF_DUPLEX
 #define CONFIG_DEFAULT_SPI_BUS		2
 #define CONFIG_DEFAULT_SPI_MODE		SPI_MODE_0

Signature · 1 line

1.7.10.4

Stefano Babic

2012-09-04 10:04 UTC #2 lore raw

PATCH v2 2/2 MX28: mx28evk: Enable SPI DMA

Quoted 2 lines · Otavio Salvador

Signed-off-by Otavio Salvador <[email protected]>
---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Marek Vasut

2012-08-28 10:18 UTC #3 lore raw

PATCH v2 1/2 MX28: mx28evk: Align SSP clock speed

In reply to Otavio Salvador

Dear Otavio Salvador,

Quoted 2 lines

Align the SSP clock speed with oscilator to achieve higher transfer stability.

This change is still pointless, unless you have user for this!

Quoted 13 lines

Signed-off-by Otavio Salvador <[email protected]>
---
Changes in v2:
- reword commit log to match the change description done on m28evk.
 board/freescale/mx28evk/mx28evk.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644

board/freescale/mx28evk/mx28evk.c int board_early_init_f(void) · line 56

Quoted 10 lines

board/freescale/mx28evk/mx28evk.c +2 -2

@@ -49,8 +49,8 @@ int board_early_init_f(void)
 
 	/* SSP0 clock at 96MHz */
 	mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
-	/* SSP2 clock at 96MHz */
-	mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
+	/* SSP2 clock at 160MHz */
+	mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
 
 #ifdef	CONFIG_CMD_USB
 	mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);

Best regards,
Marek Vasut

Otavio Salvador

author

2012-08-28 21:47 UTC #4 lore raw

PATCH v2 1/2 MX28: mx28evk: Align SSP clock speed

Quoted 6 lines · Marek Vasut

Dear Otavio Salvador,
Quoted 2 lines
Align the SSP clock speed with oscilator to achieve higher transfer stability.
This change is still pointless, unless you have user for this!

As far as I know the SPI flash uses SSP2; so it is a user of it.

Quoted 26 lines

Quoted 13 lines
Signed-off-by Otavio Salvador <[email protected]>
---
Changes in v2:
- reword commit log to match the change description done on m28evk.
 board/freescale/mx28evk/mx28evk.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644
board/freescale/mx28evk/mx28evk.c int board_early_init_f(void) · line 56
Quoted 10 lines
board/freescale/mx28evk/mx28evk.c +2 -2
@@ -49,8 +49,8 @@ int board_early_init_f(void)
 
      /* SSP0 clock at 96MHz */
      mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
-     /* SSP2 clock at 96MHz */
-     mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
+     /* SSP2 clock at 160MHz */
+     mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
 
 #ifdef       CONFIG_CMD_USB
      mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
Best regards,
Marek Vasut

Signature · 3 lines

Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Marek Vasut

2012-08-29 01:17 UTC #5 lore raw

PATCH v2 1/2 MX28: mx28evk: Align SSP clock speed

Dear Otavio Salvador,

Quoted 9 lines · Marek Vasut

Quoted 6 lines
Dear Otavio Salvador,
Quoted 2 lines
Align the SSP clock speed with oscilator to achieve higher transfer stability.
This change is still pointless, unless you have user for this!
As far as I know the SPI flash uses SSP2; so it is a user of it.

So, why dont you also align the default clockspeed of the spi flash attached to ssp2 in the config file within this patch?

Lemme answer myself after taking a look ... because that's already done.

Ok,

Acked-by Marek Vasut <[email protected]>

Quoted 22 lines

Quoted 22 lines
Quoted 22 lines
Signed-off-by Otavio Salvador <[email protected]>
---
Changes in v2:
- reword commit log to match the change description done on m28evk.
 board/freescale/mx28evk/mx28evk.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/board/freescale/mx28evk/mx28evk.c index 867d3c8..d782aea 100644
board/freescale/mx28evk/mx28evk.c +2 -2
@@ -49,8 +49,8 @@ int board_early_init_f(void)
 
      /* SSP0 clock at 96MHz */
      mx28_set_sspclk(MXC_SSPCLK0, 96000, 0);
 
-     /* SSP2 clock at 96MHz */
-     mx28_set_sspclk(MXC_SSPCLK2, 96000, 0);
+     /* SSP2 clock at 160MHz */
+     mx28_set_sspclk(MXC_SSPCLK2, 160000, 0);
 

Quoted 6 lines

Quoted 6 lines
Quoted 3 lines
board/freescale/mx28evk/mx28evk.c +0 -0
 #ifdef       CONFIG_CMD_USB
 
      mxs_iomux_setup_pad(MX28_PAD_SSP2_SS1__USB1_OVERCURRENT);
Best regards,
Marek Vasut

Best regards,
Marek Vasut

Stefano Babic

2012-09-04 10:04 UTC #6 lore raw

PATCH v2 1/2 MX28: mx28evk: Align SSP clock speed

In reply to Otavio Salvador

Quoted 5 lines · Otavio Salvador

Align the SSP clock speed with oscilator to achieve higher transfer stability.
Signed-off-by Otavio Salvador <[email protected]>
---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================