disk/partition: Fix the depend for all the partitions file

PATCH Superseded Zhong Hongbo 2 participants 5 messages Aug 15, 2012 – Sep 4, 2012

lore

Share & tools

lore

Zhong Hongbo

author

2012-08-15 23:58 UTC #0 lore raw

PATCH v2 1/1 disk/partition: Fix the depend for all the partitions file

From: Zhong Hongbo <[email protected]>

all the patitions should depend CONFIG_PARTITIONS, no the CONFIG_CMD_$(device). The device symbol may be SATA, SCSI, USB, MMC, SYSTEMACE. Or else when the filesystem command be enabled, But board's configure file can not include any CONFIG_CMD_$(device), The u-boot will fail build. For example:
CONFIG_CMD_EXT2 is defined in smdk6400.h, but the boards can not define any disk device. The error information of build as following:

common/cmd_ext2.c:191: undefined reference to get_partition_info' fs/ext2/libext2fs.o: In function ext2fs_set_blk_dev':
fs/ext2/dev.c:44: undefined reference to `get_partition_info'

Signed-off-by Zhong Hongbo <[email protected]>

---
Change for V2:
- Add Signed-off-by.

---
 disk/part.c       |   21 +++------------------
 disk/part_amiga.c |    6 +-----
 disk/part_dos.c   |    7 +------
 disk/part_efi.c   |    7 +------
 disk/part_iso.c   |    7 +------
 disk/part_mac.c   |    7 +------
 6 files changed, 8 insertions(+), 47 deletions(-)

disk/part.c +3 ~~-18~~

index 76f3939..d296a55 100644
@@ -34,12 +34,7 @@
 #define PRINTF(fmt,args...)
 #endif
 
-#if (defined(CONFIG_CMD_IDE) || \
-     defined(CONFIG_CMD_SATA) || \
-     defined(CONFIG_CMD_SCSI) || \
-     defined(CONFIG_CMD_USB) || \
-     defined(CONFIG_MMC) || \
-     defined(CONFIG_SYSTEMACE) )
+#ifdef CONFIG_PARTITIONS
 
 struct block_drvr {
 	char *name;

@@ -103,12 +98,7 @@ block_dev_desc_t *get_dev(char* ifname, int dev)
 }
 #endif
 
-#if (defined(CONFIG_CMD_IDE) || \
-     defined(CONFIG_CMD_SATA) || \
-     defined(CONFIG_CMD_SCSI) || \
-     defined(CONFIG_CMD_USB) || \
-     defined(CONFIG_MMC) || \
-     defined(CONFIG_SYSTEMACE) )
+#ifdef CONFIG_PARTITIONS
 
 /* ------------------------------------------------------------------------- */
 /*

@@ -238,12 +228,7 @@ void dev_print (block_dev_desc_t *dev_desc)
 }
 #endif
 
-#if (defined(CONFIG_CMD_IDE) || \
-     defined(CONFIG_CMD_SATA) || \
-     defined(CONFIG_CMD_SCSI) || \
-     defined(CONFIG_CMD_USB) || \
-     defined(CONFIG_MMC)		|| \
-     defined(CONFIG_SYSTEMACE) )
+#ifdef CONFIG_PARTITIONS
 
 #if defined(CONFIG_MAC_PARTITION) || \
     defined(CONFIG_DOS_PARTITION) || \

disk/part_amiga.c +1 -5

index dc7d462..5df55c8 100644
@@ -26,11 +26,7 @@
 #include <ide.h>
 #include "part_amiga.h"
 
-#if defined(CONFIG_CMD_IDE) || \
-    defined(CONFIG_CMD_SCSI) || \
-    defined(CONFIG_CMD_USB) || \
-    defined(CONFIG_MMC) || \
-    defined(CONFIG_SYSTEMACE)
+#ifdef CONFIG_PARTITIONS
 
 #undef AMIGA_DEBUG

disk/part_dos.c +1 -6

index a43dd9c..b49ebe2 100644
@@ -35,12 +35,7 @@
 #include <ide.h>
 #include "part_dos.h"
 
-#if defined(CONFIG_CMD_IDE) || \
-    defined(CONFIG_CMD_SATA) || \
-    defined(CONFIG_CMD_SCSI) || \
-    defined(CONFIG_CMD_USB) || \
-    defined(CONFIG_MMC) || \
-    defined(CONFIG_SYSTEMACE)
+#ifdef CONFIG_PARTITIONS
 
 /* Convert char[4] in little endian format to the host format integer
  */

disk/part_efi.c +1 -6

index 02927a0..22dc0ea 100644
@@ -37,12 +37,7 @@
 #include "part_efi.h"
 #include <linux/ctype.h>
 
-#if defined(CONFIG_CMD_IDE) || \
-    defined(CONFIG_CMD_SATA) || \
-    defined(CONFIG_CMD_SCSI) || \
-    defined(CONFIG_CMD_USB) || \
-    defined(CONFIG_MMC) || \
-    defined(CONFIG_SYSTEMACE)
+#ifdef CONFIG_PARTITIONS
 
 /* Convert char[2] in little endian format to the host format integer
  */

disk/part_iso.c +1 -6

index 4401790..f929563 100644
@@ -25,12 +25,7 @@
 #include <command.h>
 #include "part_iso.h"
 
-#if defined(CONFIG_CMD_IDE) || \
-    defined(CONFIG_CMD_SCSI) || \
-    defined(CONFIG_CMD_SATA) || \
-    defined(CONFIG_CMD_USB) || \
-    defined(CONFIG_MMC) || \
-    defined(CONFIG_SYSTEMACE)
+#ifdef CONFIG_PARTITIONS
 
 /* #define	ISO_PART_DEBUG */

disk/part_mac.c +1 -6

index c1afc8c..c3b2aa3 100644
@@ -34,12 +34,7 @@
 #include <ide.h>
 #include "part_mac.h"
 
-#if defined(CONFIG_CMD_IDE) || \
-    defined(CONFIG_CMD_SCSI) || \
-    defined(CONFIG_CMD_SATA) || \
-    defined(CONFIG_CMD_USB) || \
-    defined(CONFIG_MMC) || \
-    defined(CONFIG_SYSTEMACE)
+#ifdef CONFIG_PARTITIONS
 
 /* stdlib.h causes some compatibility problems; should fixe these! -- wd */
 #ifndef __ldiv_t_defined

Signature · 1 line

1.7.5.4

Wolfgang Denk

2012-09-02 12:40 UTC #1 lore raw

PATCH v2 1/1 disk/partition: Fix the depend for all the partitions file

Dear Zhong Hongbo,

Quoted 11 lines · In message <[email protected]> you wrote:

From: Zhong Hongbo <[email protected]>
all the patitions should depend CONFIG_PARTITIONS, no the CONFIG_CMD_$(device). The device symbol may be SATA, SCSI, USB, MMC, SYSTEMACE. Or else when the filesystem command be enabled, But board's configure file can not include any CONFIG_CMD_$(device), The u-boot will fail build. For example:
CONFIG_CMD_EXT2 is defined in smdk6400.h, but the boards can not define any disk device. The error information of build as following:

Quoted 5 lines

common/cmd_ext2.c:191: undefined reference to get_partition_info' fs/ext2/libext2fs.o: In function ext2fs_set_blk_dev':
fs/ext2/dev.c:44: undefined reference to `get_partition_info'
Signed-off-by Zhong Hongbo <[email protected]>

Can you PLEASE make sure to have the string "PATCH" included with all patches you are posting?

As is, your submissions get both lost to patchwork and to the respective maintainer's attention.

Best regards,

Wolfgang Denk

Signature · 6 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Chapter 1 -- The story so  far:
In the beginning the Universe was created. This has  made  a  lot  of
people very angry and been widely regarded as a bad move.

Zhong Hongbo

author

2012-09-04 14:13 UTC #2 lore raw

PATCH v2 1/1 disk/partition: Fix the depend for all the partitions file

Quoted 14 lines · Wolfgang Denk

Dear Zhong Hongbo,
Quoted 11 lines · In message <[email protected]> you wrote:
From: Zhong Hongbo <[email protected]>
all the patitions should depend CONFIG_PARTITIONS, no the CONFIG_CMD_$(device). The device symbol may be SATA, SCSI, USB, MMC, SYSTEMACE. Or else when the filesystem command be enabled, But board's configure file can not include any CONFIG_CMD_$(device), The u-boot will fail build. For example:
CONFIG_CMD_EXT2 is defined in smdk6400.h, but the boards can not define any disk device. The error information of build as following:

Quoted 8 lines

Quoted 5 lines
common/cmd_ext2.c:191: undefined reference to get_partition_info' fs/ext2/libext2fs.o: In function ext2fs_set_blk_dev':
fs/ext2/dev.c:44: undefined reference to `get_partition_info'
Signed-off-by Zhong Hongbo <[email protected]>
Can you PLEASE make sure to have the string "PATCH" included with all patches you are posting?

Quoted 3 lines

As is, your submissions get both lost to patchwork and to the respective maintainer's attention.

I will add CONFIG_PARTITIONS to all the boards and test it. If all the boards can compile successful, I will re-send the patch.

Thanks,
hongbo

Quoted 5 lines

Best regards,
Wolfgang Denk

Wolfgang Denk

2012-09-02 12:41 UTC #3 lore raw

PATCH v2 1/1 disk/partition: Fix the depend for all the partitions file

In reply to Zhong Hongbo

Dear Zhong Hongbo,

Quoted 19 lines · In message <[email protected]> you wrote:

From: Zhong Hongbo <[email protected]>
all the patitions should depend CONFIG_PARTITIONS, no the CONFIG_CMD_$(device). The device symbol may be SATA, SCSI, USB, MMC, SYSTEMACE. Or else when the filesystem command be enabled, But board's configure file can not include any CONFIG_CMD_$(device), The u-boot will fail build. For example:
CONFIG_CMD_EXT2 is defined in smdk6400.h, but the boards can not define any disk device. The error information of build as following:
common/cmd_ext2.c:191: undefined reference to get_partition_info' fs/ext2/libext2fs.o: In function ext2fs_set_blk_dev':
fs/ext2/dev.c:44: undefined reference to `get_partition_info'
Signed-off-by Zhong Hongbo <[email protected]>
---
Change for V2:
- Add Signed-off-by.

Quoted 8 lines

---
 disk/part.c       |   21 +++------------------
 disk/part_amiga.c |    6 +-----
 disk/part_dos.c   |    7 +------
 disk/part_efi.c   |    7 +------
 disk/part_iso.c   |    7 +------
 disk/part_mac.c   |    7 +------
 6 files changed, 8 insertions(+), 47 deletions(-)

Hm.... did you make sure that all related board config files actually define CONFIG_PARTITIONS ?

I doubt so.

Best regards,

Wolfgang Denk

Signature · 4 lines

DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
COBOL is for morons.                                 -- E.W. Dijkstra

Zhong Hongbo

author

2012-09-04 14:09 UTC #4 lore raw

PATCH v2 1/1 disk/partition: Fix the depend for all the partitions file

Quoted 31 lines · Wolfgang Denk

Dear Zhong Hongbo,
Quoted 19 lines · In message <[email protected]> you wrote:
From: Zhong Hongbo <[email protected]>
all the patitions should depend CONFIG_PARTITIONS, no the CONFIG_CMD_$(device). The device symbol may be SATA, SCSI, USB, MMC, SYSTEMACE. Or else when the filesystem command be enabled, But board's configure file can not include any CONFIG_CMD_$(device), The u-boot will fail build. For example:
CONFIG_CMD_EXT2 is defined in smdk6400.h, but the boards can not define any disk device. The error information of build as following:
common/cmd_ext2.c:191: undefined reference to get_partition_info' fs/ext2/libext2fs.o: In function ext2fs_set_blk_dev':
fs/ext2/dev.c:44: undefined reference to `get_partition_info'
Signed-off-by Zhong Hongbo <[email protected]>
---
Change for V2:
- Add Signed-off-by.
Quoted 8 lines
---
 disk/part.c       |   21 +++------------------
 disk/part_amiga.c |    6 +-----
 disk/part_dos.c   |    7 +------
 disk/part_efi.c   |    7 +------
 disk/part_iso.c   |    7 +------
 disk/part_mac.c   |    7 +------
 6 files changed, 8 insertions(+), 47 deletions(-)

Quoted 2 lines

Hm.... did you make sure that all related board config files actually define CONFIG_PARTITIONS ?

No, Do you think that I should add "CONFIG_PARTITIONS" to all the boards? and try compile it?

I will do it recently.

Thanks,
hongbo

Quoted 7 lines

I doubt so.
Best regards,
Wolfgang Denk