mtd: gpmi-nand: Improve logging style
Subsystems (2)
PATCH 1/1 mtd: gpmi-nand: Improve logging style
From: Fabio Estevam <[email protected]>
Improve logging style by prefixing the pr_ messages with "gpmi_nand".
Signed-off-by Fabio Estevam <[email protected]>
--- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)
drivers/mtd/nand/gpmi-nand/gpmi-nand.c +6 -3
@@ -18,6 +18,9 @@* with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ + +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/clk.h> #include <linux/slab.h> #include <linux/interrupt.h>
@@ -114,7 +117,7 @@ int common_nfc_set_geometry(struct gpmi_nand_data *this)/* We use the same ECC strength for all chunks. */ geo->ecc_strength =get_ecc_strength (this);if (!geo->ecc_strength) { -pr_err ("We get a wrong ECC strength.\n" ); +pr_err ("wrong ECC strength.\n" );return -EINVAL ; }
@@ -1685,9 +1688,9 @@ static int __init gpmi_nand_init(void) err =platform_driver_register (&gpmi_nand_driver);if (err ==0 ) -printk (KERN_INFO "GPMI NAND driver registered. (IMX)\n" ); +pr_info ("driver registered.\n" );else -pr_err ("i.MX GPMI NAND driver registration failed\n" ); +pr_err ("driver registration failed.\n" );return err; }
Signature · 1 line
1.7.9.5
Quoted 34 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Improve logging style by prefixing the
pr_messages with "gpmi_nand".Signed-off-by Fabio Estevam <[email protected]>--- drivers/mtd/nand/gpmi-nand/gpmi-nand.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-)drivers/mtd/nand/gpmi-nand/gpmi-nand.c +4
-1@@ -18,6 +18,9 @@* with this program; if not, write to the Free Software Foundation, Inc., * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ + +#define pr_fmt (fmt) KBUILD_MODNAME ": " fmt +#include <linux/clk.h> #include <linux/slab.h> #include <linux/interrupt.h> @@ -114,7 +117,7 @@ int common_nfc_set_geometry(struct gpmi_nand_data *this)/* We use the same ECC strength for all chunks. */ geo->ecc_strength =get_ecc_strength (this);if (!geo->ecc_strength) { -pr_err ("We get a wrong ECC strength.\n" ); +pr_err ("wrong ECC strength.\n" );return -EINVAL ; }@@ -1685,9 +1688,9 @@ static int __init gpmi_nand_init(void)
drivers/mtd/nand/gpmi-nand/gpmi-nand.c static int __init gpmi_nand_init(void) · line 1696
Quoted 10 lines
drivers/mtd/nand/gpmi-nand/gpmi-nand.c +2
-2err =platform_driver_register (&gpmi_nand_driver);if (err ==0 ) -printk (KERN_INFO "GPMI NAND driver registered. (IMX)\n" ); +pr_info ("driver registered.\n" );else -pr_err ("i.MX GPMI NAND driver registration failed\n" ); +pr_err ("driver registration failed.\n" );return err; }
thanks.
Acked-by Huang Shijie <[email protected]>
Huang Shijie
Artem Bityutskiy
AppliedQuoted 5 lines · Fabio Estevam
From: Fabio Estevam <[email protected]>
Improve logging style by prefixing the
pr_messages with "gpmi_nand".Signed-off-by Fabio Estevam <[email protected]>
Pushed to l2-mtd.git, thanks!
Signature · 2 lines
Best Regards, Artem Bityutskiy