etherdevice: introduce help function eth_zero_addr()

PATCH Applied Duan Jiong 2 participants 2 messages Sep 9, 2012 – Sep 10, 2012

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Duan Jiong

author

2012-09-09 02:32 UTC #0 lore raw

PATCH 1/1 etherdevice: introduce help function eth_zero_addr()

a lot of code has either the memset or an inefficient copy from a static array that contains the all-zeros Ethernet address. Introduce help function eth_zero_addr() to fill an address with all zeros, making the code clearer and allowing us to get rid of some constant arrays.

Signed-off-by Duan Jiong <[email protected]>

---
 include/linux/etherdevice.h | 11 +++++++++++
 1 file changed, 11 insertions(+)

include/linux/etherdevice.h +11 -0

index d426336..b006ba0 100644
@@ -151,6 +151,17 @@ static inline void eth_broadcast_addr(u8 *addr)
 }
 
 /**
+ * eth_zero_addr - Assign zero address
+ * @addr: Pointer to a six-byte array containing the Ethernet address
+ *
+ * Assign the zero address to the given address array.
+ */
+static inline void eth_zero_addr(u8 *addr)
+{
+	memset(addr, 0x00, ETH_ALEN);
+}
+
+/**
  * eth_hw_addr_random - Generate software assigned random Ethernet and
  * set device flag
  * @dev: pointer to net_device structure

Signature · 1 line

1.7.11.4

David Miller

maintainer Applied

2012-09-10 19:50 UTC #1 lore raw

From: Duan Jiong <[email protected]>
Date: Sun, 09 Sep 2012 10:32:28 +0800

Quoted 7 lines

a lot of code has either the memset or an inefficient copy from a static array that contains the all-zeros Ethernet address. Introduce help function eth_zero_addr() to fill an address with all zeros, making the code clearer and allowing us to get rid of some constant arrays.
Signed-off-by Duan Jiong <[email protected]>

Applied, thanks.