Skip to contentSkip to conversation

block: remove the duplicated setting for congestion_threshold

PATCH In review Jaehoon Chung 2 participants 2 messages Aug 31, 2012 – Sep 9, 2012 Block layer

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 block: remove the duplicated setting for congestion_threshold

Before call the blk_queue_congestion_threshold(),
the blk_queue_congestion_threshold() is already called at blk_queue_make_rquest(). Because this code is the duplicated, it has removed.

---
 block/blk-core.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)
block/blk-core.c +0 -2
index 4b4dbdf..a418249 100644
@@ -713,8 +713,6 @@ blk_init_allocated_queue(struct request_queue *q, request_fn_proc *rfn,
 	if (elevator_init(q, NULL))
 		return NULL;
 
-	blk_queue_congestion_threshold(q);
-
 	/* all done, end the initial bypass */
 	blk_queue_bypass_end(q);
 	return q;
Signature · 1 line
1.7.4.1
maintainer
#1 lore raw
Quoted 3 lines · Jaehoon Chung

Before call the blk_queue_congestion_threshold(),
the blk_queue_congestion_threshold() is already called at blk_queue_make_rquest(). Because this code is the duplicated, it has removed.

So it is, good catch. Applied.

Signature · 1 line
Jens Axboe