Skip to contentSkip to conversation

ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

PATCH New Florian Vaussard 2 participants 7 messages Sep 10, 2012 Device tree bindings

lore
Share & tools
lore

Florian Vaussard

author
#0 lore raw

cover ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

Hello,

This patch adds the support for the blue LED connected to the LEDB pin of the TWL4030 on the Gumstix Overo when booting from the device tree.

Build on top of Benoit's for_3.7/dts tree.

Regards,
Florian

Florian Vaussard (1):
ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

 arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)
Signature · 1 line
1.7.5.4
author
#1 lore raw

PATCH 1/1 ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

Support the blue LED connected to the LEDB pin of the TWL4030 on the Gumstix Overo.

Signed-off-by Florian Vaussard <[email protected]>
---
 arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)
arch/arm/boot/dts/omap3-overo.dtsi +15 -0
index d6cc5e2..89808ce 100644
@@ -13,6 +13,17 @@
 
 /include/ "omap3.dtsi"
 
+/ {
+	leds {
+		compatible = "gpio-leds";
+		overo {
+			label = "overo:blue:COM";
+			gpios = <&twl_gpio 19 0>;
+			linux,default-trigger = "mmc0";
+		};
+	};
+};
+
 &i2c1 {
 	clock-frequency = <2600000>;
 

@@ -40,3 +51,7 @@
 &mmc2 {
 	bus-width = <4>;
 };
+
+&twl_gpio {
+	ti,use-leds;
+};
Signature · 1 line
1.7.5.4
#2 lore raw

PATCH 1/1 ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

Quoted 13 lines · Florian Vaussard

Support the blue LED connected to the LEDB pin of the TWL4030 on the Gumstix Overo.

Signed-off-by Florian Vaussard <[email protected]>
---
 arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)
arch/arm/boot/dts/omap3-overo.dtsi +0 -0
index d6cc5e2..89808ce 100644

arch/arm/boot/dts/omap3-overo.dtsi line 16

Quoted 4 lines
arch/arm/boot/dts/omap3-overo.dtsi +1 -0
@@ -13,6 +13,17 @@
 
 /include/ "omap3.dtsi"
 
+/ {

BTW, I'm just wondering. Cannot we use overo without tobi?

In that case, the model and compatible should probably be used as well:

	model = "TI OMAP3 Gumstix Overo";
	compatible = "ti,omap3-overo", "ti,omap3";
Quoted 15 lines
arch/arm/boot/dts/omap3-overo.dtsi +10 -0
+	leds {
+		compatible = "gpio-leds";
+		overo {
+			label = "overo:blue:COM";
+			gpios = <&twl_gpio 19 0>;
+			linux,default-trigger = "mmc0";
+		};
+	};
+};
+
 &i2c1 {
 	clock-frequency = <2600000>;

arch/arm/boot/dts/omap3-overo.dtsi line 57

Quoted 7 lines
arch/arm/boot/dts/omap3-overo.dtsi +4 -0
@@ -40,3 +51,7 @@
 &mmc2 {
 	bus-width = <4>;
 };
+
+&twl_gpio {
+	ti,use-leds;
+};

Otherwise, it is fine.

Thanks,
Benoit

author
#3 lore raw

PATCH 1/1 ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

Quoted 16 lines
Quoted 16 lines

Support the blue LED connected to the LEDB pin of the TWL4030 on the Gumstix Overo.

Signed-off-by Florian Vaussard <[email protected]>
---
  arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
  1 files changed, 15 insertions(+), 0 deletions(-)
arch/arm/boot/dts/omap3-overo.dtsi +0 -0
index d6cc5e2..89808ce 100644
@@ -13,6 +13,17 @@
 
  /include/ "omap3.dtsi"
Quoted 8 lines

arch/arm/boot/dts/omap3-overo.dtsi line 16

Quoted 1 line
arch/arm/boot/dts/omap3-overo.dtsi +1 -0
+/ {

BTW, I'm just wondering. Cannot we use overo without tobi?

In that case, the model and compatible should probably be used as well:

	model = "TI OMAP3 Gumstix Overo";
	compatible = "ti,omap3-overo", "ti,omap3";

No, it cannot. The Overo needs to be plugged into an expansion board, at least to get the power. Hence the absence of model and compatible in omap3-overo.dtsi.

Regards,
Florian

#4 lore raw

PATCH 1/1 ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

Quoted 21 lines · Florian Vaussard
Quoted 21 lines
Quoted 14 lines

Support the blue LED connected to the LEDB pin of the TWL4030 on the Gumstix Overo.

Signed-off-by Florian Vaussard <[email protected]>
---
  arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
  1 files changed, 15 insertions(+), 0 deletions(-)
arch/arm/boot/dts/omap3-overo.dtsi +0 -0
index d6cc5e2..89808ce 100644

arch/arm/boot/dts/omap3-overo.dtsi line 16

Quoted 4 lines
arch/arm/boot/dts/omap3-overo.dtsi +1 -0
@@ -13,6 +13,17 @@
 
  /include/ "omap3.dtsi"
 
+/ {

BTW, I'm just wondering. Cannot we use overo without tobi?

Quoted 8 lines
Quoted 4 lines

In that case, the model and compatible should probably be used as well:

    model = "TI OMAP3 Gumstix Overo";
    compatible = "ti,omap3-overo", "ti,omap3";

No, it cannot. The Overo needs to be plugged into an expansion board, at least to get the power. Hence the absence of model and compatible in omap3-overo.dtsi.

OK, cool. I was wondering because we already have a board-overo.c in the kernel, and there is no mention of tobi.

OK, I'm adding that patch on top of the other then.

Regards,
Benoit

#5 lore raw

PATCH 1/1 ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

Quoted 27 lines · Benoit Cousson
Quoted 26 lines · Florian Vaussard
Quoted 25 lines
Quoted 14 lines

Support the blue LED connected to the LEDB pin of the TWL4030 on the Gumstix Overo.

Signed-off-by Florian Vaussard <[email protected]>
---
  arch/arm/boot/dts/omap3-overo.dtsi |   15 +++++++++++++++
  1 files changed, 15 insertions(+), 0 deletions(-)
arch/arm/boot/dts/omap3-overo.dtsi +0 -0
index d6cc5e2..89808ce 100644

arch/arm/boot/dts/omap3-overo.dtsi line 16

Quoted 4 lines
arch/arm/boot/dts/omap3-overo.dtsi +1 -0
@@ -13,6 +13,17 @@
 
  /include/ "omap3.dtsi"
 
+/ {

BTW, I'm just wondering. Cannot we use overo without tobi?

In that case, the model and compatible should probably be used as well:

    model = "TI OMAP3 Gumstix Overo";
    compatible = "ti,omap3-overo", "ti,omap3";
Quoted 8 lines
Quoted 3 lines

No, it cannot. The Overo needs to be plugged into an expansion board, at least to get the power. Hence the absence of model and compatible in omap3-overo.dtsi.

OK, cool. I was wondering because we already have a board-overo.c in the kernel, and there is no mention of tobi.

OK, I'm adding that patch on top of the other then.

I'm just going to update the subject to:
ARM: dts: omap3-overo: Add support for the blue LED

regards,
Benoit

author
#6 lore raw

PATCH 1/1 ARM: dts: OMAP3: Add gpio-twl4030 properties for Overo

In reply to Benoit Cousson
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines

BTW, I'm just wondering. Cannot we use overo without tobi?

In that case, the model and compatible should probably be used as well:

     model = "TI OMAP3 Gumstix Overo";
     compatible = "ti,omap3-overo", "ti,omap3";
Quoted 6 lines
Quoted 3 lines

No, it cannot. The Overo needs to be plugged into an expansion board, at least to get the power. Hence the absence of model and compatible in omap3-overo.dtsi.

OK, cool. I was wondering because we already have a board-overo.c in the kernel, and there is no mention of tobi.

In board-overo.c, the various features of each expansion board are configured using CONFIG_* options, which is not possible when booting with a device tree.

Regards,
Florian