Cannot create subvolume with quota enabled

Hi,

The following steps reproduce the error. My kernel is 3.6-rc4 and btrfs-progs are at commit 89fe5b5f666c247aa3173745fb87c710f3a71a4a from
git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git

thor ~ # mkfs.btrfs -L test /dev/vg1/test

WARNING! - Btrfs Btrfs v0.19 IS EXPERIMENTAL WARNING! - see
http://btrfs.wiki.kernel.org before using

fs created label test on /dev/vg1/test nodesize 4096 leafsize 4096 sectorsize 4096 size 20.00GB Btrfs Btrfs v0.19 thor ~ # mount /dev/vg1/test /mnt/tmp thor ~ # btrfs quota enable /mnt/tmp thor ~

# btrfs subvolume create /mnt/tmp/test Create subvolume
'/mnt/tmp/test' ERROR: cannot create subvolume - Invalid argument

Please, do not hesitate to contact me for any further information etc.

Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at
http://vger.kernel.org/majordomo-info.html

Hi Andreas,

Quoted 8 lines · Andreas Philipp

Hi,

The following steps reproduce the error. My kernel is 3.6-rc4 and btrfs-progs are at commit 89fe5b5f666c247aa3173745fb87c710f3a71a4a from
git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git

master.

Quoted 10 lines

thor ~ # mkfs.btrfs -L test /dev/vg1/test

WARNING! - Btrfs Btrfs v0.19 IS EXPERIMENTAL WARNING! - see
http://btrfs.wiki.kernel.org before using

fs created label test on /dev/vg1/test nodesize 4096 leafsize 4096 sectorsize 4096 size 20.00GB Btrfs Btrfs v0.19 thor ~ # mount /dev/vg1/test /mnt/tmp thor ~ # btrfs quota enable /mnt/tmp thor ~

# btrfs subvolume create /mnt/tmp/test Create subvolume
'/mnt/tmp/test' ERROR: cannot create subvolume - Invalid argument

Thanks for giving quota a try. I sent a fix separately with the subject

[PATCH] Btrfs: btrfs_qgroup_inherit wrongly returns an error

Could you please see if it fixes the problem?

Thanks,
Arne

Quoted 8 lines

Please, do not hesitate to contact me for any further information etc.

Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at
http://vger.kernel.org/majordomo-info.html

Hi Arne,

Quoted 22 lines · Arne Jansen

Hi Andreas,

Quoted 8 lines · Andreas Philipp

Hi,

The following steps reproduce the error. My kernel is 3.6-rc4 and btrfs-progs are at commit 89fe5b5f666c247aa3173745fb87c710f3a71a4a from
git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git

master.

Quoted 10 lines

thor ~ # mkfs.btrfs -L test /dev/vg1/test

WARNING! - Btrfs Btrfs v0.19 IS EXPERIMENTAL WARNING! - see
http://btrfs.wiki.kernel.org before using

fs created label test on /dev/vg1/test nodesize 4096 leafsize 4096 sectorsize 4096 size 20.00GB Btrfs Btrfs v0.19 thor ~ # mount /dev/vg1/test /mnt/tmp thor ~ # btrfs quota enable /mnt/tmp thor ~

# btrfs subvolume create /mnt/tmp/test Create subvolume
'/mnt/tmp/test' ERROR: cannot create subvolume - Invalid argument

Quoted 6 lines

Thanks for giving quota a try. I sent a fix separately with the subject

[PATCH] Btrfs: btrfs_qgroup_inherit wrongly returns an error

Could you please see if it fixes the problem?

With the patch applied (on top of either 3.6-rc4 or 3.6-rc5) I can create subvolumes as you see below.

root@debian:~# mkfs.btrfs /dev/sdb

WARNING! - Btrfs Btrfs v0.19 IS EXPERIMENTAL WARNING! - see http://btrfs.wiki.kernel.org before using

fs created label (null) on /dev/sdb

        nodesize 4096 leafsize 4096 sectorsize 4096 size 3.00GB
Btrfs Btrfs v0.19
root@debian:~# mount /dev/sdb /mnt/test
root@debian:~# btrfs quota enable /mnt/test
root@debian:~# btrfs subvolume create /mnt/test/subvolume
Create subvolume '/mnt/test/subvolume'
root@debian:~# btrfs qgroup show /mnt/test
0/257 4096 4096
root@debian:~# dd if=/dev/urandom of=/mnt/test/subvolume/testfile
bs=1024k count=25
25+0 records in
25+0 records out
26214400 bytes (26 MB) copied, 2.95321 s, 8.9 MB/s
root@debian:~# btrfs qgroup show /mnt/test
0/257 4096 4096
root@debian:~# du -hs /mnt/test/*
25M     /mnt/test/subvolume

At least I expected that the output of ' btrfs qgroup show' changes after some data got written to a subvolume which is assigned to a qgroup. (Hope, I got it right.)

Thanks,
Andreas

Quoted 11 lines

Thanks,
Arne

Quoted 8 lines

Please, do not hesitate to contact me for any further information etc.

Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at
http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Quoted 58 lines

Hi Arne,

Quoted 22 lines · Arne Jansen

Hi Andreas,

Quoted 8 lines · Andreas Philipp

Hi,

The following steps reproduce the error. My kernel is 3.6-rc4 and btrfs-progs are at commit 89fe5b5f666c247aa3173745fb87c710f3a71a4a from
git://git.kernel.org/pub/scm/linux/kernel/git/mason/btrfs-progs.git

master.

Quoted 10 lines

thor ~ # mkfs.btrfs -L test /dev/vg1/test

WARNING! - Btrfs Btrfs v0.19 IS EXPERIMENTAL WARNING! - see
http://btrfs.wiki.kernel.org before using

fs created label test on /dev/vg1/test nodesize 4096 leafsize 4096 sectorsize 4096 size 20.00GB Btrfs Btrfs v0.19 thor ~ # mount /dev/vg1/test /mnt/tmp thor ~ # btrfs quota enable /mnt/tmp thor ~

# btrfs subvolume create /mnt/tmp/test Create subvolume
'/mnt/tmp/test' ERROR: cannot create subvolume - Invalid argument

Quoted 6 lines

Thanks for giving quota a try. I sent a fix separately with the subject

[PATCH] Btrfs: btrfs_qgroup_inherit wrongly returns an error

Could you please see if it fixes the problem?

With the patch applied (on top of either 3.6-rc4 or 3.6-rc5) I can create subvolumes as you see below.

root@debian:~# mkfs.btrfs /dev/sdb

WARNING! - Btrfs Btrfs v0.19 IS EXPERIMENTAL WARNING! - see http://btrfs.wiki.kernel.org before using

fs created label (null) on /dev/sdb

        nodesize 4096 leafsize 4096 sectorsize 4096 size 3.00GB
Btrfs Btrfs v0.19
root@debian:~# mount /dev/sdb /mnt/test
root@debian:~# btrfs quota enable /mnt/test
root@debian:~# btrfs subvolume create /mnt/test/subvolume
Create subvolume '/mnt/test/subvolume'
root@debian:~# btrfs qgroup show /mnt/test
0/257 4096 4096
root@debian:~# dd if=/dev/urandom of=/mnt/test/subvolume/testfile
bs=1024k count=25
25+0 records in
25+0 records out
26214400 bytes (26 MB) copied, 2.95321 s, 8.9 MB/s
root@debian:~# btrfs qgroup show /mnt/test
0/257 4096 4096
root@debian:~# du -hs /mnt/test/*
25M     /mnt/test/subvolume

Quoted 3 lines

At least I expected that the output of ' btrfs qgroup show' changes after some data got written to a subvolume which is assigned to a qgroup. (Hope, I got it right.)

due to delayed-*, the accounting also sometimes shows up delayed. After a sync you should see the changes.

Quoted 22 lines

Thanks,
Andreas

Quoted 11 lines

Thanks,
Arne

Quoted 8 lines

Please, do not hesitate to contact me for any further information etc.

Thanks, Andreas -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at
http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Hi Andreas,

Thanks for giving quota a try. I sent a fix separately with the subject

[PATCH] Btrfs: btrfs_qgroup_inherit wrongly returns an error

Could you please see if it fixes the problem?

Quoted 9 lines · Arne Jansen

Hi Andreas,

Thanks for giving quota a try. I sent a fix separately with the subject

[PATCH] Btrfs: btrfs_qgroup_inherit wrongly returns an error

Could you please see if it fixes the problem?

Even with this patch I still have a similar problem: When I try to create a snapshot of an old subvolume that was created before I enabled quotas, it fails. For new subvolumes it works just fine. Here's an example ouput:

virtual ~ # btrfs sub snap /mnt/butter/old /mnt/butter/old-snap Create a snapshot of '/mnt/butter/old' in '/mnt/butter/old-snap'
ERROR: cannot snapshot '/mnt/butter/old' - Invalid argument

instead of applying my patch, could you please just revert

commit 5986802c2fcc754040bb7ed95f30bb16c4a843b7

Author: Dan Carpenter <[email protected]>
Date:   Mon Jul 30 02:16:10 2012 -0600

Btrfs: fix some error codes in btrfs_qgroup_inherit()

It introduces both faulty return codes.

Quoted 7 lines · Arne Jansen

instead of applying my patch, could you please just revert

commit 5986802c2fcc754040bb7ed95f30bb16c4a843b7

Author: Dan Carpenter <[email protected]>
Date:   Mon Jul 30 02:16:10 2012 -0600

Quoted 3 lines

Btrfs: fix some error codes in btrfs_qgroup_inherit()

It introduces both faulty return codes.

Yes, reverting 5986802 and completely ignoring your earlier patch works.