Skip to contentSkip to conversation

make "ipv6 ifconfig" on linux compatible with busybox ifconfig

PATCH In review Gert Doering 2 participants 2 messages Sep 11, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 make "ipv6 ifconfig" on linux compatible with busybox ifconfig

We used to call "ifconfig tun0 inet6 add...". The "inet6" part is optional, and not understood by busybox. So now we call "ifconfig tun0 add ...", which works on all supported Linux variants.

Tested on Gentoo, RHEL5+, Debian Lenny & up.

---
 src/openvpn/tun.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
src/openvpn/tun.c +1 -1
index 3d60857..4b0365d 100644
@@ -760,7 +760,7 @@ do_ifconfig (struct tuntap *tt,
       if ( do_ipv6 )
 	{
 	  argv_printf (&argv,
-			  "%s %s inet6 add %s/%d",
+			  "%s %s add %s/%d",
 			  IFCONFIG_PATH,
 			  actual,
 			  ifconfig_ipv6_local,
Signature · 1 line
1.7.8.6
#1 lore raw
Quoted 10 lines · Gert Doering

We used to call "ifconfig tun0 inet6 add...". The "inet6" part is optional, and not understood by busybox. So now we call "ifconfig tun0 add ...", which works on all supported Linux variants.

Tested on Gentoo, RHEL5+, Debian Lenny & up.

---
 src/openvpn/tun.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

ACK. Applied to master.

commit cae102ae0c2ff934c456cd584cbf87a33cd95206

Author: Gert Doering <[email protected]...>
Date:   Tue Sep 11 13:56:55 2012 +0200
    make "ipv6 ifconfig" on linux compatible with busybox ifconfig
        
    Signed-off-by: Gert Doering <[email protected]...>
    Acked-by: David Sommerseth <[email protected]...>
    Message-Id: [email protected]...
    URL: http://article.gmane.org/gmane.network.openvpn.devel/7052
    Signed-off-by: David Sommerseth <[email protected]...>

kind regards,

David Sommerseth