Skip to contentSkip to conversation

bind/03, 21 rbind/38, 33:fix missing umount and error umount in these cases

PATCH In review DAN LI 2 participants 2 messages Sep 13, 2012 – Sep 18, 2012

lore
Share & tools
lore

DAN LI

author
#0 lore raw

PATCH 1/1 bind/03, 21 rbind/38, 33:fix missing umount and error umount in these cases

The cases have the same problem that dirs are still in mount when their targets are removed.for rbind/38,beside the problem above,there are two error umount operations that umount dirs that are not in mount. and all these result in making the test script trapped in a infinite loop. To resolve these problems,all we need is just umount the mountpoints before their targets are removed and delete the error umount operations.

---
 testcases/kernel/fs/fs_bind/bind/test03  |    1 +
 testcases/kernel/fs/fs_bind/bind/test21  |    1 +
 testcases/kernel/fs/fs_bind/rbind/test33 |    1 +
 testcases/kernel/fs/fs_bind/rbind/test38 |    5 ++---
 4 files changed, 5 insertions(+), 3 deletions(-)
testcases/kernel/fs/fs_bind/bind/test03 +1 -0
index 10b678a..5989a3a 100755
@@ -98,6 +98,7 @@ trap '' ERR
 	umount share2
 	umount share2
 	umount parent1
+	umount parent2
 	
 	rm -rf parent* share*
 	cleanup
testcases/kernel/fs/fs_bind/bind/test21 +1 -0
index 741161f..ab0bf88 100755
@@ -93,6 +93,7 @@ trap '' ERR
 	umount dir1
 	umount dir2
 	umount dir3
+	umount dir4
 	
 	rm -rf dir*
 	
testcases/kernel/fs/fs_bind/rbind/test33 +1 -0
index 8247747..9ccc53b 100755
@@ -93,6 +93,7 @@ trap '' ERR
 	umount dir1
 	umount dir2
 	umount dir3
+	umount dir4
 	
 	rm -rf dir*
 	
testcases/kernel/fs/fs_bind/rbind/test38 +2 -3
index c06f072..c3f46fb 100755
@@ -82,11 +82,10 @@ trap '' ERR
 	umount parent1/child1
 	umount parent2/child1
 	umount parent2/child1
-	umount parent2 
+	umount parent2/child2
+	umount parent2
 	umount share1
 	umount share1
-	umount share2
-	umount share2
 	
 	rm -rf parent* share*
 	cleanup
Signature · 1 line
1.7.1

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

#1 lore raw
Quoted 6 lines · DAN LI

The cases have the same problem that dirs are still in mount when their targets are removed.for rbind/38,beside the problem above,there are two error umount operations that umount dirs that are not in mount. and all these result in making the test script trapped in a infinite loop. To resolve these problems,all we need is just umount the mountpoints before their targets are removed and delete the error umount operations.

Pushed, thank you.

Wanlong Gao

Quoted 12 lines

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/

Quoted 5 lines

_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list

------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ltp-list