Skip to contentSkip to conversation

libsndfile: select BR2_LARGEFILE

PATCH New Ryan Mallon 2 participants 2 messages Sep 17, 2012 – Sep 18, 2012

lore
Share & tools
lore

Ryan Mallon

author
#0 lore raw

PATCH 1/1 libsndfile: select BR2_LARGEFILE

libsndfile requires sizeof(sf_count_t) == 8, where sf_count_t is a typedef alias for off_t. This is not true by default for all tool-chains, which leads to a runtime assert failure in binaries compiled against libsndfile. See:

http://permalink.gmane.org/gmane.comp.audio.libsndfile.devel/229

Select BR2_LARGEFILE for libsndfile so that sizeof(off_t) == 8.

Signed-off-by Ryan Mallon <[email protected]>

---

package/libsndfile/Config.in +1 -0
index 9afe496..4897ed1 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBSNDFILE
        bool "libsndfile"
+       select BR2_LARGEFILE
        help
          Libsndfile is a C library for reading and writing files containing
          sampled sound (such as MS Windows WAV and the Apple/SGI AIFF format)
#1 lore raw

PATCH 1/1 libsndfile: select BR2_LARGEFILE

Dear Ryan Mallon,

Quoted 8 lines · Ryan Mallon

libsndfile requires sizeof(sf_count_t) == 8, where sf_count_t is a

config BR2_PACKAGE_LIBSNDFILE
bool "libsndfile"
+ select BR2_LARGEFILE
help
Libsndfile is a C library for reading and writing files containing sampled sound (such as MS Windows WAV and the Apple/SGI AIFF format)

No, you shouldn't select BR2_LARGEFILE. You should depend on it. See package/cdrkit/Config.in for an example. Don't forget to also add the comment when BR2_LARGEFILE is not available.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com