Btrfs: fix memory leak in start_transaction()

PATCH New Miao Xie 1 participant 1 message Sep 20, 2012 Btrfs file system

lore

Share & tools

lore

Miao Xie

author

2012-09-20 04:14 UTC #0 lore raw

PATCH 1/1 Btrfs: fix memory leak in start_transaction()

This patch fixes memory leak of the transaction handle which happened when starting transaction failed on a freezed fs.

Signed-off-by Miao Xie <[email protected]>

---
This patch is based on btrfs-next tree

---
 fs/btrfs/transaction.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

fs/btrfs/transaction.c +3 -1

index e766d37..9bf9f6f 100644
@@ -351,8 +351,10 @@ again:
 	 */
 	if (type != TRANS_JOIN_NOLOCK &&
 	    !__sb_start_write(root->fs_info->sb, SB_FREEZE_FS, false)) {
-		if (type == TRANS_JOIN_FREEZE)
+		if (type == TRANS_JOIN_FREEZE) {
+			kmem_cache_free(btrfs_trans_handle_cachep, h);
 			return ERR_PTR(-EPERM);
+		}
 		sb_start_intwrite(root->fs_info->sb);
 	}

Signature · 1 line

1.7.6.5