serial-omap regression?
Hi Felipe,
I just noticed today that one of my boards (3530/Overo) was not making it to the console when using an Debian rootfs (nfsroot) but works fine with my basic busybox initramfs. Basically, it hangs somewhere between finishing the userspace init and launching the login shell.
git bisect ended up pointing the finger at a patch in the OMAP serial series[1]. I didn't debug this any further. Any ideas?
Kevin
72256cbd13904d4b4dbb16f5ec83a3293bb292c5 is the first bad commit commit 72256cbd13904d4b4dbb16f5ec83a3293bb292c5
Author: Felipe Balbi <[email protected]> Date: Thu Sep 6 15:45:24 2012 +0300
serial: omap: refactor receive_chars() into rdi/rlsi handlers
receive_chars() was getting too big and too difficult to follow. By splitting it into separate RDI and RSLI handlers, we have smaller functions which are easy to understand and only touch the pieces which they need to touch.
:040000 040000 69585356cd524953305cfba7d219cd65430a4067 ffdc0c05004afe8b73c1f2c0ba41e412c1faf5f4 M drivers
Quoted 10 lines · Kevin Hilman
Hi Felipe,
I just noticed today that one of my boards (3530/Overo) was not making it to the console when using an Debian rootfs (nfsroot) but works fine with my basic busybox initramfs. Basically, it hangs somewhere between finishing the userspace init and launching the login shell.
git bisect ended up pointing the finger at a patch in the OMAP serial series[1]. I didn't debug this any further. Any ideas?
I forgot to add, this was first noticed when testing with arm-soc/for-next which has the serial-omap changes pulled in as a dependency.
Kevin
Quoted 21 lines
72256cbd13904d4b4dbb16f5ec83a3293bb292c5is the first bad commit commit72256cbd13904d4b4dbb16f5ec83a3293bb292c5Author: Felipe Balbi <[email protected]> Date: Thu Sep 6 15:45:24 2012 +0300serial: omap: refactor
receive_chars()into rdi/rlsi handlers
receive_chars()was getting too big and too difficult to follow. By splitting it into separate RDI and RSLI handlers, we have smaller functions which are easy to understand and only touch the pieces which they need to touch.Tested-by Shubhrajyoti D <[email protected]>Signed-off-by Felipe Balbi <[email protected]>Signed-off-by Greg Kroah-Hartman <[email protected]>:040000 040000
69585356cd524953305cfba7d219cd65430a4067ffdc0c05004afe8b73c1f2c0ba41e412c1faf5f4M drivers
Hi,
Quoted 9 lines · Kevin Hilman
Quoted 7 lines · Kevin Hilman
Hi Felipe,
I just noticed today that one of my boards (3530/Overo) was not making it to the console when using an Debian rootfs (nfsroot) but works fine with my basic busybox initramfs. Basically, it hangs somewhere between finishing the userspace init and launching the login shell.
Quoted 7 lines
Quoted 3 lines
git bisect ended up pointing the finger at a patch in the OMAP serial series[1]. I didn't debug this any further. Any ideas?
I forgot to add, this was first noticed when testing with arm-soc/for-next which has the serial-omap changes pulled in as a dependency.
hmmm, Shubhro had written a patch to fix some mistakes on rlsi handler. Maybe it fixes this problem ?
Shubhro, can you send your patch ?
Signature · 1 line
balbi
Quoted 15 lines · Felipe Balbi
Hi,
Quoted 12 lines · Kevin Hilman
Quoted 10 lines · Kevin Hilman
Hi Felipe,
I just noticed today that one of my boards (3530/Overo) was not making it to the console when using an Debian rootfs (nfsroot) but works fine with my basic busybox initramfs. Basically, it hangs somewhere between finishing the userspace init and launching the login shell.
git bisect ended up pointing the finger at a patch in the OMAP serial series[1]. I didn't debug this any further. Any ideas?
Quoted 7 lines
Quoted 3 lines
I forgot to add, this was first noticed when testing with arm-soc/for-next which has the serial-omap changes pulled in as a dependency.
hmmm, Shubhro had written a patch to fix some mistakes on rlsi handler. Maybe it fixes this problem ?
Shubhro, can you send your patch ?
Yes I am in teh process of testing it.
Will post in an hour.
Quoted 1 line
Not sure if it's related to the cleanup series, but I've also been seeing a bunch of 'callbacks suppressed messages lately. Is anyone else seeing this?
Here's an example from a debian nfsfroot boot:
[ 20.044006] tty_init_dev: 59 callbacks suppressed [ 25.063934] tty_init_dev: 57 callbacks suppressed [ 38.910552] tty_init_dev: 38 callbacks suppressed
Kevin