Skip to contentSkip to conversation

gettext: don't build tools if they won't be installed

PATCH New Arnout Vandecappelle (Essensium/Mind) 3 participants 3 messages Sep 20, 2012 – Sep 21, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gettext: don't build tools if they won't be installed

When only libintl is requested from gettext, it is not necessary to build and install the tools in staging. Just run configure and make in the gettext-runtime directory.

This _will_ install the gettext executable in the target. But that seems the correct thing to do, since it may be used by scripts.

---
 package/gettext/gettext.mk |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
package/gettext/gettext.mk +1 -3
index 74f5218..1ddd98c 100644
@@ -31,9 +31,7 @@ endif
 # When the gettext tools are not enabled in the configuration, we only
 # install libintl to the target.
 ifeq ($(BR2_PACKAGE_GETTEXT_TOOLS),)
-define GETTEXT_INSTALL_TARGET_CMDS
-	cp -dpf $(STAGING_DIR)/usr/lib/libintl*.so* $(TARGET_DIR)/usr/lib/
-endef
+GETTEXT_SUBDIR = gettext-runtime
 endif # GETTEXT_TOOLS = n
 
 $(eval $(autotools-package))
Signature · 1 line
tg: (669d07b..) t/gettext-only-build-libintl (depends on: master)
#1 lore raw

PATCH 1/1 gettext: don't build tools if they won't be installed

Dear Arnout Vandecappelle (Essensium/Mind),

Quoted 6 lines · Arnout Vandecappelle (Essensium/Mind)

When only libintl is requested from gettext, it is not necessary to build and install the tools in staging. Just run configure and make in the gettext-runtime directory.

This _will_ install the gettext executable in the target. But that seems the correct thing to do, since it may be used by scripts.

Which scripts?

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
#2 lore raw

PATCH 1/1 gettext: don't build tools if they won't be installed

In reply to Arnout Vandecappelle (Essensium/Mind)
Quoted 6 lines · Arnout Vandecappelle (Essensium/Mind)

When only libintl is requested from gettext, it is not necessary to build and install the tools in staging. Just run configure and make in the gettext-runtime directory.

This _will_ install the gettext executable in the target. But that seems the correct thing to do, since it may be used by scripts.

It wasn't installed before and things worked, why would it be needed now? Regards.