Skip to contentSkip to conversation

net/phy: support the mv88e6352 switch

PATCH New Valentin Longchamp 3 participants 5 messages Aug 16, 2012 – Sep 28, 2012

Subsystems (2)
Network drivers Ethernet PHY
lore
Share & tools
lore

Valentin Longchamp

author
#0 lore raw

PATCH 1/1 net/phy: support the mv88e6352 switch

This patch add support for the configuration of an external switch from the 88E6xxx series from Marvell trough an MDIO link using indirect adressing. This can be used if we do not want to use an EEPROM for the configuration.

This driver is not generic and was not tested on other switches than the 88e6352. This is proposed as a first implementation that is somewhat limited but works and that can be used as a basis for further developments for this switch family.

Signed-off-by Valentin Longchamp <[email protected]>
cc Holger Brunck <[email protected]>
cc Prafulla Wadaskar <[email protected]>
cc Joe Hershberger <[email protected]>
---
 drivers/net/phy/Makefile    |    1 +
 drivers/net/phy/mv88e6352.c |  318 +++++++++++++++++++++++++++++++++++++++++++
 include/mv88e6352.h         |   92 +++++++++++++
 3 files changed, 411 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/phy/mv88e6352.c
 create mode 100644 include/mv88e6352.h
drivers/net/phy/Makefile +1 -0
index feced39..5e90d70 100644
@@ -27,6 +27,7 @@ LIB	:= $(obj)libphy.o
 
 COBJS-$(CONFIG_BITBANGMII) += miiphybb.o
 COBJS-$(CONFIG_MV88E61XX_SWITCH) += mv88e61xx.o
+COBJS-$(CONFIG_MV88E6352_SWITCH) += mv88e6352.o
 
 COBJS-$(CONFIG_PHYLIB) += phy.o
 COBJS-$(CONFIG_PHYLIB_10G) += generic_10g.o
drivers/net/phy/mv88e6352.c new file +318 -0

318 lines not on this page · raw message

include/mv88e6352.h new file +92 -0

92 lines not on this page · raw message

Signature · 1 line
1.7.1
#1 lore raw

PATCH 1/1 net/phy: support the mv88e6352 switch

Quoted 26 lines

-----Original Message-----
From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
Sent: 16 August 2012 16:47
To: u-boot at lists.denx.de
Cc: Valentin Longchamp; Holger Brunck; Prafulla Wadaskar; Joe Hershberger
Subject: [PATCH] net/phy: support the mv88e6352 switch

This patch add support for the configuration of an external switch from
the 88E6xxx series from Marvell trough an MDIO link using indirect adressing. This can be used if we do not want to use an EEPROM for the configuration.

This driver is not generic and was not tested on other switches than the
88e6352. This is proposed as a first implementation that is somewhat limited but works and that can be used as a basis for further developments for this switch family.

Signed-off-by Valentin Longchamp <[email protected]>
cc Holger Brunck <[email protected]>
cc Prafulla Wadaskar <[email protected]>
cc Joe Hershberger <[email protected]>
Quoted 8 lines
---
 drivers/net/phy/Makefile    |    1 +
 drivers/net/phy/mv88e6352.c |  318
+++++++++++++++++++++++++++++++++++++++++++
 include/mv88e6352.h         |   92 +++++++++++++
 3 files changed, 411 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/phy/mv88e6352.c
 create mode 100644 include/mv88e6352.h

Hi Valentin

I do not have any specific feedback for this patch, To me this looks okay.

Joe may pull it if he finds everything okay.

Regards...
Prafulla . . .

author
#2 lore raw

PATCH 1/1 net/phy: support the mv88e6352 switch

Quoted 37 lines · Prafulla Wadaskar
Quoted 26 lines

-----Original Message-----
From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
Sent: 16 August 2012 16:47
To: u-boot at lists.denx.de
Cc: Valentin Longchamp; Holger Brunck; Prafulla Wadaskar; Joe Hershberger
Subject: [PATCH] net/phy: support the mv88e6352 switch

This patch add support for the configuration of an external switch from
the 88E6xxx series from Marvell trough an MDIO link using indirect adressing. This can be used if we do not want to use an EEPROM for the configuration.

This driver is not generic and was not tested on other switches than the
88e6352. This is proposed as a first implementation that is somewhat limited but works and that can be used as a basis for further developments for this switch family.

Signed-off-by Valentin Longchamp <[email protected]>
cc Holger Brunck <[email protected]>
cc Prafulla Wadaskar <[email protected]>
cc Joe Hershberger <[email protected]>
Quoted 8 lines
---
 drivers/net/phy/Makefile    |    1 +
 drivers/net/phy/mv88e6352.c |  318
+++++++++++++++++++++++++++++++++++++++++++
 include/mv88e6352.h         |   92 +++++++++++++
 3 files changed, 411 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/phy/mv88e6352.c
 create mode 100644 include/mv88e6352.h

Hi Valentin

Quoted 8 lines

I do not have any specific feedback for this patch, To me this looks okay.

Joe may pull it if he finds everything okay.

Regards...
Prafulla . . .

Hi Joe,

We have never received any feedback from you regarding this patch. Could you please consider review it and if applicable apply it since it is a dependency for another series in the Marvell tree.

Thank you and best regards

Valentin

#3 lore raw

PATCH 1/1 net/phy: support the mv88e6352 switch

Hi Valentin,

Quoted 48 lines · Valentin Longchamp
Quoted 37 lines · Prafulla Wadaskar
Quoted 26 lines

-----Original Message-----
From: Valentin Longchamp [mailto:valentin.longchamp at keymile.com]
Sent: 16 August 2012 16:47
To: u-boot at lists.denx.de
Cc: Valentin Longchamp; Holger Brunck; Prafulla Wadaskar; Joe Hershberger
Subject: [PATCH] net/phy: support the mv88e6352 switch

This patch add support for the configuration of an external switch from
the 88E6xxx series from Marvell trough an MDIO link using indirect adressing. This can be used if we do not want to use an EEPROM for the configuration.

This driver is not generic and was not tested on other switches than the
88e6352. This is proposed as a first implementation that is somewhat limited but works and that can be used as a basis for further developments for this switch family.

Signed-off-by Valentin Longchamp <[email protected]>
cc Holger Brunck <[email protected]>
cc Prafulla Wadaskar <[email protected]>
cc Joe Hershberger <[email protected]>
Quoted 8 lines
---
 drivers/net/phy/Makefile    |    1 +
 drivers/net/phy/mv88e6352.c |  318
+++++++++++++++++++++++++++++++++++++++++++
 include/mv88e6352.h         |   92 +++++++++++++
 3 files changed, 411 insertions(+), 0 deletions(-)
 create mode 100644 drivers/net/phy/mv88e6352.c
 create mode 100644 include/mv88e6352.h

Hi Valentin

Quoted 8 lines

I do not have any specific feedback for this patch, To me this looks okay.

Joe may pull it if he finds everything okay.

Regards...
Prafulla . . .

Quoted 5 lines

Hi Joe,

We have never received any feedback from you regarding this patch. Could you please consider review it and if applicable apply it since it is a dependency for another series in the Marvell tree.

Sorry... I'm a bit behind on applying patches and testing. It is assigned to me in patchwork. I'll get to it as soon as I can.

Cheers,
-Joe

Applied
#4 lore raw

PATCH 1/1 net/phy: support the mv88e6352 switch

In reply to Valentin Longchamp

Hi Valentin,

Quoted 10 lines · Valentin Longchamp

This patch add support for the configuration of an external switch from the 88E6xxx series from Marvell trough an MDIO link using indirect adressing. This can be used if we do not want to use an EEPROM for the configuration.

This driver is not generic and was not tested on other switches than the 88e6352. This is proposed as a first implementation that is somewhat limited but works and that can be used as a basis for further developments for this switch family.

Quoted 5 lines
Signed-off-by Valentin Longchamp <[email protected]>
cc Holger Brunck <[email protected]>
cc Prafulla Wadaskar <[email protected]>
cc Joe Hershberger <[email protected]>

---

Applied, thanks.

-Joe