Query of zram/zsmalloc promotion
Hi all,
I would like to promote zram/zsmalloc from staging tree.
I already tried it https://lkml.org/lkml/2012/8/8/37 but I didn't get any response from you guys.
I think zram/zsmalloc's code qulity is good and they are used for many embedded vendors for a long time. So it's proper time to promote them.
The zram should put on under driver/block/. I think it's not arguable but the issue is which directory we should keep *zsmalloc*.
Now Nitin want to keep it with zram so it would be in driver/blocks/zram/ But I don't like it because zsmalloc touches several fields of struct page freely(and AFAIRC, Andrew had a same concern with me) so I want to put it under mm/.
In addtion, now zcache use it, too so it's rather awkward if we put it under dirver/blocks/zram/.
So questions.
To Andrew:
Is it okay to put it under mm/ ? Or /lib?
To Jens:
Is it okay to put zram under drvier/block/ If you are okay, I will start sending patchset after I sort out zsmalloc's location issue.
Signature · 8 lines
Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 10 lines · Minchan Kim
Hi all,
I would like to promote zram/zsmalloc from staging tree.
I already tried it https://lkml.org/lkml/2012/8/8/37 but I didn't get any response from you guys.I think zram/zsmalloc's code qulity is good and they are used for many embedded vendors for a long time. So it's proper time to promote them.
Quoted 7 lines
The zram should put on under driver/block/. I think it's not arguable but the issue is which directory we should keep *zsmalloc*.
Now Nitin want to keep it with zram so it would be in driver/blocks/zram/ But I don't like it because zsmalloc touches several fields of struct page
freely(and AFAIRC, Andrew had a same concern with me)so I want to put it undermm/.
I like the idea of keeping it in /lib or /mm. Actually 'lib' sounds more appropriate since it is dealing with storing a bunch of pages in a nice layout for great density purposes.
Quoted 4 lines
In addtion, now zcache use it, too so it's rather awkward if we put it under dirver/blocks/zram/.
Quoted 8 lines
So questions.
To Andrew:
Is it okay to put it undermm/? Or /lib?To Jens:
Is it okay to put zram under drvier/block/ If you are okay, I will start sending patchset after I sort out zsmalloc's location issue.
I would think it would be OK.
Quoted 11 lines
Signature · 9 lines
-- Kind regards, Minchan Kim -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>
Quoted 28 lines · Konrad Rzeszutek Wilk
Quoted 10 lines · Minchan Kim
Hi all,
I would like to promote zram/zsmalloc from staging tree.
I already tried it https://lkml.org/lkml/2012/8/8/37 but I didn't get any response from you guys.I think zram/zsmalloc's code qulity is good and they are used for many embedded vendors for a long time. So it's proper time to promote them.
Quoted 7 lines
The zram should put on under driver/block/. I think it's not arguable but the issue is which directory we should keep *zsmalloc*.
Now Nitin want to keep it with zram so it would be in driver/blocks/zram/ But I don't like it because zsmalloc touches several fields of struct page
freely(and AFAIRC, Andrew had a same concern with me)so I want to put it undermm/.I like the idea of keeping it in /lib or /mm. Actually 'lib' sounds more appropriate since it is dealing with storing a bunch of pages in a nice layout for great density purposes.
Quoted 6 lines
In addtion, now zcache use it, too so it's rather awkward if we put it under dirver/blocks/zram/.
So questions.
Quoted 8 lines
Quoted 6 lines
To Andrew:
Is it okay to put it undermm/? Or /lib?To Jens:
Is it okay to put zram under drvier/block/ If you are okay, I will start sending patchset after I sort out zsmalloc's location issue.I would think it would be OK.
We can certainly put it in drivers/block, I have no issue with that.
Signature · 7 lines
Jens Axboe -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"[email protected]"> [email protected] </a>