Btrfs: tivial cleanup: add space between = and the rest code

PATCH In review Wang Sheng-Hui 2 participants 3 messages Sep 24, 2012 – Sep 25, 2012 Btrfs file system

lore

Share & tools

lore

Wang Sheng-Hui

author

2012-09-24 00:47 UTC #0 lore raw

PATCH 4/4 Btrfs: tivial cleanup: add space between = and the rest code

trivial code cleanup.

Signed-off-by Wang Sheng-Hui <[email protected]>

---
 fs/btrfs/transaction.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

fs/btrfs/transaction.c +1 -1

index 675d813..3279df2 100644
@@ -1619,7 +1619,7 @@ int btrfs_clean_old_snapshots(struct btrfs_root *root)
 		    BTRFS_MIXED_BACKREF_REV)
 			ret = btrfs_drop_snapshot(root, NULL, 0, 0);
 		else
-			ret =btrfs_drop_snapshot(root, NULL, 1, 0);
+			ret = btrfs_drop_snapshot(root, NULL, 1, 0);
 		BUG_ON(ret < 0);
 	}
 	return 0;

Signature · 1 line

1.7.1

Unless it really bugs you when you're going through code, I don't think that cleanups at this level are necessary. Reading through commit history of some code via 'git blame' and seeing such cleanups is not welcome.

I have a patchet in testing that updates a few things around snapshot cleaning and this line will get fixed, so it'll not stay forever.

david

Wang Sheng-Hui

author

2012-09-25 00:01 UTC #2 lore raw

Quoted 8 lines · David Sterba

fs/btrfs/transaction.c int btrfs_clean_old_snapshots(struct btrfs_root *root) · line 1622
Quoted 4 lines · Wang Sheng-Hui
trivial code cleanup.
fs/btrfs/transaction.c +1 -1
-			ret =btrfs_drop_snapshot(root, NULL, 1, 0);
+			ret = btrfs_drop_snapshot(root, NULL, 1, 0);
Sorry but this is too trivial.

Quoted 5 lines

Unless it really bugs you when you're going through code, I don't think that cleanups at this level are necessary. Reading through commit history of some code via 'git blame' and seeing such cleanups is not welcome.

Got it. Thanks,

Quoted 4 lines

I have a patchet in testing that updates a few things around snapshot cleaning and this line will get fixed, so it'll not stay forever.
david