Skip to contentSkip to conversation

ARM: Orion5x: Fix too small coherent pool.

PATCH New Andrew Lunn 4 participants 7 messages Sep 24, 2012 – Sep 25, 2012

Subsystems (3)
Arm (32-bit) Arm sub-architectures Arm/Marvell Dove/MV78xx0/Orion SoC support
lore
Share & tools
lore

Andrew Lunn

author maintainer
#0 lore raw

PATCH 1/1 ARM: Orion5x: Fix too small coherent pool.

Some Orion5x devices allocate their coherent buffers from atomic context. Increase size of atomic coherent pool to make sure such the allocations won't fail during boot.

Signed-off-by Andrew Lunn <[email protected]>
---
 arch/arm/mach-orion5x/common.c |    7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/mach-orion5x/common.c +7 -0
index 410291c..a6cd14a 100644
@@ -204,6 +204,13 @@ void __init orion5x_wdt_init(void)
 void __init orion5x_init_early(void)
 {
 	orion_time_set_base(TIMER_VIRT_BASE);
+
+	/*
+	 * Some Orion5x devices allocate their coherent buffers from atomic
+	 * context. Increase size of atomic coherent pool to make sure such
+	 * the allocations won't fail.
+	 */
+	init_dma_coherent_pool_size(SZ_1M);
 }
 
 int orion5x_tclk;
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 ARM: Orion5x: Fix too small coherent pool.

Quoted 5 lines · Andrew Lunn

Some Orion5x devices allocate their coherent buffers from atomic context. Increase size of atomic coherent pool to make sure such the allocations won't fail during boot.

Signed-off-by Andrew Lunn <[email protected]>
Acked-by Jason Cooper <[email protected]>

btw - we should take this to it's logical conclusion and have Sebastian check Dove. Sebastian?

thx,

Jason.

Quoted 30 lines
---
 arch/arm/mach-orion5x/common.c |    7 +++++++
 1 file changed, 7 insertions(+)
arch/arm/mach-orion5x/common.c +7 -0
index 410291c..a6cd14a 100644
@@ -204,6 +204,13 @@ void __init orion5x_wdt_init(void)
 void __init orion5x_init_early(void)
 {
 	orion_time_set_base(TIMER_VIRT_BASE);
+
+	/*
+	 * Some Orion5x devices allocate their coherent buffers from atomic
+	 * context. Increase size of atomic coherent pool to make sure such
+	 * the allocations won't fail.
+	 */
+	init_dma_coherent_pool_size(SZ_1M);
 }
 
 int orion5x_tclk;
Signature · 7 lines
1.7.10.4


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
author maintainer
#2 lore raw

PATCH 1/1 ARM: Orion5x: Fix too small coherent pool.

Quoted 11 lines · Jason Cooper
Quoted 5 lines · Andrew Lunn

Some Orion5x devices allocate their coherent buffers from atomic context. Increase size of atomic coherent pool to make sure such the allocations won't fail during boot.

Signed-off-by Andrew Lunn <[email protected]>
Acked-by Jason Cooper <[email protected]>

btw - we should take this to it's logical conclusion and have Sebastian check Dove. Sebastian?

I did think about that. It probably hits if you have two sata devices. However, all current Dove machines have just one.

Andrew

maintainer
#3 lore raw

PATCH 1/1 ARM: Orion5x: Fix too small coherent pool.

Quoted 8 lines · Andrew Lunn
Quoted 7 lines · Jason Cooper
Quoted 5 lines · Andrew Lunn

Some Orion5x devices allocate their coherent buffers from atomic context. Increase size of atomic coherent pool to make sure such the allocations won't fail during boot.

Signed-off-by Andrew Lunn<[email protected]>
Quoted 7 lines
Quoted 4 lines
Acked-by Jason Cooper<[email protected]>

btw - we should take this to it's logical conclusion and have Sebastian check Dove. Sebastian?

I did think about that. It probably hits if you have two sata devices. However, all current Dove machines have just one.

Jason, Andrew,

I did boot arm-soc/for-next on Cubox and looks like 256k pool for atomic coherent allocations is enough. I booted with sata, sdhci0, eth0, i2c0, spi0, and both pcie ports forced on without any pcie devices attached.

Sebastian

#4 lore raw

PATCH 1/1 ARM: Orion5x: Fix too small coherent pool.

Quoted 14 lines · Sebastian Hesselbarth
Quoted 13 lines · Andrew Lunn
Quoted 11 lines · Jason Cooper
Quoted 5 lines · Andrew Lunn

Some Orion5x devices allocate their coherent buffers from atomic context. Increase size of atomic coherent pool to make sure such the allocations won't fail during boot.

Signed-off-by Andrew Lunn<[email protected]>
Acked-by Jason Cooper<[email protected]>

btw - we should take this to it's logical conclusion and have Sebastian check Dove. Sebastian?

Quoted 6 lines
Quoted 2 lines

I did think about that. It probably hits if you have two sata devices. However, all current Dove machines have just one.

I did boot arm-soc/for-next on Cubox and looks like 256k pool for atomic coherent allocations is enough. I booted with sata, sdhci0, eth0, i2c0, spi0, and both pcie ports forced on without any pcie devices attached.

Thanks for testing, Sebastian.

Andrew, I'll put this into a late/fixes branch for arm-soc and send it on up.

thx,

Jason.

#5 lore raw

PATCH 1/1 ARM: Orion5x: Fix too small coherent pool.

Quoted 18 lines · Jason Cooper
Quoted 17 lines · Sebastian Hesselbarth
Quoted 15 lines · Andrew Lunn
Quoted 11 lines · Jason Cooper
Quoted 5 lines · Andrew Lunn

Some Orion5x devices allocate their coherent buffers from atomic context. Increase size of atomic coherent pool to make sure such the allocations won't fail during boot.

Signed-off-by Andrew Lunn<[email protected]>
Acked-by Jason Cooper<[email protected]>

btw - we should take this to it's logical conclusion and have Sebastian check Dove. Sebastian?

I did think about that. It probably hits if you have two sata devices. However, all current Dove machines have just one.

Quoted 8 lines
Quoted 3 lines

I did boot arm-soc/for-next on Cubox and looks like 256k pool for atomic coherent allocations is enough. I booted with sata, sdhci0, eth0, i2c0, spi0, and both pcie ports forced on without any pcie devices attached.

Thanks for testing, Sebastian.

Andrew, I'll put this into a late/fixes branch for arm-soc and send it on up.

I can just apply it in fixes here with your ack and send it up for 3.6 tonight.

-Olof

#6 lore raw

PATCH 1/1 ARM: Orion5x: Fix too small coherent pool.

Quoted 23 lines · Olof Johansson
Quoted 22 lines · Jason Cooper
Quoted 20 lines · Sebastian Hesselbarth
Quoted 8 lines · Andrew Lunn
Quoted 7 lines · Jason Cooper
Quoted 5 lines · Andrew Lunn

Some Orion5x devices allocate their coherent buffers from atomic context. Increase size of atomic coherent pool to make sure such the allocations won't fail during boot.

Signed-off-by Andrew Lunn<[email protected]>
Quoted 7 lines
Quoted 4 lines
Acked-by Jason Cooper<[email protected]>

btw - we should take this to it's logical conclusion and have Sebastian check Dove. Sebastian?

I did think about that. It probably hits if you have two sata devices. However, all current Dove machines have just one.

I did boot arm-soc/for-next on Cubox and looks like 256k pool for atomic coherent allocations is enough. I booted with sata, sdhci0, eth0, i2c0, spi0, and both pcie ports forced on without any pcie devices attached.

Quoted 6 lines
Quoted 4 lines

Thanks for testing, Sebastian.

Andrew, I'll put this into a late/fixes branch for arm-soc and send it on up.

I can just apply it in fixes here with your ack and send it up for 3.6 tonight.

Oops, already sent the pull request. Which ever you prefer is fine with me. I just wanted another round of am, build, push, request-pull. ;-)

thx,

Jason.