arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

PATCH New yegorslists at googlemail.com 4 participants 4 messages Sep 25, 2012 Arm (32-bit)

lore

Share & tools

lore

yegorslists at googlemail.com

author

2012-09-25 08:26 UTC #0 lore raw

PATCH v2 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

From: Yegor Yefremov <[email protected]>

FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB of consistent DMA memory (da8xx frame buffer driver).

Signed-off-by Dejan Gacnik <[email protected]>

Signed-off-by Yegor Yefremov <[email protected]>

---
Changes:

	v2: fix SA1111 breakage

 arch/arm/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

arch/arm/Kconfig +2 -2

index 2f88d8d..b5f242e 100644
@@ -1766,8 +1766,8 @@ config HW_PERF_EVENTS
 source "mm/Kconfig"
 
 config FORCE_MAX_ZONEORDER
-	int "Maximum zone order" if ARCH_SHMOBILE
-	range 11 64 if ARCH_SHMOBILE
+	int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
+	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
 	default "9" if SA1111
 	default "11"
 	help

Signature · 1 line

1.7.7

Russell King - ARM Linux

2012-09-25 08:32 UTC #1 lore raw

PATCH v2 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 4 lines · yegorslists at googlemail.com

From: Yegor Yefremov <[email protected]>
FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB of consistent DMA memory (da8xx frame buffer driver).

Okay, so the patch description says "This needs to be 12 on this platform".

arch/arm/Kconfig config HW_PERF_EVENTS · line 1770

Quoted 5 lines

config FORCE_MAX_ZONEORDER

arch/arm/Kconfig +2 -2

-	int "Maximum zone order" if ARCH_SHMOBILE
-	range 11 64 if ARCH_SHMOBILE
+	int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
+	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX

but you leave it up to the user to select something that may not be suitable. Wouldn't _just_ adding:

	default "12" if SOC_AM33XX

after the "range", and making no other changes be good enough and match what the patch description says?

Yegor Yefremov

2012-09-25 08:46 UTC #2 lore raw

PATCH v2 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 17 lines · Russell King - ARM Linux

Quoted 4 lines · yegorslists at googlemail.com
From: Yegor Yefremov <[email protected]>
FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB of consistent DMA memory (da8xx frame buffer driver).
Okay, so the patch description says "This needs to be 12 on this platform".
arch/arm/Kconfig config HW_PERF_EVENTS · line 1770
Quoted 5 lines
config FORCE_MAX_ZONEORDER
arch/arm/Kconfig +2 -2
-	int "Maximum zone order" if ARCH_SHMOBILE
-	range 11 64 if ARCH_SHMOBILE
+	int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
+	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
but you leave it up to the user to select something that may not be suitable. Wouldn't _just_ adding:

Quoted 4 lines

	default "12" if SOC_AM33XX
after the "range", and making no other changes be good enough and match what the patch description says?

You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you?

Patch sent.

Yegor

Tony Lindgren

2012-09-25 15:27 UTC #3 lore raw

PATCH v2 1/1 arm: make FORCE_MAX_ZONEORDER configurable for TI AM33XX

Quoted 18 lines · Yegor Yefremov

Quoted 17 lines · Russell King - ARM Linux
Quoted 4 lines · yegorslists at googlemail.com
From: Yegor Yefremov <[email protected]>
FORCE_MAX_ZONEORDER of 12 is needed to allocation more than 4MB of consistent DMA memory (da8xx frame buffer driver).
Okay, so the patch description says "This needs to be 12 on this platform".
arch/arm/Kconfig config HW_PERF_EVENTS · line 1770
Quoted 5 lines
config FORCE_MAX_ZONEORDER
arch/arm/Kconfig +2 -2
-	int "Maximum zone order" if ARCH_SHMOBILE
-	range 11 64 if ARCH_SHMOBILE
+	int "Maximum zone order" if ARCH_SHMOBILE || SOC_AM33XX
+	range 11 64 if ARCH_SHMOBILE || SOC_AM33XX
but you leave it up to the user to select something that may not be suitable. Wouldn't _just_ adding:

Quoted 6 lines

Quoted 4 lines
	default "12" if SOC_AM33XX
after the "range", and making no other changes be good enough and match what the patch description says?
You're right. As we don't allocate anything, but increase the possible size, it shouldn't break anything. Tony is it O.K. with you?

Sure.

Tony