[PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

Haicheng Li

author

2012-09-24 07:20 UTC #0 lore raw

PATCH 1/2 Fix build error caused by broken PCH_PTP module dependency.

From 1b4ae11bacfd2eedda1fd0e1ce1d37b678e2f009 Mon Sep 17 00:00:00 2001
From: Haicheng Li <[email protected]>
Date: Mon, 24 Sep 2012 15:01:33 +0800
Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

The .config is:

        CONFIG_PCH_GBE=y
        CONFIG_PCH_PTP=y
        CONFIG_PTP_1588_CLOCK=m

The build error:

drivers/built-in.o: In function `pch_tx_timestamp':
.../pch_gbe_main.c:215: undefined reference to pch_ch_event_read' .../pch_gbe_main.c:225: undefined reference to pch_tx_snap_read' .../pch_gbe_main.c:231: undefined reference to `pch_ch_event_write'

.../pch_gbe_main.c:170: undefined reference to pch_ch_event_read' .../pch_gbe_main.c:175: undefined reference to pch_src_uuid_lo_read' .../pch_gbe_main.c:176: undefined reference to pch_src_uuid_hi_read' .../pch_gbe_main.c:190: undefined reference to pch_ch_event_write' .../pch_gbe_main.c:184: undefined reference to `pch_rx_snap_read'

.../pch_gbe_main.c:267: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:271: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:275: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:281: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:283: undefined reference to pch_set_station_address' .../pch_gbe_main.c:290: undefined reference to pch_ch_event_write'

Signed-off-by Haicheng Li <[email protected]>

---
 drivers/net/ethernet/oki-semi/pch_gbe/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/ethernet/oki-semi/pch_gbe/Kconfig +1 -1

index bce0164..9feaf3f 100644
@@ -26,7 +26,7 @@ if PCH_GBE
 config PCH_PTP
 	bool "PCH PTP clock support"
 	default n
-	depends on PTP_1588_CLOCK_PCH
+	depends on PTP_1588_CLOCK_PCH = y
 	---help---
 	  Say Y here if you want to use Precision Time Protocol (PTP) in the
 	  driver. PTP is a method to precisely synchronize distributed clocks

Signature · 1 line

1.7.1

Haicheng Li

author

2012-09-24 08:08 UTC #1 lore raw

PATCH 1/2 Fix build error caused by broken PCH_PTP module dependency.

this version would be more clean:

From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001
From: Haicheng Li <[email protected]>
Date: Mon, 24 Sep 2012 15:52:30 +0800
Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

The .config is:

        CONFIG_PCH_GBE=y
        CONFIG_PCH_PTP=y
        CONFIG_PTP_1588_CLOCK=m

The build error:

drivers/built-in.o: In function `pch_tx_timestamp':
.../pch_gbe_main.c:215: undefined reference to pch_ch_event_read' .../pch_gbe_main.c:225: undefined reference to pch_tx_snap_read' .../pch_gbe_main.c:231: undefined reference to `pch_ch_event_write'

.../pch_gbe_main.c:170: undefined reference to pch_ch_event_read' .../pch_gbe_main.c:175: undefined reference to pch_src_uuid_lo_read' .../pch_gbe_main.c:176: undefined reference to pch_src_uuid_hi_read' .../pch_gbe_main.c:190: undefined reference to pch_ch_event_write' .../pch_gbe_main.c:184: undefined reference to `pch_rx_snap_read'

.../pch_gbe_main.c:267: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:271: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:275: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:281: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:283: undefined reference to pch_set_station_address' .../pch_gbe_main.c:290: undefined reference to pch_ch_event_write'

Signed-off-by Haicheng Li <[email protected]>

---
 drivers/net/ethernet/oki-semi/pch_gbe/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/ethernet/oki-semi/pch_gbe/Kconfig +1 -1

index bce0164..6c8aed4 100644
@@ -26,7 +26,7 @@ if PCH_GBE
 config PCH_PTP
 	bool "PCH PTP clock support"
 	default n
-	depends on PTP_1588_CLOCK_PCH
+	depends on PTP_1588_CLOCK_PCH = PCH_GBE
 	---help---
 	  Say Y here if you want to use Precision Time Protocol (PTP) in the
 	  driver. PTP is a method to precisely synchronize distributed clocks

Signature · 1 line

1.7.1

Haicheng Li

author

2012-09-25 00:23 UTC #2 lore raw

PATCH 1/2 Fix build error caused by broken PCH_PTP module dependency.

In reply to Haicheng Li

From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001
From: Haicheng Li <[email protected]>
Date: Mon, 24 Sep 2012 15:52:30 +0800
Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

The .config is:

        CONFIG_PCH_GBE=y
        CONFIG_PCH_PTP=y
        CONFIG_PTP_1588_CLOCK=m

The build error:

drivers/built-in.o: In function `pch_tx_timestamp':
.../pch_gbe_main.c:215: undefined reference to pch_ch_event_read' .../pch_gbe_main.c:225: undefined reference to pch_tx_snap_read' .../pch_gbe_main.c:231: undefined reference to `pch_ch_event_write'

.../pch_gbe_main.c:170: undefined reference to pch_ch_event_read' .../pch_gbe_main.c:175: undefined reference to pch_src_uuid_lo_read' .../pch_gbe_main.c:176: undefined reference to pch_src_uuid_hi_read' .../pch_gbe_main.c:190: undefined reference to pch_ch_event_write' .../pch_gbe_main.c:184: undefined reference to `pch_rx_snap_read'

.../pch_gbe_main.c:267: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:271: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:275: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:281: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:283: undefined reference to pch_set_station_address' .../pch_gbe_main.c:290: undefined reference to pch_ch_event_write'

Signed-off-by Haicheng Li <[email protected]>

---
 drivers/net/ethernet/oki-semi/pch_gbe/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/net/ethernet/oki-semi/pch_gbe/Kconfig +1 -1

index bce0164..6c8aed4 100644
@@ -26,7 +26,7 @@ if PCH_GBE
 config PCH_PTP
 	bool "PCH PTP clock support"
 	default n
-	depends on PTP_1588_CLOCK_PCH
+	depends on PTP_1588_CLOCK_PCH = PCH_GBE
 	---help---
 	  Say Y here if you want to use Precision Time Protocol (PTP) in the
 	  driver. PTP is a method to precisely synchronize distributed clocks

Signature · 1 line

1.7.1

David Miller

maintainer

2012-09-27 22:09 UTC #3 lore raw

From: Haicheng Li <[email protected]>
Date: Tue, 25 Sep 2012 08:23:27 +0800

Quoted 6 lines

From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001
From: Haicheng Li <[email protected]>
Date: Mon, 24 Sep 2012 15:52:30 +0800
Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

Quoted 6 lines

The .config is:

        CONFIG_PCH_GBE=y
        CONFIG_PCH_PTP=y
        CONFIG_PTP_1588_CLOCK=m

The build error:

Your patch submissions are of a very low quality.

And the main reason is that you microscopically look at problems and do not investigate how the same thing might be handled elsewhere.

Therefore you will never become accustomed to the proper way problems are fixed, and the proper way to submit patches.

Look at how other people submit patches, do any other patch submissions look like your's having all of this metadata in the message body:

Quoted 5 lines

From 898e3214b3406c620571cedf704719784b0df049 Mon Sep 17 00:00:00 2001
From: Haicheng Li <[email protected]>
Date: Mon, 24 Sep 2012 15:52:30 +0800
Subject: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.

No, nobody else does this.

As for this specific patch:

drivers/net/ethernet/oki-semi/pch_gbe/Kconfig if PCH_GBE · line 29

Quoted 2 lines

drivers/net/ethernet/oki-semi/pch_gbe/Kconfig +1 -1
-	depends on PTP_1588_CLOCK_PCH
+	depends on PTP_1588_CLOCK_PCH = PCH_GBE

This is not the correct way to ensure that the module'ness of one config option meets the module'ness requirements of another.

The correct way is to say something like "&& (PCH_GBE || PCH_GBE=n)"

Haicheng Li

author

2012-09-28 06:41 UTC #4 lore raw

Quoted 2 lines · David Miller

Look at how other people submit patches, do any other patch submissions look like your's having all of this metadata in the message body:

I'm sorry for it.

Quoted 8 lines

As for this specific patch:
Review
Quoted 2 lines
(quoted diff) +1 -1
-	depends on PTP_1588_CLOCK_PCH
+	depends on PTP_1588_CLOCK_PCH = PCH_GBE
This is not the correct way to ensure that the module'ness of one config option meets the module'ness requirements of another. The correct way is to say something like "&& (PCH_GBE || PCH_GBE=n)"

This case is a little bit tricky than usual, with PCH_PTP selected, the valid config would be either "PTP_1588_CLOCK_PCH=PCH_GBE=m" or "PTP_1588_CLOCK_PCH=PCH_GBE=y", and PTP_1588_CLOCK_PCH depends on PCH_GBE.

So are you ok with this:
+ depends on PTP_1588_CLOCK_PCH && (PCH_GBE=m || PTP_1588_CLOCK_PCH=y)

or simply like:
---
From: Haicheng Li <[email protected]>

Fix build error caused by broken PCH_PTP module dependency. The .config is:

        CONFIG_PCH_GBE=y
        CONFIG_PCH_PTP=y
        CONFIG_PTP_1588_CLOCK=m

The build error:

drivers/built-in.o: In function `pch_tx_timestamp':
.../pch_gbe_main.c:215: undefined reference to pch_ch_event_read' .../pch_gbe_main.c:225: undefined reference to pch_tx_snap_read' .../pch_gbe_main.c:231: undefined reference to `pch_ch_event_write'

.../pch_gbe_main.c:170: undefined reference to pch_ch_event_read' .../pch_gbe_main.c:175: undefined reference to pch_src_uuid_lo_read' .../pch_gbe_main.c:176: undefined reference to pch_src_uuid_hi_read' .../pch_gbe_main.c:190: undefined reference to pch_ch_event_write' .../pch_gbe_main.c:184: undefined reference to `pch_rx_snap_read'

.../pch_gbe_main.c:267: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:271: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:275: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:281: undefined reference to pch_ch_control_write' .../pch_gbe_main.c:283: undefined reference to pch_set_station_address' .../pch_gbe_main.c:290: undefined reference to pch_ch_event_write'

Signed-off-by Haicheng Li <[email protected]>

---
 drivers/net/ethernet/oki-semi/pch_gbe/Kconfig |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

drivers/net/ethernet/oki-semi/pch_gbe/Kconfig +2 -2

index bce0164..df1e649 100644
@@ -21,12 +21,12 @@ config PCH_GBE
 	  ML7223/ML7831 is companion chip for Intel Atom E6xx series.
 	  ML7223/ML7831 is completely compatible for Intel EG20T PCH.
 
-if PCH_GBE
+if PTP_1588_CLOCK_PCH
 
 config PCH_PTP
 	bool "PCH PTP clock support"
 	default n
-	depends on PTP_1588_CLOCK_PCH
+	depends on PTP_1588_CLOCK_PCH=y || PCH_GBE=m
 	---help---
 	  Say Y here if you want to use Precision Time Protocol (PTP) in the
 	  driver. PTP is a method to precisely synchronize distributed clocks

Signature · 5 lines

1.7.1



-haicheng

David Miller

maintainer

2012-09-28 06:46 UTC #5 lore raw

From: Haicheng Li <[email protected]>
Date: Fri, 28 Sep 2012 14:41:43 +0800

Quoted 15 lines · David Miller

Quoted 3 lines
Look at how other people submit patches, do any other patch submissions
look like your's having all of this metadata in the message body:
I'm sorry for it.
Quoted 8 lines
As for this specific patch:
Review
Quoted 2 lines
(quoted diff) +1 -1
-	depends on PTP_1588_CLOCK_PCH
+	depends on PTP_1588_CLOCK_PCH = PCH_GBE
This is not the correct way to ensure that the module'ness of one config option meets the module'ness requirements of another. The correct way is to say something like "&& (PCH_GBE || PCH_GBE=n)"

Quoted 4 lines

This case is a little bit tricky than usual, with PCH_PTP selected, the valid config would be either "PTP_1588_CLOCK_PCH=PCH_GBE=m" or "PTP_1588_CLOCK_PCH=PCH_GBE=y", and PTP_1588_CLOCK_PCH depends on PCH_GBE.

And a simple "&& PCH_GBE" should accomplish this, no?

Haicheng Li

author

2012-09-28 06:57 UTC #6 lore raw

Quoted 18 lines · David Miller

From: Haicheng Li<[email protected]>
Date: Fri, 28 Sep 2012 14:41:43 +0800
Quoted 15 lines · David Miller
Quoted 3 lines
Look at how other people submit patches, do any other patch submissions
look like your's having all of this metadata in the message body:
I'm sorry for it.
Quoted 8 lines
As for this specific patch:
Review
Quoted 2 lines
(quoted diff) +1 -1
-	depends on PTP_1588_CLOCK_PCH
+	depends on PTP_1588_CLOCK_PCH = PCH_GBE
This is not the correct way to ensure that the module'ness of one config option meets the module'ness requirements of another.
The correct way is to say something like "&& (PCH_GBE || PCH_GBE=n)"

Quoted 6 lines

Quoted 4 lines
This case is a little bit tricky than usual, with PCH_PTP selected, the valid config would be either "PTP_1588_CLOCK_PCH=PCH_GBE=m" or "PTP_1588_CLOCK_PCH=PCH_GBE=y", and PTP_1588_CLOCK_PCH depends on PCH_GBE.
And a simple "&& PCH_GBE" should accomplish this, no?

No sir. it's actually same with the original Kconfig (by a if PCH_GBE"), it just failed with this config:

        CONFIG_PCH_GBE=y
        CONFIG_PCH_PTP=y
        CONFIG_PTP_1588_CLOCK=m

-haicheng

David Miller

maintainer

2012-10-03 02:23 UTC #7 lore raw

From: Haicheng Li <[email protected]>
Date: Fri, 28 Sep 2012 14:57:38 +0800

Quoted 24 lines · David Miller

Quoted 23 lines
From: Haicheng Li<[email protected]>
Date: Fri, 28 Sep 2012 14:41:43 +0800
Quoted 19 lines · David Miller
Quoted 3 lines
Look at how other people submit patches, do any other patch submissions
look like your's having all of this metadata in the message body:
I'm sorry for it.
Quoted 8 lines
As for this specific patch:
Review
Quoted 2 lines
(quoted diff) +1 -1
-	depends on PTP_1588_CLOCK_PCH
+	depends on PTP_1588_CLOCK_PCH = PCH_GBE
This is not the correct way to ensure that the module'ness of one config option meets the module'ness requirements of another.
The correct way is to say something like "&& (PCH_GBE || PCH_GBE=n)"
This case is a little bit tricky than usual, with PCH_PTP selected, the valid config would be either "PTP_1588_CLOCK_PCH=PCH_GBE=m" or "PTP_1588_CLOCK_PCH=PCH_GBE=y", and PTP_1588_CLOCK_PCH depends on PCH_GBE.

Quoted 7 lines

Quoted 1 line
And a simple "&& PCH_GBE" should accomplish this, no?
No sir. it's actually same with the original Kconfig (by a if PCH_GBE"), it just failed with this config:
        CONFIG_PCH_GBE=y
        CONFIG_PCH_PTP=y
        CONFIG_PTP_1588_CLOCK=m

The correct fix is to make the Kconfig entry for PCH_PTP use a "select PTP_1588_CLOCK" instead of "depends PTP_1588_CLOCK"

I'll apply this fix.

The is another, extremely convoluted, way to do this, which is what the SFC driver does which is:

depends on SFC && PTP_1588_CLOCK && !(SFC=y && PTP_1588_CLOCK=m)

but that looks horrible to me.

Ben Hutchings

2012-10-03 21:45 UTC #8 lore raw

Quoted 38 lines · David Miller

From: Haicheng Li <[email protected]>
Date: Fri, 28 Sep 2012 14:57:38 +0800
Quoted 24 lines · David Miller
Quoted 23 lines
From: Haicheng Li<[email protected]>
Date: Fri, 28 Sep 2012 14:41:43 +0800
Quoted 19 lines · David Miller
Quoted 3 lines
Look at how other people submit patches, do any other patch submissions
look like your's having all of this metadata in the message body:
I'm sorry for it.
Quoted 8 lines
As for this specific patch:
Review
Quoted 2 lines
(quoted diff) +1 -1
-	depends on PTP_1588_CLOCK_PCH
+	depends on PTP_1588_CLOCK_PCH = PCH_GBE
This is not the correct way to ensure that the module'ness of one config option meets the module'ness requirements of another.
The correct way is to say something like "&& (PCH_GBE || PCH_GBE=n)"
This case is a little bit tricky than usual, with PCH_PTP selected, the valid config would be either "PTP_1588_CLOCK_PCH=PCH_GBE=m" or "PTP_1588_CLOCK_PCH=PCH_GBE=y", and PTP_1588_CLOCK_PCH depends on PCH_GBE.
Quoted 7 lines
Quoted 1 line
And a simple "&& PCH_GBE" should accomplish this, no?
No sir. it's actually same with the original Kconfig (by a if PCH_GBE"), it just failed with this config:
        CONFIG_PCH_GBE=y
        CONFIG_PCH_PTP=y
        CONFIG_PTP_1588_CLOCK=m
The correct fix is to make the Kconfig entry for PCH_PTP use a "select PTP_1588_CLOCK" instead of "depends PTP_1588_CLOCK"

Quoted 8 lines

I'll apply this fix.
The is another, extremely convoluted, way to do this, which is what the SFC driver does which is:
depends on SFC && PTP_1588_CLOCK && !(SFC=y && PTP_1588_CLOCK=m)
but that looks horrible to me.

I thought of it as being a peripheral feature (which most Solarflare hardware doesn't implement) so it made sense for SFC_PTP to be optional like SFC_MTD and so on. But I'm quite happy to use a select instead, if you want that to be the convention for all drivers implementing PHC.

Ben.

Signature · 3 lines

Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

David Miller

maintainer

2012-10-04 00:43 UTC #9 lore raw

From: Ben Hutchings <[email protected]>
Date: Wed, 3 Oct 2012 22:45:10 +0100

Quoted 4 lines

I thought of it as being a peripheral feature (which most Solarflare hardware doesn't implement) so it made sense for SFC_PTP to be optional like SFC_MTD and so on. But I'm quite happy to use a select instead, if you want that to be the convention for all drivers implementing PHC.

I think that consistency might trump those conerns you mentioned, at least in this case.

Ben Hutchings

2012-10-16 20:09 UTC #10 lore raw

Quoted 10 lines · David Miller

From: Ben Hutchings <[email protected]>
Date: Wed, 3 Oct 2012 22:45:10 +0100
Quoted 4 lines
I thought of it as being a peripheral feature (which most Solarflare hardware doesn't implement) so it made sense for SFC_PTP to be optional like SFC_MTD and so on. But I'm quite happy to use a select instead, if you want that to be the convention for all drivers implementing PHC.
I think that consistency might trump those conerns you mentioned, at least in this case.

Currently such kconfig options look like, for example:

config IGB_PTP
bool "PTP Hardware Clock (PHC)"
default n
depends on IGB && EXPERIMENTAL
select PPS
select PTP_1588_CLOCK
---help---
Say Y here if you want to use PTP Hardware Clock (PHC) in the driver. Only the basic clock operations have been implemented.

Every timestamp and clock read operations must consult the overflow counter to form a correct time value.

There are a number of problems with this:

1. PTP_1588_CLOCK depends on PPS, so this has to select it as well.
2. PPS and PTP_1588_CLOCK depend on EXPERIMENTAL, so this has to as well.
3. It's a boolean, so whatever it selects is built-in, even though the driver it relates to may be a module.

I think the various kconfig options should be changed as follows:

1. Only PTP_1588_CLOCK selects PPS.
2. Nothing depends on EXPERIMENTAL. (This stuff has been in for 18 months and it's even being backported to RHEL 6 now.)
3. Either:
(a) The per-driver PHC options select nothing, and the driver options do e.g.:
select PTP_1588_CLOCK if IGB_PTP
(b) The per-driver PHC options are removed and the driver options do:

	select PTP_1588_CLOCK
       (i.e. PHC support is unconditional)

Any objections to this, or preference for (a) vs (b)?

Ben.

Signature · 3 lines

Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

David Miller

maintainer

2012-10-16 20:17 UTC #11 lore raw

From: Ben Hutchings <[email protected]>
Date: Tue, 16 Oct 2012 21:09:27 +0100

Quoted 10 lines

I think the various kconfig options should be changed as follows:
1. Only PTP_1588_CLOCK selects PPS.
2. Nothing depends on EXPERIMENTAL. (This stuff has been in for 18 months and it's even being backported to RHEL 6 now.)
3. Either:
(a) The per-driver PHC options select nothing, and the driver options do e.g.:
select PTP_1588_CLOCK if IGB_PTP
(b) The per-driver PHC options are removed and the driver options do:

Quoted 4 lines

	select PTP_1588_CLOCK
       (i.e. PHC support is unconditional)
Any objections to this, or preference for (a) vs (b)?

No objections, prefer (b).

Keller, Jacob E

2012-10-16 21:08 UTC #12 lore raw

Quoted 27 lines

-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of David Miller
Sent: Tuesday, October 16, 2012 1:17 PM
To: [email protected]
Cc: [email protected]; [email protected]; [email protected]; [email protected]; linux- [email protected]; [email protected]
Subject: Re: [PATCH 1/2] Fix build error caused by broken PCH_PTP module dependency.
From: Ben Hutchings <[email protected]>
Date: Tue, 16 Oct 2012 21:09:27 +0100
Quoted 13 lines
I think the various kconfig options should be changed as follows:
1. Only PTP_1588_CLOCK selects PPS.
2. Nothing depends on EXPERIMENTAL. (This stuff has been in for 18 months and it's even being backported to RHEL 6 now.)
3. Either:
(a) The per-driver PHC options select nothing, and the driver options do e.g.:
select PTP_1588_CLOCK if IGB_PTP
(b) The per-driver PHC options are removed and the driver options do:
	select PTP_1588_CLOCK
       (i.e. PHC support is unconditional)

Quoted 3 lines

Quoted 1 line
Any objections to this, or preference for (a) vs (b)?
No objections, prefer (b).

No objections here, I also prefer (b). The feature shouldn't have much impact unless enabled via hwtstamp_ioctl, and it drastically reduces requirement on end-user needing to enable PHC support.

- Jake

Quoted 4 lines

--
To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

David Miller

maintainer

2012-09-24 17:46 UTC #13 lore raw

In reply to Haicheng Li

Please post all networking patches to [email protected]

Thank you.

Haicheng Li

author

2012-09-24 07:22 UTC #14 lore raw

PATCH 2/2 Fix wrong description in PTP_1588_CLOCK_PCH help info.

In reply to Haicheng Li

From a206a006d82c327ba308674c608fbd6c9ce1e702 Mon Sep 17 00:00:00 2001
From: Haicheng Li <[email protected]>
Date: Mon, 24 Sep 2012 15:02:41 +0800
Subject: [PATCH 2/2] Fix wrong description in PTP_1588_CLOCK_PCH help info.

Signed-off-by Haicheng Li <[email protected]>

---
 drivers/ptp/Kconfig |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

drivers/ptp/Kconfig +1 -2

index ffdf712..988786d 100644
@@ -86,7 +86,6 @@ config PTP_1588_CLOCK_PCH
 	  hardware time stamps on the PTP Ethernet packets using the
 	  SO_TIMESTAMPING API.
 
-	  To compile this driver as a module, choose M here: the module
-	  will be called ptp_pch.
+	  Choose Y here if you want to enable PCH PTP clock support.
 
 endmenu

Signature · 1 line

1.7.1

Haicheng Li

author

2012-09-24 08:14 UTC #15 lore raw

PATCH 2/2 Fix a typo in PTP_1588_CLOCK_PCH Kconfig help info.

pls. ignore original one, and use this instead:

From 5911413366d37aafcc19ddfc9c0f2db31855431e Mon Sep 17 00:00:00 2001
From: Haicheng Li <[email protected]>
Date: Mon, 24 Sep 2012 15:55:27 +0800
Subject: [PATCH 2/2] Fix a typo in PTP_1588_CLOCK_PCH Kconfig help info.

Signed-off-by Haicheng Li <[email protected]>

---
 drivers/ptp/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/ptp/Kconfig +1 -1

index ffdf712..82c4a26 100644
@@ -87,6 +87,6 @@ config PTP_1588_CLOCK_PCH
 	  SO_TIMESTAMPING API.
 
 	  To compile this driver as a module, choose M here: the module
-	  will be called ptp_pch.
+	  will be called by pch_ptp.
 
 endmenu

Signature · 1 line

1.7.1

Haicheng Li

author

2012-09-25 00:24 UTC #16 lore raw

PATCH 2/2 Fix a typo in PTP_1588_CLOCK_PCH Kconfig help info.

In reply to Haicheng Li

From 5911413366d37aafcc19ddfc9c0f2db31855431e Mon Sep 17 00:00:00 2001
From: Haicheng Li <[email protected]>
Date: Mon, 24 Sep 2012 15:55:27 +0800
Subject: [PATCH 2/2] Fix a typo in PTP_1588_CLOCK_PCH Kconfig help info.

Signed-off-by Haicheng Li <[email protected]>

---
 drivers/ptp/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

drivers/ptp/Kconfig +1 -1

index ffdf712..82c4a26 100644
@@ -87,6 +87,6 @@ config PTP_1588_CLOCK_PCH
 	  SO_TIMESTAMPING API.
 
 	  To compile this driver as a module, choose M here: the module
-	  will be called ptp_pch.
+	  will be called by pch_ptp.
 
 endmenu

Signature · 1 line

1.7.1

David Miller

maintainer

2012-09-27 22:06 UTC #17 lore raw

Re: [PATCH 2/2] Fix a typo in PTP_1588_CLOCK_PCH Kconfig help info.

From: Haicheng Li <[email protected]>
Date: Tue, 25 Sep 2012 08:24:36 +0800

Quoted 16 lines

From 5911413366d37aafcc19ddfc9c0f2db31855431e Mon Sep 17 00:00:00 2001
From: Haicheng Li <[email protected]>
Date: Mon, 24 Sep 2012 15:55:27 +0800
Subject: [PATCH 2/2] Fix a typo in PTP_1588_CLOCK_PCH Kconfig help info.
Signed-off-by Haicheng Li <[email protected]>
---
 drivers/ptp/Kconfig |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/ptp/Kconfig +0 -0
index ffdf712..82c4a26 100644

drivers/ptp/Kconfig config PTP_1588_CLOCK_PCH · line 90

Quoted 5 lines

drivers/ptp/Kconfig +1 -1

@@ -87,6 +87,6 @@ config PTP_1588_CLOCK_PCH
 	  SO_TIMESTAMPING API.
 
 	  To compile this driver as a module, choose M here: the module
-	  will be called ptp_pch.
+	  will be called by pch_ptp.

The original sentence is correct, it is stating the name of the module that will be built not the module that will call it.

Rather, the "pch_ptp" is what might need to be adjusted.

Haicheng Li

author

2012-09-28 06:44 UTC #18 lore raw

Re: [PATCH 2/2] Fix a typo in PTP_1588_CLOCK_PCH Kconfig help info.

Quoted 5 lines · David Miller

drivers/ptp/Kconfig config PTP_1588_CLOCK_PCH · line 90
Quoted 2 lines
drivers/ptp/Kconfig +1 -1
-	  will be called ptp_pch.
+	  will be called by pch_ptp.
The original sentence is correct, it is stating the name of the module that will be built not the module that will call it.

You're right.

Quoted 1 line

Rather, the "pch_ptp" is what might need to be adjusted.

No need, the output is ptp_pch.ko.

So pls. ignore this patch. sorry for the bothering.

-haicheng