Skip to contentSkip to conversation

use portable printf instead of echo -e, needed for MacOS X buildhost

PATCH New Waldemar Brodkorb 3 participants 3 messages Sep 20, 2012 – Oct 6, 2012 VFS

lore
Share & tools
lore

Waldemar Brodkorb

author
#0 lore raw

PATCH 1/1 use portable printf instead of echo -e, needed for MacOS X buildhost

Hi,

echo -e is not a portable way to do this, better use printf. Works with MacOS X.

Signed-off-by Waldemar Brodkorb <[email protected]>
---
 fs/common.mk | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
fs/common.mk +2 -2
index debf7db..0f0eae9 100644
@@ -49,9 +49,9 @@ $(BINARIES_DIR)/rootfs.$(1): $(ROOTFS_$(2)_DEPENDENCIES)
 ifneq ($(ROOTFS_DEVICE_TABLES),)
 	cat $(ROOTFS_DEVICE_TABLES) > $(FULL_DEVICE_TABLE)
 ifeq ($(BR2_ROOTFS_DEVICE_CREATION_STATIC),y)
-	echo -e '$(subst $(sep),\n,$(PACKAGES_DEVICES_TABLE))' >> $(FULL_DEVICE_TABLE)
+	printf '$(subst $(sep),\n,$(PACKAGES_DEVICES_TABLE))' >> $(FULL_DEVICE_TABLE)
 endif
-	echo -e '$(subst $(sep),\n,$(PACKAGES_PERMISSIONS_TABLE))' >> $(FULL_DEVICE_TABLE)
+	printf '$(subst $(sep),\n,$(PACKAGES_PERMISSIONS_TABLE))' >> $(FULL_DEVICE_TABLE)
 	echo "$(HOST_DIR)/usr/bin/makedevs -d $(FULL_DEVICE_TABLE) $(TARGET_DIR)" >> $(FAKEROOT_SCRIPT)
 endif
 	echo "$(ROOTFS_$(2)_CMD)" >> $(FAKEROOT_SCRIPT)
Signature · 1 line
1.7.11.1
#1 lore raw

PATCH 1/1 use portable printf instead of echo -e, needed for MacOS X buildhost

Quoted 6 lines · Waldemar Brodkorb

Hi,

echo -e is not a portable way to do this, better use printf. Works with MacOS X.

Signed-off-by Waldemar Brodkorb<[email protected]>
Acked-by Arnout Vandecappelle (Essensium/Mind) <[email protected]>
Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
#2 lore raw

PATCH 1/1 use portable printf instead of echo -e, needed for MacOS X buildhost

In reply to Waldemar Brodkorb
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Waldemar" == Waldemar Brodkorb <[email protected]> writes:

Waldemar> Hi,
Waldemar> echo -e is not a portable way to do this, better use printf. Waldemar> Works with MacOS X.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard