Skip to contentSkip to conversation

refresh patch used to sync with upstream, suggested by Thomas Petazzoni

PATCH New Waldemar Brodkorb 2 participants 2 messages Sep 20, 2012 – Sep 30, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 refresh patch used to sync with upstream, suggested by Thomas Petazzoni

Hi,

update patch used to sync with upstream kconfig.

---
 support/kconfig/patches/11-use-mktemp-for-lxdialog.patch | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
support/kconfig/patches/11-use-mktemp-for-lxdialog.patch +1 -1
index 21ca228..7a731c1 100644
@@ -11,7 +11,7 @@ Index: config/lxdialog/check-lxdialog.sh
  
  # Temp file, try to clean up after us
 -tmp=.lxdialog.tmp
-+tmp=$(mktemp)
++tmp=$(mktemp -t yyy)
  trap "rm -f $tmp" 0 1 2 3 15
  
  # Check if we can link to ncurses
Signature · 1 line
1.7.11.1
#1 lore raw

PATCH 1/1 refresh patch used to sync with upstream, suggested by Thomas Petazzoni

Quoted 5 lines · Waldemar Brodkorb

Hi,

update patch used to sync with upstream kconfig.

This text (and the subject line) will be part of the commit message in
git - obviously it's not a very good commit message. If you want to include some message for the mailing list in the commit message, it should be below ---. For instance, the following could be a good commit message:

Use a more portable syntax of mktemp.

mktemp on MacOS doesn't have a default template, so a template has to be given explicitly.

---
Refresh patch to sync with upstream kconfig, as suggested by Thomas Petazzoni

Quoted 9 lines
---
  support/kconfig/patches/11-use-mktemp-for-lxdialog.patch | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
support/kconfig/patches/11-use-mktemp-for-lxdialog.patch +0 -0
index 21ca228..7a731c1 100644

support/kconfig/patches/11-use-mktemp-for-lxdialog.patch Index: config/lxdialog/check-lxdialog.sh · line 14

Quoted 5 lines
support/kconfig/patches/11-use-mktemp-for-lxdialog.patch +1 -1
@@ -11,7 +11,7 @@ Index: config/lxdialog/check-lxdialog.sh
 
   # Temp file, try to clean up after us
  -tmp=.lxdialog.tmp
-+tmp=$(mktemp)
++tmp=$(mktemp -t yyy)

GNU mktemp marks the -t option as deprecated, so it's still not portable :-)
Also, 'yyy' is not a very descriptive name. So I'd propose to use:

mktemp ${TMPDIR}/lxdialog.XXXXXXXX

Regards,
Arnout

Quoted 3 lines
support/kconfig/patches/11-use-mktemp-for-lxdialog.patch +0 -0
   trap "rm -f $tmp" 0 1 2 3 15
 
   # Check if we can link to ncurses
Signature · 6 lines
Arnout Vandecappelle                               arnout at mind be
Senior Embedded Software Architect                 +32-16-286540
Essensium/Mind                                     http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium                BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F