ath/ath9k/ar9003_eeprom.c: Remove semicolon after if

PATCH walter harms 1 participant 1 message Oct 1, 2012 Kernel janitors

lore

Share & tools

lore

walter harms

author

2012-10-01 07:13 UTC #0 lore raw

Am 30.09.2012 22:56, schrieb Peter Senna Tschudin:

Quoted 33 lines

The semantic patch that finds this problem is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@r1@
position p;
@@
if (...);@p
@script:python@
p0 << r1.p;
@@
// Emacs org-mode output
cocci.print_main("", p0)
cocci.print_secs("", p0)
// </smpl>
Signed-off-by Peter Senna Tschudin <[email protected]>
---
NOTE: This patch changes the semantics.
Changes from V1:
Commit message
Added a note about semantics change
 drivers/net/wireless/ath/ath9k/ar9003_eeprom.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/ath/ath9k/ar9003_eeprom.c +0 -0
index 5bbe505..189aeb2 100644

drivers/net/wireless/ath/ath9k/ar9003_eeprom.c static u32 ath9k_hw_ar9300_get_eeprom(struct ath_hw *ah, · line 2995

Quoted 8 lines

drivers/net/wireless/ath/ath9k/ar9003_eeprom.c +1 -1

@@ -2989,7 +2989,7 @@ static u32 ath9k_hw_ar9300_get_eeprom(struct ath_hw *ah,
 	case EEP_PAPRD:
 		if (AR_SREV_9462(ah))
 			return false;
-		if (!ah->config.enable_paprd);
+		if (!ah->config.enable_paprd)
 			return false;
 		return !!(pBase->featureEnable & BIT(5));
 	case EEP_CHAIN_MASK_REDUCE:

Hi Peter,
please be a bit more verbose in your description.
This patch actualy changes the behavier of the code (into the intended way). Something like "fix brocken error check" is much more appropiate. There is clearly a difference between a additional (useless) semicolon and things like this.

re,
wh