Skip to contentSkip to conversation

pmc405de and zeus: remove the env_ptr externs

PATCH New Igor Grinberg 3 participants 3 messages Sep 28, 2012 – Oct 2, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pmc405de and zeus: remove the env_ptr externs

The env_ptr is already declared in environment.h, so there is no need to redeclare in board files (especially after including the environment.h) Remove those declarations.

Cc Stefan Roese <[email protected]>
Cc Matthias Fuchs <[email protected]>

---
Stefan, Matthias,
I'm sending from my laptop (not my main development machine) which does not have the ppc tool chain installed, can you please compile test these two boards? Thanks!

 board/esd/pmc405de/pmc405de.c |    1 -
 board/zeus/zeus.c             |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)
board/esd/pmc405de/pmc405de.c +0 -1
index a60809a..279d7d4 100644
@@ -415,7 +415,6 @@ U_BOOT_CMD(eepwren, 2, 0, do_eep_wren,
 
 #if defined(CONFIG_PRAM)
 #include <environment.h>
-extern env_t *env_ptr;
 
 int do_painit(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
board/zeus/zeus.c +0 -1
index 272e59b..e7b2f4d 100644
@@ -39,7 +39,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define REBOOT_DO_POST	0x00000001
 
 extern flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS]; /* info for FLASH chips	*/
-extern env_t *env_ptr;
 
 ulong flash_get_size(ulong base, int banknum);
 void env_crc_update(void);
Signature · 1 line
1.7.3.4
#1 lore raw

PATCH 1/1 pmc405de and zeus: remove the env_ptr externs

Quoted 3 lines · Igor Grinberg

The env_ptr is already declared in environment.h, so there is no need to redeclare in board files (especially after including the environment.h) Remove those declarations.

Thanks for spotting. I'll queue this up soon.

Thanks,
Stefan

#2 lore raw

PATCH 1/1 pmc405de and zeus: remove the env_ptr externs

In reply to Igor Grinberg

Hi Igor,

you are right. Thanks. You can add my

Matthias

Quoted 42 lines · Igor Grinberg

The env_ptr is already declared in environment.h, so there is no need to redeclare in board files (especially after including the environment.h) Remove those declarations.

Cc Stefan Roese <[email protected]>
Cc Matthias Fuchs <[email protected]>

---
Stefan, Matthias,
I'm sending from my laptop (not my main development machine) which does not have the ppc tool chain installed, can you please compile test these two boards? Thanks!

 board/esd/pmc405de/pmc405de.c |    1 -
 board/zeus/zeus.c             |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)
board/esd/pmc405de/pmc405de.c +0 -1
index a60809a..279d7d4 100644
@@ -415,7 +415,6 @@ U_BOOT_CMD(eepwren, 2, 0, do_eep_wren,
 
 #if defined(CONFIG_PRAM)
 #include <environment.h>
-extern env_t *env_ptr;
 
 int do_painit(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
board/zeus/zeus.c +0 -1
index 272e59b..e7b2f4d 100644
@@ -39,7 +39,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define REBOOT_DO_POST	0x00000001
 
 extern flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS]; /* info for FLASH chips	*/
-extern env_t *env_ptr;
 
 ulong flash_get_size(ulong base, int banknum);
 void env_crc_update(void);
Signature · 13 lines
-------------------------------------------------------------------------
Dipl.-Ing. Matthias Fuchs
Head of System Design

esd electronic system design gmbh
Vahrenwalder Str. 207 - 30165 Hannover - GERMANY
Phone: +49-511-37298-0 - Fax: +49-511-37298-68
Please visit our homepage http://www.esd.eu
Quality Products - Made in Germany
-------------------------------------------------------------------------
Gesch?ftsf?hrer: Klaus Detering
Amtsgericht Hannover HRB 51373 - VAT-ID DE 115672832
-------------------------------------------------------------------------