tegra: move common features to a common makefile

PATCH New Marc Dietrich 4 participants 4 messages Oct 3, 2012 – Oct 12, 2012

Share & tools

Marc Dietrich

author

2012-10-03 14:26 UTC #0 lore raw

PATCH 1/1 tegra: move common features to a common makefile

For Non-Nvidia boards to include newly added features (like emc clock scaling) it would be necessary to add each feature to their own board Makefile. This is because currently the top Makefile automaticly includes these features only for Nvidia boards.

This patch adds a simple Makefile include so all new features become available for non-Nvidia board vendors.

Cc Stephen Warren <[email protected]>

Cc Tom Warren <[email protected]>

Cc Thierry Reding <[email protected]>

Cc Lucas Stach <[email protected]>

Signed-off-by Marc Dietrich <[email protected]>

---

Passed: MAKEALL -s tegra20, booted on paz00

---
 board/avionic-design/medcom-wide/Makefile |    6 ++++--
 board/avionic-design/plutux/Makefile      |    6 ++++--
 board/avionic-design/tec/Makefile         |    6 ++++--
 board/compal/paz00/Makefile               |    6 ++++--
 board/compulab/trimslice/Makefile         |    6 ++++--
 board/nvidia/common/Makefile              |    4 +---
 board/nvidia/common/common.mk             |    4 ++++
 7 files changed, 25 insertions(+), 13 deletions(-)
 create mode 100644 board/nvidia/common/common.mk

board/avionic-design/medcom-wide/Makefile +4 -2

index 864bc0e..e8c1e8b 100644
@@ -29,9 +29,11 @@ $(shell mkdir -p $(obj)../common $(obj)../../nvidia/common)
 
 LIB	= $(obj)lib$(BOARD).o
 
-COBJS	:= ../../nvidia/common/board.o
-COBJS	+= ../common/tamonten.o
+COBJS-y	:= ../common/tamonten.o
 
+include ../../nvidia/common/common.mk
+
+COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))

board/avionic-design/plutux/Makefile +4 -2

index 864bc0e..e8c1e8b 100644
@@ -29,9 +29,11 @@ $(shell mkdir -p $(obj)../common $(obj)../../nvidia/common)
 
 LIB	= $(obj)lib$(BOARD).o
 
-COBJS	:= ../../nvidia/common/board.o
-COBJS	+= ../common/tamonten.o
+COBJS-y	:= ../common/tamonten.o
 
+include ../../nvidia/common/common.mk
+
+COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))

board/avionic-design/tec/Makefile +4 -2

index 864bc0e..e8c1e8b 100644
@@ -29,9 +29,11 @@ $(shell mkdir -p $(obj)../common $(obj)../../nvidia/common)
 
 LIB	= $(obj)lib$(BOARD).o
 
-COBJS	:= ../../nvidia/common/board.o
-COBJS	+= ../common/tamonten.o
+COBJS-y	:= ../common/tamonten.o
 
+include ../../nvidia/common/common.mk
+
+COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))

board/compal/paz00/Makefile +4 -2

index 7f7287e..fa5c510 100644
@@ -20,9 +20,11 @@ $(shell mkdir -p $(obj)../../nvidia/common)
 
 LIB	= $(obj)lib$(BOARD).o
 
-COBJS	:= $(BOARD).o
-COBJS	+= ../../nvidia/common/board.o
+COBJS-y	:= $(BOARD).o
 
+include ../../nvidia/common/common.mk
+
+COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))

board/compulab/trimslice/Makefile +4 -2

index ff07879..cc844d2 100644
@@ -28,9 +28,11 @@ $(shell mkdir -p $(obj)../../nvidia/common)
 
 LIB	= $(obj)lib$(BOARD).o
 
-COBJS	:= $(BOARD).o
-COBJS	+= ../../nvidia/common/board.o
+COBJS-y	:= $(BOARD).o
 
+include ../../nvidia/common/common.mk
+
+COBJS	:= $(COBJS-y)
 SRCS	:= $(COBJS:.o=.c)
 OBJS	:= $(addprefix $(obj),$(COBJS))

board/nvidia/common/Makefile +1 -3

index a93d458..f6f419e 100644
@@ -25,9 +25,7 @@ endif
 
 LIB	= $(obj)lib$(VENDOR).o
 
-COBJS-y += board.o
-COBJS-$(CONFIG_SPI_UART_SWITCH) += uart-spi-switch.o
-COBJS-$(CONFIG_TEGRA_CLOCK_SCALING) += emc.o
+include common.mk
 
 COBJS	:= $(COBJS-y)
 SRCS	:= $(SOBJS:.o=.S) $(COBJS:.o=.c)

board/nvidia/common/common.mk new file +4 -0

new file mode 100644
index 0000000..bd6202c
@@ -0,0 +1,4 @@
+# common options for all tegra boards
+COBJS-y	+= ../../nvidia/common/board.o
+COBJS-$(CONFIG_SPI_UART_SWITCH) += ../../nvidia/common/uart-spi-switch.o
+COBJS-$(CONFIG_TEGRA_CLOCK_SCALING) += ../../nvidia/common/emc.o

Signature · 1 line

1.7.9.5

Stephen Warren

2012-10-03 15:33 UTC #1 lore raw

PATCH 1/1 tegra: move common features to a common makefile

Quoted 7 lines · Marc Dietrich

For Non-Nvidia boards to include newly added features (like emc clock scaling) it would be necessary to add each feature to their own board Makefile. This is because currently the top Makefile automaticly includes these features only for Nvidia boards.
This patch adds a simple Makefile include so all new features become available for non-Nvidia board vendors.

Acked-by Stephen Warren <[email protected]>

Thierry Reding

2012-10-04 05:59 UTC #2 lore raw

PATCH 1/1 tegra: move common features to a common makefile

In reply to Marc Dietrich

Quoted 17 lines · Marc Dietrich

For Non-Nvidia boards to include newly added features (like emc clock scaling) it would be necessary to add each feature to their own board Makefile. This is because currently the top Makefile automaticly includes these features only for Nvidia boards.
This patch adds a simple Makefile include so all new features become available for non-Nvidia board vendors.
Cc Stephen Warren <[email protected]>
Cc Tom Warren <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Lucas Stach <[email protected]>
Signed-off-by Marc Dietrich <[email protected]>
---
Passed: MAKEALL -s tegra20, booted on paz00

Quoted 10 lines

---
 board/avionic-design/medcom-wide/Makefile |    6 ++++--
 board/avionic-design/plutux/Makefile      |    6 ++++--
 board/avionic-design/tec/Makefile         |    6 ++++--
 board/compal/paz00/Makefile               |    6 ++++--
 board/compulab/trimslice/Makefile         |    6 ++++--
 board/nvidia/common/Makefile              |    4 +---
 board/nvidia/common/common.mk             |    4 ++++
 7 files changed, 25 insertions(+), 13 deletions(-)
 create mode 100644 board/nvidia/common/common.mk

Acked-by Thierry Reding <[email protected]>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121004/c490e87d/attachment.pgp>

Tom Warren

2012-10-12 17:35 UTC #3 lore raw

PATCH 1/1 tegra: move common features to a common makefile

Marc,

Quoted 6 lines

-----Original Message-----
From: Thierry Reding [mailto:thierry.reding at avionic-design.de]
Sent: Wednesday, October 03, 2012 10:59 PM
To: Marc Dietrich
Cc: u-boot at lists.denx.de; Stephen Warren; Tom Warren; Lucas Stach
Subject: Re: [PATCH] tegra: move common features to a common makefile

Applied to u-boot-tegra/next. I'll be pushing it to denx.de as soon as build/sanity tests are done.

Thanks,

Tom

Quoted 36 lines

* PGP Signed by an unknown key
Quoted 26 lines · Marc Dietrich
For Non-Nvidia boards to include newly added features (like emc clock scaling) it would be necessary to add each feature to their own board Makefile. This is because currently the top Makefile automaticly includes these features only for Nvidia boards.
This patch adds a simple Makefile include so all new features become available for non-Nvidia board vendors.
Cc Stephen Warren <[email protected]>
Cc Tom Warren <[email protected]>
Cc Thierry Reding <[email protected]>
Cc Lucas Stach <[email protected]>
Signed-off-by Marc Dietrich <[email protected]>
---
Passed: MAKEALL -s tegra20, booted on paz00
---
 board/avionic-design/medcom-wide/Makefile |    6 ++++--
 board/avionic-design/plutux/Makefile      |    6 ++++--
 board/avionic-design/tec/Makefile         |    6 ++++--
 board/compal/paz00/Makefile               |    6 ++++--
 board/compulab/trimslice/Makefile         |    6 ++++--
 board/nvidia/common/Makefile              |    4 +---
 board/nvidia/common/common.mk             |    4 ++++
 7 files changed, 25 insertions(+), 13 deletions(-)  create mode
Quoted 1 line
100644 board/nvidia/common/common.mk
Acked-by Thierry Reding <[email protected]>
* Unknown Key
* 0x7F3EB3A1

Signature · 1 line

nvpublic