Skip to contentSkip to conversation

skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.

PATCH In review Graham Gower 2 participants 3 messages Oct 8, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH v4 1/1 skge: Add DMA mask quirk for Marvell 88E8001 on ASUS P5NSLI motherboard.

Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive packets on a system with >4gb ram unless a 32bit DMA mask is used.

This issue has been around for years and a fix was sent 3.5 years ago, but there was some debate as to whether it should instead be fixed as a PCI quirk.
http://www.spinics.net/lists/netdev/msg88670.html

However, 18 months later a similar workaround was introduced for another chipset exhibiting the same problem.
http://www.spinics.net/lists/netdev/msg142287.html

drivers/net/ethernet/marvell/skge.c renamed from drivers/net/ethernet/marvell/skge.c.bak +7 -0
@@ -4143,6 +4143,13 @@
 			DMI_MATCH(DMI_BOARD_NAME, "nForce"),
 		},
 	},
+	{
+		.ident = "ASUS P5NSLI",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
+			DMI_MATCH(DMI_BOARD_NAME, "P5NSLI")
+		},
+	},
 	{}
 };
 
maintainer
#1 lore raw

From: Graham Gower <[email protected]>
Date: Mon, 08 Oct 2012 17:13:24 +1030

Quoted 3 lines

Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive
packets on a system with >4gb ram unless a 32bit DMA mask is used.

Please format this ascii text properly. WHy is there a line with just two words surrounded by full nearly 80-column lines?

drivers/net/ethernet/marvell/skge.c line 4149

Quoted 2 lines
drivers/net/ethernet/marvell/skge.c renamed from drivers/net/ethernet/marvell/skge.c.bak +2 -0
+		.matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),

THis is still formatted incorrectly, it's actually in the file not due to your email client.

Can you indent the thing properly, please?

This is V4 of this patch, and suffering purely from first order coding style and procedural stuff. As you can imagine, it's very frustrating to have to spend this much time getting such simple things taken care of.

#2 lore raw

Well its pretty frustrating from my end too.

Fuck it, i dont care enough. I'll just keep patching kernels locally until my hardware expires.

Quoted 22 lines · David Miller

From: Graham Gower <[email protected]>
Date: Mon, 08 Oct 2012 17:13:24 +1030

Quoted 3 lines

Marvell 88E8001 on an ASUS P5NSLI motherboard is unable to send/receive
packets on a system with >4gb ram unless a 32bit DMA mask is used.

Please format this ascii text properly. WHy is there a line with just two words surrounded by full nearly 80-column lines?

Quoted 2 lines

+ .matches = {
+ DMI_MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),

THis is still formatted incorrectly, it's actually in the file not due to your email client.

Can you indent the thing properly, please?

This is V4 of this patch, and suffering purely from first order coding style and procedural stuff. As you can imagine, it's very frustrating to have to spend this much time getting such simple things taken care of.