Skip to contentSkip to conversation

ext3: fix return values on parse_options() failure

PATCH In review Zhao Hongjiang 6 participants 6 messages Oct 9, 2012 2 messages not in the archive

lore
Share & tools
lore

Zhao Hongjiang

author
#0 lore raw

PATCH 1/1 ext3: fix return values on parse_options() failure

From: Zhao Hongjiang <[email protected]>

parse_options() in ext3 should return 0 when parse the mount options fails.

Signed-off-by Zhao Hongjiang <[email protected]>
---
 fs/ext3/super.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/ext3/super.c +2 -2
index 17ae5c8..ebf8312 100644
@@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb,
 			uid = make_kuid(current_user_ns(), option);
 			if (!uid_valid(uid)) {
 				ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);
-				return -1;
+				return 0;
 
 			}
 			sbi->s_resuid = uid;

@@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb,
 			gid = make_kgid(current_user_ns(), option);
 			if (!gid_valid(gid)) {
 				ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);
-				return -1;
+				return 0;
 			}
 			sbi->s_resgid = gid;
 			break;

-- 1.7.1

A message that is not in the archive (sent off-list or not yet received): [email protected]

Reviewed-by
#2 lore raw
Quoted 9 lines · Zhao Hongjiang

Date: Tue, 09 Oct 2012 13:48:47 +0800
From: Zhao Hongjiang <[email protected]>
To: [email protected]
Cc: akpm-de/[email protected], [email protected],
[email protected], [email protected], Eric W. Biederman <ebiederm-aS9lmoZGLiVWk0Htik3J/[email protected]>, [email protected], containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org
Subject: [PATCH] ext3: fix return values on parse_options() failure

Quoted 4 lines

From: Zhao Hongjiang <[email protected]>

parse_options() in ext3 should return 0 when parse the mount options fails.

Ah, it really is a joy to read the parse_options() :). But this fix makes sense, thanks for catching it.

Reviewed-by Lukas Czerner <[email protected]>

-Lukas

Quoted 33 lines
Signed-off-by Zhao Hongjiang <[email protected]>
---
 fs/ext3/super.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/ext3/super.c +2 -4
index 17ae5c8..ebf8312 100644
@@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb,
 			uid = make_kuid(current_user_ns(), option);
 			if (!uid_valid(uid)) {
 				ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);
-				return -1;
+				return 0;
 
 			}
 			sbi->s_resuid = uid;

@@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb,
 			gid = make_kgid(current_user_ns(), option);
 			if (!gid_valid(gid)) {
 				ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);
-				return -1;
+				return 0;
 			}
 			sbi->s_resgid = gid;
 			break;
-- 1.7.1
--

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Reviewed-by on v1 1/1
#3 lore raw
In reply to Zhao Hongjiang
Quoted 9 lines · Zhao Hongjiang

Date: Tue, 09 Oct 2012 13:48:47 +0800
From: Zhao Hongjiang <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected], Eric W. Biederman <[email protected]>, [email protected], [email protected]
Subject: [PATCH] ext3: fix return values on parse_options() failure

Quoted 4 lines

From: Zhao Hongjiang <[email protected]>

parse_options() in ext3 should return 0 when parse the mount options fails.

Ah, it really is a joy to read the parse_options() :). But this fix makes sense, thanks for catching it.

Reviewed-by Lukas Czerner <[email protected]>

-Lukas

Quoted 33 lines
Signed-off-by Zhao Hongjiang <[email protected]>
---
 fs/ext3/super.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/ext3/super.c +2 -4
index 17ae5c8..ebf8312 100644
@@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb,
 			uid = make_kuid(current_user_ns(), option);
 			if (!uid_valid(uid)) {
 				ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);
-				return -1;
+				return 0;
 
 			}
 			sbi->s_resuid = uid;

@@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb,
 			gid = make_kgid(current_user_ns(), option);
 			if (!gid_valid(gid)) {
 				ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);
-				return -1;
+				return 0;
 			}
 			sbi->s_resgid = gid;
 			break;
-- 1.7.1
--

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

Acked-by
#4 lore raw
Quoted 13 lines · Lukáš Czerner
Quoted 11 lines · Zhao Hongjiang

Date: Tue, 09 Oct 2012 13:48:47 +0800
From: Zhao Hongjiang <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected], Eric W. Biederman <[email protected]>, [email protected], [email protected]
Subject: [PATCH] ext3: fix return values on parse_options() failure

From: Zhao Hongjiang <[email protected]>

Quoted 7 lines
Quoted 2 lines

parse_options() in ext3 should return 0 when parse the mount options fails.

Ah, it really is a joy to read the parse_options() :). But this fix makes sense, thanks for catching it.

Reviewed-by Lukas Czerner <[email protected]>

Ugh. I goofed that up. How annoying that ext4 is different than ext3 and ext2 in this regard.

Acked-by "Eric W. Biederman" <[email protected]>

_______________________________________________
Containers mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/containers

A message that is not in the archive (sent off-list or not yet received): alpine.LFD.2.00.1210090814420.11244-462rkM2+8ahgDJpvDrVWWBcY2uh10dtjAL8bYrjMMd8@public.gmane.org

#6 lore raw
Quoted 13 lines · Lukáš Czerner
Quoted 11 lines · Zhao Hongjiang

Date: Tue, 09 Oct 2012 13:48:47 +0800
From: Zhao Hongjiang <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected], Eric W. Biederman <[email protected]>, [email protected], [email protected]
Subject: [PATCH] ext3: fix return values on parse_options() failure

From: Zhao Hongjiang <[email protected]>

Quoted 7 lines
Quoted 2 lines

parse_options() in ext3 should return 0 when parse the mount options fails.

Ah, it really is a joy to read the parse_options() :). But this fix makes sense, thanks for catching it.

Reviewed-by Lukas Czerner <[email protected]>

Thanks, added to my tree.

Honza

Quoted 28 lines

-Lukas

Quoted 25 lines
Signed-off-by Zhao Hongjiang <[email protected]>
---
 fs/ext3/super.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/ext3/super.c +2 -2
index 17ae5c8..ebf8312 100644
@@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb,
 			uid = make_kuid(current_user_ns(), option);
 			if (!uid_valid(uid)) {
 				ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);
-				return -1;
+				return 0;
 
 			}
 			sbi->s_resuid = uid;

@@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb,
 			gid = make_kgid(current_user_ns(), option);
 			if (!gid_valid(gid)) {
 				ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);
-				return -1;
+				return 0;
 			}
Quoted 8 lines
Quoted 8 lines
fs/ext3/super.c +0 -2
 			sbi->s_resgid = gid;
 			break;
-- 1.7.1
--

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

_______________________________________________
Containers mailing list
[email protected]
https://lists.linuxfoundation.org/mailman/listinfo/containers

#7 lore raw
In reply to Lukáš Czerner
Quoted 13 lines · Lukáš Czerner
Quoted 11 lines · Zhao Hongjiang

Date: Tue, 09 Oct 2012 13:48:47 +0800
From: Zhao Hongjiang <[email protected]>
To: [email protected]
Cc: [email protected], [email protected],
[email protected], [email protected], Eric W. Biederman <[email protected]>, [email protected], [email protected]
Subject: [PATCH] ext3: fix return values on parse_options() failure

From: Zhao Hongjiang <[email protected]>

Quoted 7 lines
Quoted 2 lines

parse_options() in ext3 should return 0 when parse the mount options fails.

Ah, it really is a joy to read the parse_options() :). But this fix makes sense, thanks for catching it.

Reviewed-by Lukas Czerner <[email protected]>

Thanks, added to my tree.

Honza

Quoted 28 lines

-Lukas

Quoted 25 lines
Signed-off-by Zhao Hongjiang <[email protected]>
---
 fs/ext3/super.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/ext3/super.c +2 -2
index 17ae5c8..ebf8312 100644
@@ -1001,7 +1001,7 @@ static int parse_options (char *options, struct super_block *sb,
 			uid = make_kuid(current_user_ns(), option);
 			if (!uid_valid(uid)) {
 				ext3_msg(sb, KERN_ERR, "Invalid uid value %d", option);
-				return -1;
+				return 0;
 
 			}
 			sbi->s_resuid = uid;

@@ -1012,7 +1012,7 @@ static int parse_options (char *options, struct super_block *sb,
 			gid = make_kgid(current_user_ns(), option);
 			if (!gid_valid(gid)) {
 				ext3_msg(sb, KERN_ERR, "Invalid gid value %d", option);
-				return -1;
+				return 0;
 			}
Quoted 8 lines
Quoted 8 lines
fs/ext3/super.c +0 -2
 			sbi->s_resgid = gid;
 			break;
-- 1.7.1
--

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html