Fix calculation of memory needed for page handles
PATCH 1/1 Fix calculation of memory needed for page handles
Hi,
Wrong sizeof used, fixed in attached patch, and below.
Quoted 1 line
From
7f430a4104bee5f75929580a66128b7b0e2859d9Mon Sep 17 00:00:00 2001
From: Vincent Penquerc'h <[email protected]>
Date: Tue, 9 Oct 2012 17:18:33 +0100
Subject: [PATCH] drm/omap: fix allocation size for page addresses array
--- drivers/staging/omapdrm/omap_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
(quoted diff) +0 -0
b/drivers/staging/omapdrm/omap_gem.c
index c828743..4c1472c 100644
drivers/staging/omapdrm/omap_gem.c +0 -0
@@ -246,7 +246,7 @@ static int omap_gem_attach_pages(struct
drm_gem_object *obj)
* DSS, GPU, etc. are not cache coherent:
*/
if (omap_obj->flags & (OMAP_BO_WC|OMAP_BO_UNCACHED)) {
- addrs = kmalloc(npages * sizeof(addrs), GFP_KERNEL);
+ addrs = kmalloc(npages * sizeof(*addrs), GFP_KERNEL);
if (!addrs) {
ret = -ENOMEM;
goto free_pages;
@@ -257,7 +257,7 @@ static int omap_gem_attach_pages(struct drm_gem_object *obj)
0, PAGE_SIZE, DMA_BIDIRECTIONAL);
}
} else {
- addrs = kzalloc(npages * sizeof(addrs), GFP_KERNEL);
+ addrs = kzalloc(npages * sizeof(*addrs), GFP_KERNEL);
if (!addrs) {
ret = -ENOMEM;
goto free_pages;
Signature · 1 line
1.7.9.5
Quoted 1 line
From
6a3956290c8473e26047cc9570629fc15ec32cb1Mon Sep 17 00:00:00 2001
From: Vincent Penquerc'h <[email protected]>
Date: Tue, 9 Oct 2012 17:18:33 +0100
Subject: [PATCH] omap_gem: fix incorrect allocation size for page addresses
array
--- drivers/staging/omapdrm/omap_gem.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/omapdrm/omap_gem.c +2 -2
@@ -256,13 +256,13 @@ static int omap_gem_attach_pages(struct drm_gem_object *obj)* DSS, GPU, etc. are not cache coherent: */ if (omap_obj->flags & (OMAP_BO_WC |OMAP_BO_UNCACHED )) { - addrs =kmalloc (npages *sizeof (addrs),GFP_KERNEL ); + addrs =kmalloc (npages *sizeof (*addrs),GFP_KERNEL );for (i =0 ; i < npages; i++) { addrs[i] =dma_map_page (dev->dev, pages[i],0 ,PAGE_SIZE ,DMA_BIDIRECTIONAL ); } }else { - addrs =kzalloc (npages *sizeof (addrs),GFP_KERNEL ); + addrs =kzalloc (npages *sizeof (*addrs),GFP_KERNEL ); } omap_obj->addrs = addrs;
Signature · 1 line
1.7.9.5
_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel