webkit: Fix build issue with gcc-4.6 and above

PATCH New Valentine Barshak 3 participants 7 messages Oct 4, 2012 – Oct 21, 2012

Share & tools

Valentine Barshak

author

2012-10-04 21:26 UTC #0 lore raw

PATCH 1/1 webkit: Fix build issue with gcc-4.6 and above

This fixes the "Unknown parameter for tags/attrs" build error. Backported from commit 88e08c43d0200a4b06a298b7d2541965eebc0afe

[PATCH] 2011-04-17 Thierry Reding
<[email protected]>

Reviewed by Adam Barth.

Fix build with GCC 4.6.

* dom/make_names.pl: Execute preprocessor without the -P option. The preprocessor in GCC 4.6 eats empty lines, effectively breaking the parsing performed by this script. Dropping the -P option when invoking the preprocessor keeps the empty lines but as a side-effect also adds additional linemarkers.

From the cpp manpage:

-P Inhibit generation of linemarkers in the output from the
preprocessor. This might be useful when running the preprocessor on something that is not C code, and will be sent to a program which might be confused by the linemarkers.

The linemarkers are not problematic, however, because the script properly handles them by ignoring all lines starting with a #.

Signed-off-by Valentine Barshak <[email protected]>

---
 package/webkit/webkit-fix-build-with-gcc-4-6.patch | 45 ++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 package/webkit/webkit-fix-build-with-gcc-4-6.patch

package/webkit/webkit-fix-build-with-gcc-4-6.patch new file +45 -0

new file mode 100644
index 0000000..15f32d9
@@ -0,0 +1,45 @@
+Backported from commit 88e08c43d0200a4b06a298b7d2541965eebc0afe:
+Removed the ChangeLog part.
+
+From: "commit-queue at webkit.org"
+ <[email protected]@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
+Date: Mon, 18 Apr 2011 06:53:23 +0000
+Subject: [PATCH] 2011-04-17  Thierry Reding 
+ <[email protected]>
+
+        Reviewed by Adam Barth.
+
+        Fix build with GCC 4.6.
+
+        * dom/make_names.pl: Execute preprocessor without the -P option. The
+        preprocessor in GCC 4.6 eats empty lines, effectively breaking the
+        parsing performed by this script. Dropping the -P option when invoking
+        the preprocessor keeps the empty lines but as a side-effect also adds
+        additional linemarkers.
+
+        From the cpp manpage:
+
+          -P  Inhibit generation of linemarkers in the output from the
+              preprocessor. This might be useful when running the preprocessor
+              on something that is not C code, and will be sent to a program
+              which might be confused by the linemarkers.
+
+        The linemarkers are not problematic, however, because the script
+        properly handles them by ignoring all lines starting with a #.
+
+diff --git a/WebCore/dom/make_names.pl b/Source/WebCore/dom/make_names.pl
+index 836137e..50386e0 100755
+--- a/WebCore/dom/make_names.pl
++++ b/WebCore/dom/make_names.pl
+@@ -54,7 +54,7 @@ if ($ENV{CC}) {
+ } else {
+     $gccLocation = "/usr/bin/gcc";
+ }
+-my $preprocessor = $gccLocation . " -E -P -x c++";
++my $preprocessor = $gccLocation . " -E -x c++";
+ 
+ GetOptions(
+     'tags=s' => \$tagsFile, 
+-- 
+1.7.11.4
+

Signature · 1 line

1.7.11.4

Valentine Barshak

author

2012-10-09 22:54 UTC #1 lore raw

PATCH 1/1 webkit: Fix build issue with gcc-4.6 and above

Quoted 74 lines · Valentine Barshak

This fixes the "Unknown parameter for tags/attrs" build error. Backported from commit 88e08c43d0200a4b06a298b7d2541965eebc0afe
[PATCH] 2011-04-17 Thierry Reding
<[email protected]>
Reviewed by Adam Barth.
Fix build with GCC 4.6.
* dom/make_names.pl: Execute preprocessor without the -P option. The preprocessor in GCC 4.6 eats empty lines, effectively breaking the parsing performed by this script. Dropping the -P option when invoking the preprocessor keeps the empty lines but as a side-effect also adds additional linemarkers.
From the cpp manpage:
-P Inhibit generation of linemarkers in the output from the
preprocessor. This might be useful when running the preprocessor on something that is not C code, and will be sent to a program which might be confused by the linemarkers.
The linemarkers are not problematic, however, because the script properly handles them by ignoring all lines starting with a #.
Signed-off-by Valentine Barshak <[email protected]>
---
  package/webkit/webkit-fix-build-with-gcc-4-6.patch | 45 ++++++++++++++++++++++
  1 file changed, 45 insertions(+)
create mode 100644 package/webkit/webkit-fix-build-with-gcc-4-6.patch
package/webkit/webkit-fix-build-with-gcc-4-6.patch new file +35 -0
new file mode 100644
index 0000000..15f32d9
@@ -0,0 +1,45 @@
+Backported from commit 88e08c43d0200a4b06a298b7d2541965eebc0afe:
+Removed the ChangeLog part.
+
+From: "commit-queue at webkit.org"
+ <[email protected]@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
+Date: Mon, 18 Apr 2011 06:53:23 +0000
+Subject: [PATCH] 2011-04-17  Thierry Reding
+ <[email protected]>
+
+        Reviewed by Adam Barth.
+
+        Fix build with GCC 4.6.
+
+        * dom/make_names.pl: Execute preprocessor without the -P option. The
+        preprocessor in GCC 4.6 eats empty lines, effectively breaking the
+        parsing performed by this script. Dropping the -P option when invoking
+        the preprocessor keeps the empty lines but as a side-effect also adds
+        additional linemarkers.
+
+        From the cpp manpage:
+
+          -P  Inhibit generation of linemarkers in the output from the
+              preprocessor. This might be useful when running the preprocessor
+              on something that is not C code, and will be sent to a program
+              which might be confused by the linemarkers.
+
+        The linemarkers are not problematic, however, because the script
+        properly handles them by ignoring all lines starting with a #.
+
+diff --git a/WebCore/dom/make_names.pl b/Source/WebCore/dom/make_names.pl
+index 836137e..50386e0 100755
+--- a/WebCore/dom/make_names.pl
++++ b/WebCore/dom/make_names.pl
+@@ -54,7 +54,7 @@ if ($ENV{CC}) {
+ } else {

package/webkit/webkit-fix-build-with-gcc-4-6.patch line 45

Quoted 10 lines

package/webkit/webkit-fix-build-with-gcc-4-6.patch new file +10 -0

+     $gccLocation = "/usr/bin/gcc";
+ }
+-my $preprocessor = $gccLocation . " -E -P -x c++";
++my $preprocessor = $gccLocation . " -E -x c++";
+
+ GetOptions(
+     'tags=s' => \$tagsFile,
+--
+1.7.11.4
+

Is this change OK?
I'm building on Fedora 17, using host gcc 4.7.2, and webkit doesn't build for me without this patch.

Thanks,
Val.

Samuel Martin

2012-10-10 05:21 UTC #2 lore raw

PATCH 1/1 webkit: Fix build issue with gcc-4.6 and above

Hi Val,

2012/10/10 Valentine Barshak <[email protected]>:

Quoted 5 lines

Is this change OK?
I'm building on Fedora 17, using host gcc 4.7.2, and webkit doesn't build for me without this patch.

I think this will fix the Webkit issue I got when I was trying the gettext patch set some weeks ago... but I didn't dig into it.

I'll give it a try as soon as I can.

Thanks,

Signature · 1 line

Sam

Samuel Martin

2012-10-13 09:41 UTC #3 lore raw

PATCH 1/1 webkit: Fix build issue with gcc-4.6 and above

In reply to Valentine Barshak

Hi Val, all,

Tested using gcc-4.{6,7}-based toolchain.

My comments inlined.

2012/10/4 Valentine Barshak <[email protected]>:

Quoted 23 lines

This fixes the "Unknown parameter for tags/attrs" build error. Backported from commit 88e08c43d0200a4b06a298b7d2541965eebc0afe
[PATCH] 2011-04-17 Thierry Reding
<[email protected]>
Reviewed by Adam Barth.
Fix build with GCC 4.6.
* dom/make_names.pl: Execute preprocessor without the -P option. The preprocessor in GCC 4.6 eats empty lines, effectively breaking the parsing performed by this script. Dropping the -P option when invoking the preprocessor keeps the empty lines but as a side-effect also adds additional linemarkers.
From the cpp manpage:
-P Inhibit generation of linemarkers in the output from the
preprocessor. This might be useful when running the preprocessor on something that is not C code, and will be sent to a program which might be confused by the linemarkers.

Quoted 4 lines

The linemarkers are not problematic, however, because the script properly handles them by ignoring all lines starting with a #.
Signed-off-by Valentine Barshak <[email protected]>

Tested-by Samuel Martin <[email protected]>

Acked-by Samuel Martin <[email protected]>

[...]

package/webkit/webkit-fix-build-with-gcc-4-6.patch line 30

Quoted 4 lines

package/webkit/webkit-fix-build-with-gcc-4-6.patch new file +4 -0

+        The linemarkers are not problematic, however, because the script
+        properly handles them by ignoring all lines starting with a #.
+
+diff --git a/WebCore/dom/make_names.pl b/Source/WebCore/dom/make_names.pl

Nitpicking:
s at Source/@@

Regards,

Signature · 1 line

Sam

Valentine Barshak

author

2012-10-15 13:48 UTC #4 lore raw

PATCH 1/1 webkit: Fix build issue with gcc-4.6 and above

Quoted 37 lines · Samuel Martin

Hi Val, all,
Tested using gcc-4.{6,7}-based toolchain.
My comments inlined.
2012/10/4 Valentine Barshak <[email protected]>:
Quoted 23 lines
This fixes the "Unknown parameter for tags/attrs" build error. Backported from commit 88e08c43d0200a4b06a298b7d2541965eebc0afe
[PATCH] 2011-04-17 Thierry Reding
<[email protected]>
Reviewed by Adam Barth.
Fix build with GCC 4.6.
* dom/make_names.pl: Execute preprocessor without the -P option. The preprocessor in GCC 4.6 eats empty lines, effectively breaking the parsing performed by this script. Dropping the -P option when invoking the preprocessor keeps the empty lines but as a side-effect also adds additional linemarkers.
From the cpp manpage:
-P Inhibit generation of linemarkers in the output from the
preprocessor. This might be useful when running the preprocessor on something that is not C code, and will be sent to a program which might be confused by the linemarkers.
Quoted 4 lines
The linemarkers are not problematic, however, because the script properly handles them by ignoring all lines starting with a #.
Signed-off-by Valentine Barshak <[email protected]>
Tested-by Samuel Martin <[email protected]>
Acked-by Samuel Martin <[email protected]>

Quoted 8 lines

[...]
package/webkit/webkit-fix-build-with-gcc-4-6.patch line 30
Quoted 4 lines
package/webkit/webkit-fix-build-with-gcc-4-6.patch new file +4 -0
+        The linemarkers are not problematic, however, because the script
+        properly handles them by ignoring all lines starting with a #.
+
+diff --git a/WebCore/dom/make_names.pl b/Source/WebCore/dom/make_names.pl
Nitpicking:
s at Source/@@

Thanks, Samuel!

Regards,
Val

Valentine Barshak

author

2012-10-15 13:51 UTC #5 lore raw

PATCH v2 1/1 webkit: Fix build issue with gcc-4.6 and above

In reply to Samuel Martin

This fixes the "Unknown parameter for tags/attrs" build error. Backported from commit 88e08c43d0200a4b06a298b7d2541965eebc0afe

[PATCH] 2011-04-17 Thierry Reding
<[email protected]>

Reviewed by Adam Barth.

Fix build with GCC 4.6.

From the cpp manpage:

The linemarkers are not problematic, however, because the script properly handles them by ignoring all lines starting with a #.

Signed-off-by Valentine Barshak <[email protected]>

---
 package/webkit/webkit-fix-build-with-gcc-4-6.patch | 45 ++++++++++++++++++++++
 1 file changed, 45 insertions(+)
 create mode 100644 package/webkit/webkit-fix-build-with-gcc-4-6.patch

package/webkit/webkit-fix-build-with-gcc-4-6.patch new file +45 -0

new file mode 100644
index 0000000..181c7f5
@@ -0,0 +1,45 @@
+Backported from commit 88e08c43d0200a4b06a298b7d2541965eebc0afe:
+Removed the ChangeLog part.
+
+From: "commit-queue at webkit.org"
+ <[email protected]@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
+Date: Mon, 18 Apr 2011 06:53:23 +0000
+Subject: [PATCH] 2011-04-17  Thierry Reding 
+ <[email protected]>
+
+        Reviewed by Adam Barth.
+
+        Fix build with GCC 4.6.
+
+        * dom/make_names.pl: Execute preprocessor without the -P option. The
+        preprocessor in GCC 4.6 eats empty lines, effectively breaking the
+        parsing performed by this script. Dropping the -P option when invoking
+        the preprocessor keeps the empty lines but as a side-effect also adds
+        additional linemarkers.
+
+        From the cpp manpage:
+
+          -P  Inhibit generation of linemarkers in the output from the
+              preprocessor. This might be useful when running the preprocessor
+              on something that is not C code, and will be sent to a program
+              which might be confused by the linemarkers.
+
+        The linemarkers are not problematic, however, because the script
+        properly handles them by ignoring all lines starting with a #.
+
+diff --git a/WebCore/dom/make_names.pl b/WebCore/dom/make_names.pl
+index 836137e..50386e0 100755
+--- a/WebCore/dom/make_names.pl
++++ b/WebCore/dom/make_names.pl
+@@ -54,7 +54,7 @@ if ($ENV{CC}) {
+ } else {
+     $gccLocation = "/usr/bin/gcc";
+ }
+-my $preprocessor = $gccLocation . " -E -P -x c++";
++my $preprocessor = $gccLocation . " -E -x c++";
+ 
+ GetOptions(
+     'tags=s' => \$tagsFile, 
+-- 
+1.7.11.4
+

Signature · 1 line

1.7.11.7

Peter Korsgaard

2012-10-21 19:23 UTC #6 lore raw

PATCH v2 1/1 webkit: Fix build issue with gcc-4.6 and above

Quoted 1 line

Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line
"Valentine" == Valentine Barshak <[email protected]> writes:

Valentine> This fixes the "Unknown parameter for tags/attrs" build error. Valentine> Backported from commit 88e08c43d0200a4b06a298b7d2541965eebc0afe

Committed, thanks.

Signature · 1 line

Bye, Peter Korsgaard