Skip to contentSkip to conversation

kexec: fix Makefile.in binaries_arch

PATCH Applied Tony Jones 3 participants 3 messages Oct 10, 2012 – Oct 11, 2012

Subsystems (3)
Kbuild Live update kexec handover (KHO)
lore
Share & tools
lore

Tony Jones

author
#0 lore raw

PATCH 1/1 kexec: fix Makefile.in binaries_arch

Definitions of BINARIES_ARCH in Makefile.in seems to have been broken since commit 0775c60eb.

Signed-off-by Tony Jones <[email protected]>

---

Makefile.in +2 -2
index ba2e638..97405a2 100644
@@ -176,8 +176,8 @@ PSRCS:=$(foreach s, $(SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
 PGSRCS:=$(foreach s, $(GENERATED_SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
 
 MAN_PAGES:=$(KEXEC_MANPAGE) $(KDUMP_MANPAGE) $(VMCORE_DMESG_MANPAGE)
-BINARIES_i386:=$(KEXEC_TEST) $(KEXEC_TEST)
-BINARIES_x86_64:=$(KEXEC) $(KDUMP) $(BINARIES_$(ARCH))
+BINARIES_i386:=$(KEXEC_TEST)
+BINARIES_x86_64:=$(KEXEC_TEST)
 BINARIES:=$(KEXEC) $(KDUMP) $(VMCORE_DMESG) $(BINARIES_$(ARCH))
 
 TARGETS:=$(BINARIES) $(MAN_PAGES)

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#1 lore raw
Quoted 11 lines · Tony Jones

Definitions of BINARIES_ARCH in Makefile.in seems to have been broken since commit 0775c60eb.

Signed-off-by Tony Jones <[email protected]>

---

Makefile.in +0 -0
index ba2e638..97405a2 100644

Makefile.in PSRCS:=$(foreach s, $(SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s)) · line 183

Quoted 10 lines
Makefile.in +2 -2
@@ -176,8 +176,8 @@ PSRCS:=$(foreach s, $(SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
 PGSRCS:=$(foreach s, $(GENERATED_SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
 
 MAN_PAGES:=$(KEXEC_MANPAGE) $(KDUMP_MANPAGE) $(VMCORE_DMESG_MANPAGE)
-BINARIES_i386:=$(KEXEC_TEST) $(KEXEC_TEST)
-BINARIES_x86_64:=$(KEXEC) $(KDUMP) $(BINARIES_$(ARCH))
+BINARIES_i386:=$(KEXEC_TEST)
+BINARIES_x86_64:=$(KEXEC_TEST)
 BINARIES:=$(KEXEC) $(KDUMP) $(VMCORE_DMESG) $(BINARIES_$(ARCH))
 
 TARGETS:=$(BINARIES) $(MAN_PAGES)

That looks like a much needed fix and clean up.

--
Khalid

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

Applied
#2 lore raw
Quoted 20 lines · Khalid Aziz
Quoted 19 lines · Tony Jones

Definitions of BINARIES_ARCH in Makefile.in seems to have been broken since commit 0775c60eb.

Signed-off-by Tony Jones <[email protected]>

---

Makefile.in +2 -2
index ba2e638..97405a2 100644
@@ -176,8 +176,8 @@ PSRCS:=$(foreach s, $(SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
 PGSRCS:=$(foreach s, $(GENERATED_SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s))
 
 MAN_PAGES:=$(KEXEC_MANPAGE) $(KDUMP_MANPAGE) $(VMCORE_DMESG_MANPAGE)
-BINARIES_i386:=$(KEXEC_TEST) $(KEXEC_TEST)
-BINARIES_x86_64:=$(KEXEC) $(KDUMP) $(BINARIES_$(ARCH))
+BINARIES_i386:=$(KEXEC_TEST)
+BINARIES_x86_64:=$(KEXEC_TEST)
 BINARIES:=$(KEXEC) $(KDUMP) $(VMCORE_DMESG) $(BINARIES_$(ARCH))
Quoted 4 lines

Makefile.in PSRCS:=$(foreach s, $(SRCS), $(PACKAGE_NAME)-$(PACKAGE_VERSION)/$(s)) · line 183

Quoted 2 lines
Makefile.in +0 -0
 TARGETS:=$(BINARIES) $(MAN_PAGES)

That looks like a much needed fix and clean up.

Thanks, applied.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec