Skip to contentSkip to conversation

ARM: OMAP: resolve sparse warning concerning debug_card_init()

PATCH New Paul Walmsley 3 participants 3 messages Oct 9, 2012 – Oct 16, 2012

Subsystems (2)
Arm (32-bit) Arm sub-architectures
lore
Share & tools
lore

Paul Walmsley

author
#0 lore raw

PATCH 1/1 ARM: OMAP: resolve sparse warning concerning debug_card_init()

Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move debug_card_init() function") results in the following new sparse warning:

arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?

Fix by implementing Tony's suggestion to add a "sideways include" to the new location of the debug-devices.h file in arch/arm/mach-omap2/.

Signed-off-by Paul Walmsley <[email protected]>
Cc Igor Grinberg <[email protected]>
Cc Tony Lindgren <[email protected]>
---
 arch/arm/plat-omap/debug-devices.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/plat-omap/debug-devices.c +1 -0
index c7a4c09..5a4678e 100644
@@ -16,6 +16,7 @@
 #include <linux/smc91x.h>
 
 #include <mach/hardware.h>
+#include "../mach-omap2/debug-devices.h"
 
 /* Many OMAP development platforms reuse the same "debug board"; these
  * platforms include H2, H3, H4, and Perseus2.
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 ARM: OMAP: resolve sparse warning concerning debug_card_init()

Quoted 5 lines · Paul Walmsley

Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move debug_card_init() function") results in the following new sparse warning:

Quoted 8 lines

arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?

Fix by implementing Tony's suggestion to add a "sideways include" to the new location of the debug-devices.h file in arch/arm/mach-omap2/.

Signed-off-by Paul Walmsley <[email protected]>
Cc Igor Grinberg <[email protected]>
Cc Tony Lindgren <[email protected]>
Acked-by Igor Grinberg <[email protected]>
Quoted 16 lines
---
 arch/arm/plat-omap/debug-devices.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/plat-omap/debug-devices.c +1 -0
index c7a4c09..5a4678e 100644
@@ -16,6 +16,7 @@
 #include <linux/smc91x.h>
 
 #include <mach/hardware.h>
+#include "../mach-omap2/debug-devices.h"
 
 /* Many OMAP development platforms reuse the same "debug board"; these
  * platforms include H2, H3, H4, and Perseus2.
Signature · 2 lines
Regards,
Igor.
#2 lore raw

PATCH 1/1 ARM: OMAP: resolve sparse warning concerning debug_card_init()

Quoted 8 lines · Igor Grinberg
Quoted 7 lines · Paul Walmsley

Commit 801475ccb2b2c1928b22aec4b9e5285d9e347602 ("ARM: OMAP: move debug_card_init() function") results in the following new sparse warning:

arch/arm/plat-omap/debug-devices.c:71:12: warning: symbol 'debug_card_init' was not declared. Should it be static?

Quoted 8 lines
Quoted 6 lines

Fix by implementing Tony's suggestion to add a "sideways include" to the new location of the debug-devices.h file in arch/arm/mach-omap2/.

Signed-off-by Paul Walmsley <[email protected]>
Cc Igor Grinberg <[email protected]>
Cc Tony Lindgren <[email protected]>
Acked-by Igor Grinberg <[email protected]>

Thanks, applying into omap-for-v3.7-rc1/fixes-part2.

Regards,

Tony

Quoted 20 lines
Quoted 16 lines
---
 arch/arm/plat-omap/debug-devices.c |    1 +
 1 file changed, 1 insertion(+)
arch/arm/plat-omap/debug-devices.c +1 -0
index c7a4c09..5a4678e 100644
@@ -16,6 +16,7 @@
 #include <linux/smc91x.h>
 
 #include <mach/hardware.h>
+#include "../mach-omap2/debug-devices.h"
 
 /* Many OMAP development platforms reuse the same "debug board"; these
  * platforms include H2, H3, H4, and Perseus2.
Signature · 2 lines
Regards,
Igor.