p2p question

Hi Johannes,

Reading the comment on .add_virtual_intf() callback I am a bit confused.

=====
* @add_virtual_intf: create a new virtual interface with the given name,
* must set the struct wireless_dev's iftype. Beware: You must create
* the new netdev in the wiphy's network namespace! Returns the struct
* wireless_dev, or an ERR_PTR. For P2P device wdevs, the driver must
* also set the address member in the wdev.
=====

The last sentence refers to the "address member in wdev", but at least in my tree struct wireless_dev does not have an address member. Missing something here?

Quoted 12 lines · Arend van Spriel

Hi Johannes,

Reading the comment on .add_virtual_intf() callback I am a bit confused.

=====
* @add_virtual_intf: create a new virtual interface with the given name,
* must set the struct wireless_dev's iftype. Beware: You must create
* the new netdev in the wiphy's network namespace! Returns the struct
* wireless_dev, or an ERR_PTR. For P2P device wdevs, the driver must
* also set the address member in the wdev.
=====

Quoted 3 lines

The last sentence refers to the "address member in wdev", but at least in my tree struct wireless_dev does not have an address member. Missing something here?

It does in my tree?

struct wireless_dev {
...

         u8 address[ETH_ALEN] __aligned(sizeof(u16));

maybe you missed it?