xfs: report projid32bit feature in geometry call
PATCH 1/1 xfs: report projid32bit feature in geometry call
When xfs gained the projid32bit feature, it was never added to the FSGEOMETRY ioctl feature flags, so it's not queryable without this patch.
---
note1: is there a reason we had gaps in the flags?
note2: I don't *think* this requires a new version for the ioctl
fs/xfs/xfs_fs.h +2 -1
@@ -233,7 +233,8 @@ typedef struct xfs_fsop_resblks {#define XFS_FSOP_GEOM_FLAGS_LOGV2 0x0100/* log format version 2 */ #define XFS_FSOP_GEOM_FLAGS_SECTOR 0x0200/* sector sizes >1BB */ #define XFS_FSOP_GEOM_FLAGS_ATTR2 0x0400/* inline attributes rework */ -#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000/* ASCII only CI names */ +#define XFS_FSOP_GEOM_FLAGS_PROJID32 0x0800/* 32-bit project IDs */ +#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000/* ASCII only CI names */ #define XFS_FSOP_GEOM_FLAGS_LAZYSB 0x4000/* lazy superblock counters */
fs/xfs/xfs_fsops.c +3 -1
@@ -97,7 +97,9 @@ xfs_fs_geometry( (xfs_sb_version_haslazysbcount (&mp->m_sb) ?XFS_FSOP_GEOM_FLAGS_LAZYSB :0 ) | (xfs_sb_version_hasattr2 (&mp->m_sb) ? -XFS_FSOP_GEOM_FLAGS_ATTR2 :0 ); +XFS_FSOP_GEOM_FLAGS_ATTR2 :0 ) | + (xfs_sb_version_hasprojid32bit (&mp->m_sb) ? +XFS_FSOP_GEOM_FLAGS_PROJID32 :0 ); geo->logsectsize =xfs_sb_version_hassector (&mp->m_sb) ? mp->m_sb.sb_logsectsize :BBSIZE ; geo->rtsectsize = mp->m_sb.sb_blocksize;
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 40 lines · Eric Sandeen
When xfs gained the projid32bit feature, it was never added to the FSGEOMETRY ioctl feature flags, so it's not queryable without this patch.
Signed-off-by Eric Sandeen <[email protected]>---
note1: is there a reason we had gaps in the flags?
note2: I don't *think* this requires a new version for the ioctlfs/xfs/xfs_fs.h +2
-1@@ -233,7 +233,8 @@ typedef struct xfs_fsop_resblks {#define XFS_FSOP_GEOM_FLAGS_LOGV2 0x0100/* log format version 2 */ #define XFS_FSOP_GEOM_FLAGS_SECTOR 0x0200/* sector sizes >1BB */ #define XFS_FSOP_GEOM_FLAGS_ATTR2 0x0400/* inline attributes rework */ -#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000/* ASCII only CI names */ +#define XFS_FSOP_GEOM_FLAGS_PROJID32 0x0800/* 32-bit project IDs */ +#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000/* ASCII only CI names */ #define XFS_FSOP_GEOM_FLAGS_LAZYSB 0x4000/* lazy superblock counters */ fs/xfs/xfs_fsops.c +3
-1@@ -97,7 +97,9 @@ xfs_fs_geometry( (xfs_sb_version_haslazysbcount (&mp->m_sb) ?XFS_FSOP_GEOM_FLAGS_LAZYSB :0 ) | (xfs_sb_version_hasattr2 (&mp->m_sb) ? -XFS_FSOP_GEOM_FLAGS_ATTR2 :0 ); +XFS_FSOP_GEOM_FLAGS_ATTR2 :0 ) | + (xfs_sb_version_hasprojid32bit (&mp->m_sb) ? +XFS_FSOP_GEOM_FLAGS_PROJID32 :0 ); geo->logsectsize =xfs_sb_version_hassector (&mp->m_sb) ? mp->m_sb.sb_logsectsize :BBSIZE ; geo->rtsectsize = mp->m_sb.sb_blocksize;
Quoted 4 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Looks good,
Signature · 6 lines
--Carlos _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 8 lines · Eric Sandeen
When xfs gained the projid32bit feature, it was never added to the FSGEOMETRY ioctl feature flags, so it's not queryable without this patch.
Signed-off-by Eric Sandeen <[email protected]>---
note1: is there a reason we had gaps in the flags?
No idea. I don't think it matters, though.
Quoted 1 line
note2: I don't *think* this requires a new version for the ioctl
No, it doesn't - the structure format is unchanged.
Looks good.
Signature · 7 lines
Dave Chinner [email protected] _______________________________________________ xfs mailing list [email protected] http://oss.sgi.com/mailman/listinfo/xfs
Quoted 5 lines · Eric Sandeen
When xfs gained the projid32bit feature, it was never added to the FSGEOMETRY ioctl feature flags, so it's not queryable without this patch.
Signed-off-by Eric Sandeen <[email protected]>
SGI, can you please add a :
when this is committed? New stuff will be depending on this and it'd be good to get it munged into stable kernels as well.
Quoted 35 lines
---
note1: is there a reason we had gaps in the flags?
note2: I don't *think* this requires a new version for the ioctlfs/xfs/xfs_fs.h +2
-1@@ -233,7 +233,8 @@ typedef struct xfs_fsop_resblks {#define XFS_FSOP_GEOM_FLAGS_LOGV2 0x0100/* log format version 2 */ #define XFS_FSOP_GEOM_FLAGS_SECTOR 0x0200/* sector sizes >1BB */ #define XFS_FSOP_GEOM_FLAGS_ATTR2 0x0400/* inline attributes rework */ -#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000/* ASCII only CI names */ +#define XFS_FSOP_GEOM_FLAGS_PROJID32 0x0800/* 32-bit project IDs */ +#define XFS_FSOP_GEOM_FLAGS_DIRV2CI 0x1000/* ASCII only CI names */ #define XFS_FSOP_GEOM_FLAGS_LAZYSB 0x4000/* lazy superblock counters */ fs/xfs/xfs_fsops.c +3
-1@@ -97,7 +97,9 @@ xfs_fs_geometry( (xfs_sb_version_haslazysbcount (&mp->m_sb) ?XFS_FSOP_GEOM_FLAGS_LAZYSB :0 ) | (xfs_sb_version_hasattr2 (&mp->m_sb) ? -XFS_FSOP_GEOM_FLAGS_ATTR2 :0 ); +XFS_FSOP_GEOM_FLAGS_ATTR2 :0 ) | + (xfs_sb_version_hasprojid32bit (&mp->m_sb) ? +XFS_FSOP_GEOM_FLAGS_PROJID32 :0 ); geo->logsectsize =xfs_sb_version_hassector (&mp->m_sb) ? mp->m_sb.sb_logsectsize :BBSIZE ; geo->rtsectsize = mp->m_sb.sb_blocksize;
Quoted 5 lines
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 5 lines · Eric Sandeen
Quoted 4 lines · Eric Sandeen
When xfs gained the projid32bit feature, it was never added to the FSGEOMETRY ioctl feature flags, so it's not queryable without this patch.
Quoted 7 lines
Quoted 1 line
Signed-off-by Eric Sandeen <[email protected]>SGI, can you please add a :
when this is committed? New stuff will be depending on this and it'd be good to get it munged into stable kernels as well.
Yep. Will do so.
-Ben
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
Quoted 8 lines · Ben Myers
Quoted 7 lines · Eric Sandeen
Quoted 5 lines · Eric Sandeen
When xfs gained the projid32bit feature, it was never added to the FSGEOMETRY ioctl feature flags, so it's not queryable without this patch.
Signed-off-by Eric Sandeen <[email protected]>
Quoted 7 lines
Quoted 5 lines
SGI, can you please add a :
when this is committed? New stuff will be depending on this and it'd be good to get it munged into stable kernels as well.
Yep. Will do so.
actually in the end I didn't depend on it in xfsdump, so it's up to you about -stable.
Thanks,
-Eric
Quoted 2 lines
-Ben
_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs