m28: Properly configure the SPI flash chipselect
PATCH 1/1 m28: Properly configure the SPI flash chipselect
The SPI flash is not properly detected by plain "sf probe" due to it being located on different bus and different chipselect. Fix this problem.
--- include/configs/m28evk.h | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-)
include/configs/m28evk.h +5 -3
@@ -246,18 +246,20 @@#define CONFIG_MXS_SPI_DMA_ENABLE #define CONFIG_SPI_HALF_DUPLEX #define CONFIG_DEFAULT_SPI_BUS 2 +#define CONFIG_DEFAULT_SPI_CS 0#define CONFIG_DEFAULT_SPI_MODE SPI_MODE_0/* SPI FLASH */ #ifdef CONFIG_CMD_SF #define CONFIG_SPI_FLASH #define CONFIG_SPI_FLASH_STMICRO -#define CONFIG_SF_DEFAULT_CS 2 -#define CONFIG_SF_DEFAULT_MODE SPI_MODE_0 +#define CONFIG_SF_DEFAULT_BUS 2 +#define CONFIG_SF_DEFAULT_CS 0#define CONFIG_SF_DEFAULT_SPEED 40000000 +#define CONFIG_SF_DEFAULT_MODE SPI_MODE_0 -#define CONFIG_ENV_SPI_CS 0#define CONFIG_ENV_SPI_BUS 2 +#define CONFIG_ENV_SPI_CS 0#define CONFIG_ENV_SPI_MAX_HZ 40000000#define CONFIG_ENV_SPI_MODE SPI_MODE_0#endif
Signature · 1 line
1.7.10.4
PATCH 1/1 m28: Properly configure the SPI flash chipselect
Dear Tom Rini,
Quoted 7 lines
The SPI flash is not properly detected by plain "sf probe" due to it being located on different bus and different chipselect. Fix this problem.
Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>Cc Tom Rini <[email protected]>
[...]
Please apply for .10 release, this is an important bugfix. Tested by DUTS as of now.
Best regards,
Marek Vasut
PATCH 1/1 m28: Properly configure the SPI flash chipselect
Am 12/10/2012 04:08, schrieb Marek Vasut:
Quoted 6 lines
Dear Tom Rini,
Quoted 4 lines
The SPI flash is not properly detected by plain "sf probe" due to it being located on different bus and different chipselect. Fix this problem.
Quoted 7 lines
Quoted 3 lines
Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>Cc Tom Rini <[email protected]>[...]
Please apply for .10 release, this is an important bugfix. Tested by DUTS as of now.
So should Tom apply it directly to u-boot/master or do you think we follow the usual path through u-boot-imx/master ?
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 m28: Properly configure the SPI flash chipselect
Dear Stefano Babic,
Quoted 11 lines
Am 12/10/2012 04:08, schrieb Marek Vasut:
Quoted 10 lines
Dear Tom Rini,
Quoted 7 lines
The SPI flash is not properly detected by plain "sf probe" due to it being located on different bus and different chipselect. Fix this problem.
Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>Cc Tom Rini <[email protected]>
Quoted 7 lines
Quoted 4 lines
[...]
Please apply for .10 release, this is an important bugfix. Tested by DUTS as of now.
So should Tom apply it directly to u-boot/master or do you think we follow the usual path through u-boot-imx/master ?
I don't have any further patches, so if Tom is OK with picking it up directly, WFM.
Best regards,
Marek Vasut
PATCH 1/1 m28: Properly configure the SPI flash chipselect
Am 12/10/2012 10:07, schrieb Marek Vasut:
Quoted 15 lines
Dear Stefano Babic,
Quoted 13 lines
Am 12/10/2012 04:08, schrieb Marek Vasut:
Quoted 12 lines
Dear Tom Rini,
Quoted 7 lines
The SPI flash is not properly detected by plain "sf probe" due to it being located on different bus and different chipselect. Fix this problem.
Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>Cc Tom Rini <[email protected]>[...]
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Please apply for .10 release, this is an important bugfix. Tested by DUTS as of now.
So should Tom apply it directly to u-boot/master or do you think we follow the usual path through u-boot-imx/master ?
I don't have any further patches, so if Tom is OK with picking it up directly, WFM.
Ok, fine with m, of course !
Stefano
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================
PATCH 1/1 m28: Properly configure the SPI flash chipselect
In reply to Marek VasutQuoted 7 lines · Marek Vasut
The SPI flash is not properly detected by plain "sf probe" due to it being located on different bus and different chipselect. Fix this problem.
Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>Cc Tom Rini <[email protected]>
Applied to u-boot/master, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20121012/d4790dca/attachment.pgp>